Fix #115 fix negative effect

modules/pegasus-actor-sheet.js

@@ -61,6 +61,7 @@ export class PegasusActorSheet extends ActorSheet {
       encCapacity: this.actor.getEncumbranceCapacity(),
       levelRemainingList: this.actor.getLevelRemainingList(),
       maxLevelRemainingList: this.actor.getMaxLevelRemainingList(),
+      disabledBonus: (this.actor.system.biodata.noautobonus) ? "" : "disabled",
       containersTree: this.actor.containersTree,
       encCurrent: this.actor.encCurrent,
       encHindrance: this.actor.encHindrance,
@@ -249,13 +250,13 @@ export class PegasusActorSheet extends ActorSheet {
       this.actor.rollPool( 'def', true, "defence");
     });
     html.find('.damage-melee').click((event) => {
-      this.actor.rollPool( 'str', false, "melee-dmg");
+      this.actor.rollPool( 'str', false, "melee-dmg")
     });
     html.find('.damage-ranged').click((event) => {
       this.actor.rollPool( 'per', false, "ranged-dmg");
     });
     html.find('.damage-resistance').click((event) => {
-      this.actor.rollPool( 'phy', false, "dmg-res");
+      this.actor.rollPool( 'phy', false, "dmg-res")
     });
             
     html.find('.roll-stat').click((event) => {

modules/pegasus-actor.js

@@ -15,7 +15,7 @@ const __statBuild = [
   //{ modules: ["vehiclehull"], field: "pc", itemfield: "vms", subfield: "avgnrg" },
   //{ modules: ["powercoremodule"], field: "pc", itemfield: "nrg", subfield: "avgnrg" },
   { modules: ["vehiclehull", "mobilitymodule"], itemfield: "man", field: "man", additionnal1: "turningarc45" },
-  { modules: ["powercoremodule"], field: "pc", itemfield: "pc", additionnal1: "curnrg", additionnal2: "maxnrg" },
+  { modules: ["powercoremodule"], field: "pc", itemfield: "pc" },
   { modules: ["mobilitymodule"], field: "mr", itemfield: "mr" },
   { modules: ["propulsionmodule"], field: "ad", itemfield: "ad" },
   { modules: ["combatmodule"], field: "fc", itemfield: "fc" },
@@ -124,9 +124,9 @@ export class PegasusActor extends Actor {
       this.updateSize()
     }
     if (this.type == 'vehicle') {
-      this.computeVehicleStats();
+      this.computeVehicleStats()
     }
-    super.prepareDerivedData();
+    super.prepareDerivedData()
   }
 
   /* -------------------------------------------- */
@@ -194,8 +194,13 @@ export class PegasusActor extends Actor {
     let comp = this.items.filter(item => item.type == 'vehiclemodule');
     return comp;
   }
-  getVehicleWeaponModules() {
-    let comp = this.items.filter(item => item.type == 'vehicleweaponmodule');
+  getVehicleWeaponModules( activated = false ) {
+    let comp = []
+    if (activated ) {
+      comp = this.items.filter(item => item.type == 'vehicleweaponmodule' && item.system.activated)
+    } else {
+      comp = this.items.filter(item => item.type == 'vehicleweaponmodule' )    
+    }
     return comp;
   }
 
@@ -240,7 +245,7 @@ export class PegasusActor extends Actor {
   /* -------------------------------------------- */
   getRoleLevel() {
     let role = this.items.find(item => item.type == 'role')
-    if (role ) {
+    if (role) {
       console.log("Role", role)
       return role.system.rolelevel
     }
@@ -253,23 +258,26 @@ export class PegasusActor extends Actor {
     return role && role.system.perksrole == "tactician"
   }
   hasTacticianBonus() {
-    let effect = this.items.find( item => item.name.toLowerCase().includes("tactician bonus dice") )
+    let effect = this.items.find(item => item.name.toLowerCase().includes("tactician bonus dice"))
     return effect
   }
   async addTacticianEffect(name, level) {
     let effect = duplicate(__bonusEffect)
     effect.name = `${name} Tactician Bonus Dice`
-    effect.system.effectlevel = level 
+    effect.system.effectlevel = level
     effect.system.stataffected = "mr"
     effect.system.bonusdice = true
     await this.createEmbeddedDocuments('Item', [effect])
-    ChatMessage.create({ content: `Tactician Bonus Dice has been added to ${this.name} (${level})` })
+    ChatMessage.create({
+      content: `Tactician Bonus Dice has been added to ${this.name} (${level})`,
+      whisper: ChatMessage.getWhisperRecipients('GM')
+    })
   }
   async removeTacticianEffect() {
-    let effect = this.items.find( item => item.name.toLowerCase().includes("tactician bonus dice") )
+    let effect = this.items.find(item => item.name.toLowerCase().includes("tactician bonus dice"))
     if (effect) {
       await this.deleteEmbeddedDocuments('Item', [effect.id])
-      ChatMessage.create({ content: `Tactician Bonus Dice has been removed to ${this.name}` })  
+      ChatMessage.create({ content: `Tactician Bonus Dice has been removed to ${this.name}`, whisper: ChatMessage.getWhisperRecipients('GM') })
     }
   }
 
@@ -279,23 +287,23 @@ export class PegasusActor extends Actor {
     return role && role.system.perksrole == "enhancer"
   }
   hasEnhancerBonus() {
-    let effect = this.items.find( item => item.name.toLowerCase().includes("enhancer bonus dice") )
+    let effect = this.items.find(item => item.name.toLowerCase().includes("enhancer bonus dice"))
     return effect
   }
-  async addEnhancerEffect( name, level) {
+  async addEnhancerEffect(name, level) {
     let effect = duplicate(__bonusEffect)
     effect.name = `${name} Enhancer Bonus Dice ALL`
-    effect.system.effectlevel = level 
+    effect.system.effectlevel = level
     effect.system.stataffected = "all"
     effect.system.bonusdice = true
     await this.createEmbeddedDocuments('Item', [effect])
-    ChatMessage.create({ content: `Enhancer Bonus Dice has been added to ${this.name} (${level})` })
+    ChatMessage.create({ content: `Enhancer Bonus Dice has been added to ${this.name} (${level})`, whisper: ChatMessage.getWhisperRecipients('GM') })
   }
   async removeEnhancerEffect() {
-    let effect = this.items.find( item => item.name.toLowerCase().includes("enhancer bonus dice") )
+    let effect = this.items.find(item => item.name.toLowerCase().includes("enhancer bonus dice"))
     if (effect) {
       await this.deleteEmbeddedDocuments('Item', [effect.id])
-      ChatMessage.create({ content: `Enhancer Bonus Dice has been removed to ${this.name}` })  
+      ChatMessage.create({ content: `Enhancer Bonus Dice has been removed to ${this.name}`, whisper: ChatMessage.getWhisperRecipients('GM') })
     }
   }
 
@@ -305,24 +313,24 @@ export class PegasusActor extends Actor {
     return role && role.system.perksrole == "agitator"
   }
   hasAgitatorHindrance() {
-    let effect = this.items.find( item => item.name.toLowerCase().includes("hindered by agitator") )
+    let effect = this.items.find(item => item.name.toLowerCase().includes("hindered by agitator"))
     return effect
   }
   async addAgitatorHindrance(name, level) {
     let effect = duplicate(__bonusEffect)
     effect.name = `Hindered by Agitator ${name}`
-    effect.system.effectlevel = level 
+    effect.system.effectlevel = level
     effect.system.stataffected = "all"
     effect.system.genre = "negative"
     effect.system.hindrance = true
     await this.createEmbeddedDocuments('Item', [effect])
-    ChatMessage.create({ content: `Agitator Hindrance has been added to ${this.name} (${level})` })
+    ChatMessage.create({ content: `Agitator Hindrance has been added to ${this.name} (${level})`, whisper: ChatMessage.getWhisperRecipients('GM') })
   }
   async removeAgitatorHindrance() {
-    let effect = this.items.find( item => item.name.toLowerCase().includes("hindered by agitator") )
+    let effect = this.items.find(item => item.name.toLowerCase().includes("hindered by agitator"))
     if (effect) {
       await this.deleteEmbeddedDocuments('Item', [effect.id])
-      ChatMessage.create({ content: `Agitator Hindrance has been removed to ${this.name}` })  
+      ChatMessage.create({ content: `Agitator Hindrance has been removed to ${this.name}`, whisper: ChatMessage.getWhisperRecipients('GM') })
     }
   }
 
@@ -331,7 +339,7 @@ export class PegasusActor extends Actor {
     if (item.system.resistance) {
       item.system.resistanceDice = PegasusUtility.getDiceFromLevel(item.system.resistance)
     }
-    if (item.system.idr) {
+    if (item.system.idr && Number(item.system.idr) > 0) {
       item.system.idrDice = PegasusUtility.getDiceFromLevel(item.system.idr)
     }
     if (item.system.damage) {
@@ -808,9 +816,11 @@ export class PegasusActor extends Actor {
         ChatMessage.create({ content: "Effects of this type cannot be applied while Immunity is applied" })
         return
       }
+      if (item.system.droptext && item.system.droptext.length > 0) {
+        ChatMessage.create({ content: `Effect ${item.name} message : ${item.system.droptext}` })
+      }
     }
 
-
     if (item.type == 'race') {
       this.applyRace(item)
     } else if (item.type == 'role') {
@@ -909,12 +919,16 @@ export class PegasusActor extends Actor {
   getStat(statKey) {
     let stat
     if (this.type == "character" && statKey == 'mr') {
-      stat = duplicate(this.system.mr);
+      stat = duplicate(this.system.mr)
     } else {
-      stat = duplicate(this.system.statistics[statKey]);
+      stat = duplicate(this.system.statistics[statKey])
     }
-    stat.dice = PegasusUtility.getDiceFromLevel(stat.value || stat.level);
-    return stat;
+    if (stat.currentlevel) {
+      stat.dice = PegasusUtility.getDiceFromLevel(stat.currentlevel)
+    } else {
+      stat.dice = PegasusUtility.getDiceFromLevel(stat.value || stat.level)
+    }
+    return stat
   }
 
   /* -------------------------------------------- */
@@ -1442,17 +1456,30 @@ export class PegasusActor extends Actor {
 
   /* -------------------------------------------- */
   parseStatEffects() {
-    let effects = this.items.filter(effect => effect.type == "effect" && effect.system.genre == "positive" && effect.system.statdice)
+    if (this.system.biodata.noautobonus) { // If we are in "no-bonus mode
+      return
+    }
+    let effectsPlus = this.items.filter(effect => effect.type == "effect" && effect.system.genre == "positive" && effect.system.statdice)
+    let effectsMinus = this.items.filter(effect => effect.type == "effect" && effect.system.genre == "negative" && effect.system.reducedicevalue)
     for (let statKey in this.system.statistics) {
       let stat = duplicate(this.system.statistics[statKey])
       let bonus = 0
-      for (let effect of effects) {
+      for (let effect of effectsPlus) {
         if (effect.system.stataffected == statKey) {
           bonus += Number(effect.system.effectlevel)
         }
       }
+      for (let effect of effectsMinus) {
+        if (effect.system.stataffected == statKey) {
+          bonus -= Number(effect.system.effectlevel)
+        }
+      }
       if (bonus != stat.bonuseffect) {
         stat.bonuseffect = bonus
+        if ( stat.bonuseffect + stat.value < 1) {
+          stat.value = 1
+          stat.bonuseffect = 0
+        }
         this.update({ [`system.statistics.${statKey}`]: stat })
       }
     }
@@ -1460,6 +1487,9 @@ export class PegasusActor extends Actor {
 
   /* -------------------------------------------- */
   parseStatusEffects() {
+    if (this.system.biodata.noautobonus) { // If we are in "no-bonus mode
+      return
+    }
     let effects = this.items.filter(effect => effect.type == "effect" && effect.system.affectstatus && (Number(effect.system.effectlevel) > 0))
     for (let statusKey in this.system.secondary) {
       let status = duplicate(this.system.secondary[statusKey])
@@ -1724,7 +1754,7 @@ export class PegasusActor extends Actor {
     let effects = this.items.filter(item => item.type == 'effect')
     for (let effect of effects) {
       effect = duplicate(effect)
-      if (!effect.system.hindrance && !effect.system.statdice
+      if (!effect.system.hindrance && !effect.system.statdice && !effect.system.reducedicevalue
         && (effect.system.stataffected != "notapplicable" || effect.system.specaffected.length > 0)
         && effect.system.stataffected != "special"
         && effect.system.stataffected != "powerroll"
@@ -1745,8 +1775,8 @@ export class PegasusActor extends Actor {
   }
 
   /* -------------------------------------------- */
-  addArmorsShields(rollData, statKey = "none", useShield = false) {
-    if (statKey == 'phy') {
+  addArmorsShields(rollData, statKey = "none", useShield = false, subKey = undefined) {
+    if (statKey == 'phy' && subKey == "dmg-res") {
       let armors = this.getArmors()
       for (let armor of armors) {
         rollData.armorsList.push({ label: `Armor ${armor.name}`, type: "armor", applied: false, value: armor.system.resistance })
@@ -1786,7 +1816,7 @@ export class PegasusActor extends Actor {
   }
   addVehicleWeapons(rollData, vehicle) {
     if (vehicle) {
-      let modules = vehicle.items.filter(vehicle => vehicle.type == "vehicleweaponmodule")
+      let modules = vehicle.items.filter(item => item.type == "vehicleweaponmodule" && item.system.activated)
       if (modules && modules.length > 0) {
         for (let module of modules) {
           rollData.vehicleWeapons.push({ label: `Weapon ${module.name}`, type: "item", applied: false, weapon: module, value: module.system.damagedicevalue })
@@ -1795,6 +1825,33 @@ export class PegasusActor extends Actor {
     }
   }
 
+  /* -------------------------------------------- */
+  processVehicleTargetMessage(rollData) {
+    if (rollData.defenderTokenId) {
+      let vehicle = game.canvas.tokens.get(rollData.defenderTokenId).actor
+      if (vehicle.type == "vehicle") {
+        if (rollData.subKey == "defence" && vehicle.system.statistics.ad.currentspeed == "crawling") {
+          ChatMessage.create({ content: `${vehicle.name} is moving at Crawling speed : add a D8 to your Attack Dice Pool against this Vehicle` })
+        }
+        if (rollData.subKey == "defence" && vehicle.system.statistics.ad.currentspeed == "slow") {
+          ChatMessage.create({ content: `${vehicle.name} is moving at Slow speed : add a D4 to your Attack Dice Pool against this Vehicle` })
+        }
+      }
+      if (this.type == "vehicle"  && rollData.statKey == "man" && this.system.statistics.ad.currentspeed == "fast") {
+        ChatMessage.create({ content: `${this.name} is moving at Fast speed : anyone using the vehicles MAN Dice Pool suffers a D8 Hindrance which is added to the Difficulty Dice Pool against this Vehicle` })
+      }
+      if (this.type == "vehicle"  && rollData.statKey == "man" && this.system.statistics.ad.currentspeed == "extfast") {
+        ChatMessage.create({ content: `${this.name} is moving at Extremely Fast speed : anyone using the vehicles MAN Dice Pool suffers a D12 Hindrance which is added to the Difficulty Dice Pool against this Vehicle` })
+      }
+      if (rollData.subKey == "defence" && rollData.vehicle && rollData.vehicle.system.statistics.ad.currentspeed == "crawling") {
+        ChatMessage.create({ content: `${this.name} is moving at Crawling speed : add a D8 to your Attack Dice Pool against this Vehicle` })
+      }
+      if (rollData.subKey == "defence" && rollData.vehicle && rollData.vehicle.system.statistics.ad.currentspeed == "slow") {
+        ChatMessage.create({ content: `${this.name} is moving at Slow speed : add a D4 to your Attack Dice Pool against this Vehicle` })
+      }
+  }
+  }
+
   /* -------------------------------------------- */
   getCommonRollData(statKey = undefined, useShield = false, isInit = false, isPower = false, subKey = "", vehicle = undefined) {
     let rollData = PegasusUtility.getBasicRollData(isInit)
@@ -1819,8 +1876,12 @@ export class PegasusActor extends Actor {
       rollData.stat = this.getStat(statKey)
       if (rollData.stat.value != undefined) {
         rollData.stat.level = rollData.stat.value // Normalize
+        rollData.statDicesLevel = rollData.stat.level + rollData.stat.bonuseffect
+      }
+      if (rollData.stat.currentlevel) {
+        rollData.stat.level = rollData.stat.currentlevel
+        rollData.statDicesLevel = rollData.stat.currentlevel
       }
-      rollData.statDicesLevel = rollData.stat.level + rollData.stat.bonuseffect
       rollData.statMod = rollData.stat.mod
       if (vehicle) {
         rollData.vehicle = duplicate(vehicle)
@@ -1850,8 +1911,6 @@ export class PegasusActor extends Actor {
           vehicle.addVehicleShields(rollData)
         }
         vehicle.addEffects(rollData, false, false, false)
-        //this.addVehiculeHindrances(rollData.effectsList, vehicle)
-        //this.addVehicleBonus(rollData, vehicle)
       }
 
       rollData.specList = this.getRelevantSpec(statKey)
@@ -1868,11 +1927,35 @@ export class PegasusActor extends Actor {
       }
     }
 
+    if (statKey == "mr") {
+      if (this.type == "character") {
+        rollData.mrVehicle = PegasusUtility.checkIsVehicleCrew(this.id)
+        if (rollData.mrVehicle) {
+          rollData.effectsList.push({
+            label: `Vehicle ${rollData.mrVehicle.name} MR Bonus`,
+            type: "effect", applied: false, isdynamic: true, value: rollData.mrVehicle.system.statistics.mr.currentlevel
+          })
+        }
+      }
+      if (this.type == "vehicle") {
+        for (let member of this.system.crew) {
+          let actor = game.actors.get(member.id)
+          let specList = actor.getRelevantSpec("mr")
+          rollData.effectsList.push({
+            label: `Crew ${actor.name} MR Bonus`,
+            type: "effect", applied: false, isdynamic: true, value: actor.system.mr.value + actor.system.mr.bonuseffect, specList: specList
+          })
+        }
+      }
+    }
+
     this.processSizeBonus(rollData)
     this.addEffects(rollData, isInit, isPower, subKey == "power-dmg")
-    this.addArmorsShields(rollData, statKey, useShield)
+    this.addArmorsShields(rollData, statKey, useShield, subKey)
     this.addWeapons(rollData, statKey, useShield)
     this.addEquipments(rollData, statKey)
+    this.processVehicleTargetMessage(rollData)
+
     console.log("ROLLDATA", rollData)
 
     return rollData
@@ -1881,7 +1964,14 @@ export class PegasusActor extends Actor {
   /* -------------------------------------------- */
   processSizeBonus(rollData) {
     if (rollData.defenderTokenId) {
-      let diffSize = rollData.defenderSize - this.system.biodata.sizenum + this.system.biodata.sizebonus
+      let diffSize = 0
+      if (this.type == "character") {
+        this.system.biodata.sizenum = this.system.biodata?.sizenum ?? 0
+        this.system.biodata.sizebonus = this.system.biodata?.sizebonus ?? 0
+        diffSize = rollData.defenderSize - this.system.biodata.sizenum + this.system.biodata.sizebonus
+      } else {
+        diffSize = rollData.defenderSize - this.system.statistics.hr.size
+      }
       //console.log("Diffsize", diffSize)
       if (rollData.subKey == "melee-atk" || rollData.subKey == "ranged-atk") {
         if (diffSize > 0) {
@@ -1978,7 +2068,7 @@ export class PegasusActor extends Actor {
 
   /*-------------------------------------------- */
   rollStat(statKey) {
-    let stat = this.getStat(statKey);
+    let stat = this.getStat(statKey)
     if (stat) {
       let rollData = this.getCommonRollData(statKey)
       rollData.mode = "stat"
@@ -2132,6 +2222,36 @@ export class PegasusActor extends Actor {
     effect.system.isspeed = speed
     await this.createEmbeddedDocuments("Item", [effect])
   }
+  /* -------------------------------------------- */
+  processVehicleStatEffects() {
+    let effectsPlus = this.items.filter(effect => effect.type == "effect" && effect.system.genre == "positive" && effect.system.statdice)
+    let effectsMinus = this.items.filter(effect => effect.type == "effect" && effect.system.genre == "negative" && effect.system.reducedicevalue)
+    for (let statKey in this.system.statistics) {
+      let stat = duplicate(this.system.statistics[statKey])
+      let bonus = 0
+      for (let effect of effectsPlus) {
+        if (effect.system.stataffected == statKey) {
+          bonus += Number(effect.system.effectlevel)
+        }
+      }
+      for (let effect of effectsMinus) {
+        if (effect.system.stataffected == statKey) {
+          bonus -= Number(effect.system.effectlevel)
+        }
+      }
+      if (bonus != stat.bonuseffect) {
+        stat.bonuseffect = bonus
+        if ( stat.bonuseffect + stat.level < 1) {
+          stat.level = 1
+          stat.bonuseffect = 0
+        }
+        if (stat.currentlevel > stat.bonuseffect+stat.level) {
+          stat.currentlevel = stat.bonuseffect+stat.level
+        }
+        this.update({ [`system.statistics.${statKey}`]: stat })
+      }  
+    }
+  }
 
   /* -------------------------------------------- */
   async computeVehicleStats() {
@@ -2223,6 +2343,7 @@ export class PegasusActor extends Actor {
         ChatMessage.create({ content: `The vehicle ${this.name} has been destroyed !` })
       }
       this.processVehicleArmorShields()
+      this.processVehicleStatEffects()
     }
   }
 
@@ -2247,6 +2368,9 @@ export class PegasusActor extends Actor {
       return
     }
 
+    if (item.type == "effect" && item.system.droptext && item.system.droptext.length > 0) {
+      ChatMessage.create({ content: `Effect ${item.name} message : ${item.system.droptext}` })
+    }
     //console.log(">>>>> item", item.type, __isVehicleUnique[item.type])
     if (__isVehicleUnique[item.type]) {
       let toDelList = []
@@ -2268,6 +2392,13 @@ export class PegasusActor extends Actor {
         return false
       }
     }
+    // NRG max management
+    if (item.type == "powercoremodule" ) {
+      if (this.system.statistics.pc.maxnrg != item.system.nrg ) {
+          this.update( {'system.statistics.pc.maxnrg': item.system.nrg })
+      }
+    }
+    
     // Cargo management
     if (__isVehicleCargo[item.type]) {
       let capacity = this.getCurrentCargoCapacity()
@@ -2299,7 +2430,6 @@ export class PegasusActor extends Actor {
     return crew
   }
 
-  /* -------------------------------------------- */
   addCrew(actorId) {
     if (this.system.crew.length >= this.system.crewmax) {
       ui.notifications.warn("Vehicle crew is already full.")
@@ -2309,11 +2439,13 @@ export class PegasusActor extends Actor {
     crewList.push({ id: actorId })
     this.update({ 'system.crew': crewList })
   }
-  /* -------------------------------------------- */
   delCrew(actorId) {
     let crewList = duplicate(this.system.crew.filter(actorDef => actorDef.id != actorId) || [])
     this.update({ 'system.crew': crewList })
   }
+  inCrew(actorId) {
+    return this.system.crew.find(member => member.id == actorId)
+  }
 
   /* -------------------------------------------- */
   isVehicleFullStop() {
@@ -2396,6 +2528,34 @@ export class PegasusActor extends Actor {
     }
   }
 
+  /* -------------------------------------------- */
+  async addVehicleModuleEffects( mod) {
+    let effects = []
+    for (let effect of mod.system.effects) {
+      if (!effect.system) {
+        effect.system = effect.data
+      }
+      effect.system.effectId = mod.id // Link to the perk, in order to dynamically remove them
+      effects.push(effect)
+    }
+    if (effects.length) {
+      await this.createEmbeddedDocuments('Item', effects)
+    }
+  }
+  /* -------------------------------------------- */
+  async removeVehicleModuleEffects( mod) {
+    let toRem = []
+    for (let item of this.items) {
+      if (item.type == 'effect' && item.system.effectId == mod.id) {
+        toRem.push(item.id)
+      }
+    }
+    console.log("TODEL", toRem)
+    if (toRem.length) {
+      await this.deleteEmbeddedDocuments('Item', toRem)
+    }
+  }
+
   /* -------------------------------------------- */
   async activateVehicleModule(itemId) {
     let mod = this.items.get(itemId)
@@ -2412,13 +2572,20 @@ export class PegasusActor extends Actor {
           pc.maxnrg -= Number(mod.system.nrg)
           pc.curnrg -= Number(mod.system.nrg)
           this.update({ 'system.statistics.pc': pc })
+          this.addVehicleModuleEffects(mod)
         } else { // Now deactivated
           pc.actnrg -= Number(mod.system.nrg)
           pc.maxnrg += Number(mod.system.nrg)
           this.update({ 'system.statistics.pc': pc })
           await this.updateEmbeddedDocuments('Item', [{ _id: mod.id, 'system.activated': !mod.system.activated }])
+          this.removeVehicleModuleEffects(mod)
         }
       } else {
+        if ( mod.system.activated)  {
+          this.removeVehicleModuleEffects(mod)
+        } else {
+          this.addVehicleModuleEffects(mod)
+        }
         await this.updateEmbeddedDocuments('Item', [{ _id: mod.id, 'system.activated': !mod.system.activated }])
       }
     }
@@ -2440,8 +2607,13 @@ export class PegasusActor extends Actor {
     for (let loc of __LocationsArmour) {
       let arcKey = loc + "arc"
       let arc = duplicate(this.system.arcs[arcKey])
-      if (level != Number(arc.shieldlevel)) {
-        arc.shieldlevel = level
+      if (level != Number(arc.maxshieldlevel)) {
+        let lvChanged = level - arc.maxshieldlevel
+        arc.maxshieldlevel = level
+        arc.shieldlevel += lvChanged
+        if ( arc.shieldlevel <= 0 || arc.shieldlevel > level) {
+          arc.shieldlevel = level
+        }
         setTimeout(shift, this.update({ [`system.arcs.${arcKey}`]: arc }))
         shift += 200
       }
@@ -2458,15 +2630,20 @@ export class PegasusActor extends Actor {
           level += Number(armour.system.armourdicevalue)
         }
       }
-      if (level != Number(arc.armourlevel)) {
-        arc.armourlevel = level
+      if (level != Number(arc.maxarmourlevel)) {
+        let lvChanged = level - arc.maxarmourlevel
+        arc.maxarmourlevel = level
+        arc.armourlevel += lvChanged
+        if ( arc.armourlevel <= 0 || arc.armourlevel > arc.maxarmourlevel) {
+          arc.armourlevel = level
+        }
         setTimeout(500, this.update({ [`system.arcs.${arcKey}`]: arc }))
       }
     }
   }
   /* -------------------------------------------- */
   updateMaxNrg(currentLevel) {
-    this.update({ 'system.statistics.pc.maxnrg': Number(currentLevel) })
+    this.update({ 'system.statistics.pc.maxnrg': Number( PegasusUtility.getDiceValue(currentLevel) ) })
   }
   /* -------------------------------------------- */
   setTurningArc(currentLevel) {

modules/pegasus-roll-dialog.js

@@ -90,6 +90,9 @@ export class PegasusRollDialog extends Dialog {
     PegasusUtility.updateDamageDicePool(this.rollData)
     PegasusUtility.updateEffectsBonusDice(this.rollData)
     PegasusUtility.updateHindranceBonusDice(this.rollData)
+    if ( effect.specList) {
+      this.rollData.specList = duplicate(effect.specList)
+    }
   }
 
   /* -------------------------------------------- */

modules/pegasus-utility.js

@@ -146,10 +146,10 @@ export class PegasusUtility {
   static updateEffectsBonusDice(rollData) {
     let newDicePool = rollData.dicePool.filter(dice => dice.name != "effect-bonus-dice")
     for (let effect of rollData.effectsList) {
-      if (effect && effect.applied && effect.type == "effect" && effect.effect && effect.effect.system.bonusdice) {
+      if (effect && effect.applied && effect.type == "effect" && !effect.effect?.system?.hindrance && effect.effect && effect.effect.system.bonusdice) {
         newDicePool = newDicePool.concat(this.buildDicePool("effect-bonus-dice", effect.effect.system.effectlevel, 0, effect.effect.name))
       }
-      if (effect && effect.applied && effect.type == "effect" && effect.value && effect.isdynamic) {
+      if (effect && effect.applied && effect.type == "effect" && effect.value && effect.isdynamic && !effect.effect?.system?.hindrance) {
         newDicePool = newDicePool.concat(this.buildDicePool("effect-bonus-dice", effect.value, 0, effect.name))
       }
     }
@@ -161,7 +161,9 @@ export class PegasusUtility {
     let newDicePool = rollData.dicePool.filter(dice => dice.name != "effect-hindrance")
     for (let hindrance of rollData.effectsList) {
       if (hindrance && hindrance.applied && (hindrance.type == "hindrance" || (hindrance.type == "effect" && hindrance.effect?.system?.hindrance))) {
+        console.log("Adding Hindrance 1", hindrance, newDicePool)
         newDicePool = newDicePool.concat(this.buildDicePool("effect-hindrance", (hindrance.value) ? hindrance.value : hindrance.effect.system.effectlevel, 0, hindrance.name))
+        console.log("Adding Hindrance 2", newDicePool)
       }
     }
     rollData.dicePool = newDicePool
@@ -175,12 +177,13 @@ export class PegasusUtility {
         newDicePool = newDicePool.concat(this.buildDicePool("armor-shield", armor.value, 0))
       }
     }
-    newDicePool = rollData.dicePool.filter(dice => dice.name != "vehicle-shield")
+    newDicePool = newDicePool.filter(dice => dice.name != "vehicle-shield")
     for (let shield of rollData.vehicleShieldList) {
       if (shield.applied) {
         newDicePool = newDicePool.concat(this.buildDicePool("vehicle-shield", shield.value, 0))
       }
     }
+    console.log(">>>>Dicepoool", newDicePool)
     rollData.dicePool = newDicePool
   }
 
@@ -541,7 +544,7 @@ export class PegasusUtility {
 
   /* -------------------------------------------- */
   static getDiceFromLevel(level = 0) {
-    level = Number(level)
+    level = Math.max( Number(level), 0)
     return this.diceList[level];
   }
   /* -------------------------------------------- */
@@ -1026,7 +1029,12 @@ export class PegasusUtility {
     if (target) {
       let defenderActor = target.actor
       rollData.defenderTokenId = target.id
-      rollData.defenderSize = Number(defenderActor.system.biodata.sizenum) + Number(defenderActor.system.biodata.sizebonus)
+      rollData.defenderSize = 0
+      if ( defenderActor.type == "character") {
+        rollData.defenderSize = Number(defenderActor.system.biodata.sizenum) + Number(defenderActor.system.biodata.sizebonus)
+      } else if ( defenderActor.type == "vehicle" ){
+        rollData.defenderSize = Number(defenderActor.system.statistics.hr.size)
+      }
       //rollData.attackerId = this.id
       console.log("Target/DEFENDER", defenderActor)
       defenderActor.addHindrancesList(rollData.effectsList)
@@ -1067,31 +1075,15 @@ export class PegasusUtility {
   }
 
   /* -------------------------------------------- */
-  static glowToken(token) {
-    let params =
-      [{
-        filterType: "glow",
-        filterId: "superSpookyGlow",
-        outerStrength: 15,
-        innerStrength: 0,
-        color: 0x6AAB8E,
-        quality: 0.5,
-        padding: 40,
-        autoDestroy: true,
-        animated:
-        {
-          color:
-          {
-            active: true,
-            loopDuration: 3000,
-            loops: 2,
-            animType: "colorOscillation",
-            val1: 0x6AAB8E,
-            val2: 0x66FF33
-          }
-        }
-      }]
-    TokenMagic.addUpdateFilters(token, params)
+  static checkIsVehicleCrew(actorId) {
+    let vehicles = game.actors.filter( actor=> actor.type == "vehicle") || []
+    for(let vehicle of vehicles)  {
+      console.log("Checking", vehicle.name)
+      if ( vehicle.inCrew(actorId) ) {
+        return vehicle
+      }
+    }
+    return false
   }
 
   /* -------------------------------------------- */
@@ -1117,7 +1109,7 @@ export class PegasusUtility {
   static async processTactician() {
     // Tactician management
     let toApply = {}
-    let tacticianTokens = canvas.tokens.placeables.filter(token => token.actor.isTactician() && !newToken.document.hidden)
+    let tacticianTokens = canvas.tokens.placeables.filter(token => token.actor.isTactician() && !token.document.hidden)
     for (let token of tacticianTokens) {
       token.refresh()
       let friends = canvas.tokens.placeables.filter(newToken => newToken.actor.type == "character" && !newToken.document.hidden && newToken.document.disposition == token.document.disposition)  
@@ -1165,7 +1157,7 @@ export class PegasusUtility {
   static async processEnhancer() {
     // Enhancer management
     let toApply = {}
-    let enhancerTokens = canvas.tokens.placeables.filter(token => token.actor.isEnhancer() && !newToken.document.hidden)
+    let enhancerTokens = canvas.tokens.placeables.filter(token => token.actor.isEnhancer() && !token.document.hidden)
     for (let token of enhancerTokens) {
       token.refresh()
       let friends = canvas.tokens.placeables.filter(newToken => newToken.actor.type == "character" && !newToken.document.hidden && newToken.document.disposition == token.document.disposition)  
@@ -1215,17 +1207,18 @@ export class PegasusUtility {
   static async processAgitator() {
     // Agitator management
     let toApply = {}
-    let agitatorTokens = canvas.tokens.placeables.filter(token => token.actor.isAgitator())
+    let agitatorTokens = canvas.tokens.placeables.filter(token => token.actor.isAgitator() && !token.document.hidden)
     for (let token of agitatorTokens) {
       token.refresh()
-      if (token.document.disposition == 0) {
-        continue
+      let ennemies = []
+      if (token.document.disposition == -1) {
+        ennemies = canvas.tokens.placeables.filter(newToken => newToken.actor.type == "character" && !newToken.document.hidden && (newToken.document.disposition == 1 || newToken.document.disposition == 0 ))
       }
-      let disposition = ( token.document.disposition == -1) ? 1 : -1
-      let ennemies = canvas.tokens.placeables.filter(newToken => newToken.actor.type == "character" && !newToken.document.hidden && newToken.document.disposition == disposition)  
-      let neutrals = canvas.tokens.placeables.filter(newToken => newToken.actor.type == "character" && !newToken.document.hidden && newToken.document.disposition == 0)
-      if (neutrals ) {
-        ennemies = ennemies.concat(neutrals)
+      if (token.document.disposition == 1) {
+        ennemies = canvas.tokens.placeables.filter(newToken => newToken.actor.type == "character" && !newToken.document.hidden && (newToken.document.disposition == -1 || newToken.document.disposition == 0 ))
+      }
+      if (token.document.disposition == 0) {
+        ennemies = canvas.tokens.placeables.filter(newToken => newToken.actor.type == "character" && !newToken.document.hidden && (newToken.document.disposition == -1 || newToken.document.disposition == 1 ))
       }
       for (let ennemy of ennemies) {
         if (ennemy.actor.id != token.actor.id) {
@@ -1257,11 +1250,11 @@ export class PegasusUtility {
         applyDef.actor.removeAgitatorHindrance()
       }
     }
-    // Delete all effects if no more tacticians (ie deleted case)
+    // Delete all effects if no more agtators (ie deleted case)
     if (agitatorTokens.length == 0) {
       let allTokens = canvas.tokens.placeables.filter(token => token.actor.type == "character")
       for (let token of allTokens) {
-        if (token.actor.addAgitatorHindrance()) {
+        if (token.actor.hasAgitatorHindrance()) {
           token.actor.removeAgitatorHindrance()
         }
       }

modules/pegasus-vehicle-sheet.js

@@ -51,8 +51,8 @@ export class PegasusVehicleSheet extends ActorSheet {
       vehicleHull: duplicate(this.actor.getVehicleHull()),
       mobilityModules: duplicate(this.actor.getMobilityModules()),
       propulsionModules: duplicate(this.actor.getPropulsionModules()),
-      vehicleModules: duplicate(this.actor.getVehicleModules()),
-      vehicleWeaponModules: duplicate(this.actor.getVehicleWeaponModules()),
+      vehicleModules: this.actor.checkAndPrepareEquipments(duplicate(this.actor.getVehicleModules())),
+      vehicleWeaponModules: this.actor.checkAndPrepareEquipments(duplicate(this.actor.getVehicleWeaponModules())),
       cargos: this.actor.checkAndPrepareEquipments(duplicate(this.actor.getCargos()) ),
       cargoCurrent: this.actor.getCurrentCargoCapacity(),
       moneys: duplicate(this.actor.getMoneys()),
@@ -134,19 +134,7 @@ export class PegasusVehicleSheet extends ActorSheet {
       let itemId = li.data("item-id")
       this.actor.activateVehicleModule( itemId)
     });      
-    
-    html.find('.equip-activate').click(ev => {
-      const li = $(ev.currentTarget).parents(".item")
-      let itemId = li.data("item-id")
-      this.actor.equipActivate( itemId)
-    });      
-    html.find('.equip-deactivate').click(ev => {
-      const li = $(ev.currentTarget).parents(".item")
-      let itemId = li.data("item-id")
-      this.actor.equipDeactivate( itemId)
-    });      
-
-    html.find('.effect-used').click(ev => {
+        html.find('.effect-used').click(ev => {
       const li = $(ev.currentTarget).parents(".item");
       let itemId = li.data("item-id");
       this.actor.perkEffectUsed( itemId)

system.json

@@ -23,7 +23,7 @@
   "manifest": "https://www.uberwald.me/gitea/uberwald/fvtt-pegasus-rpg/raw/branch/master/system.json",
   "compatibility": {
     "minimum": "10",
-    "verified": "10.285",
+    "verified": "10.286",
     "maximum": "10"
   },
   "id": "fvtt-pegasus-rpg",
@@ -253,7 +253,7 @@
   ],
   "title": "Pegasus RPG",
   "url": "https://www.uberwald.me/data/files/fvtt-pegasus-rpg",
-  "version": "10.0.32",
-  "download": "https://www.uberwald.me/gitea/uberwald/fvtt-pegasus-rpg/archive/fvtt-pegasus-rpg-v10.0.32.zip",
+  "version": "10.1.9",
+  "download": "https://www.uberwald.me/gitea/uberwald/fvtt-pegasus-rpg/archive/fvtt-pegasus-rpg-v10.1.9.zip",
   "background": "systems/fvtt-pegasus-rpg/images/ui/pegasus_welcome_page.webp"
 }

template.json

@@ -37,6 +37,7 @@
           "rolename": "",
           "morality": 5,
           "bonusselection": "",
+          "noautobonus": false,
           "moralitythreshold": 0
         }
       },
@@ -309,6 +310,8 @@
             "topspeed": "",
             "shieldlevel": 0,
             "armourlevel": 0,
+            "maxshieldlevel": 0,
+            "maxarmourlevel": 0,
             "is3D": false
           },
           "reararc": {
@@ -316,13 +319,17 @@
             "topspeed": "",
             "shieldlevel": 0,
             "armourlevel": 0,
-            "is3D": false
+            "maxshieldlevel": 0,
+            "maxarmourlevel": 0,
+            "is3D": false            
           },
           "rightarc": {
             "label": "Right Arc",
             "topspeed": "",
             "shieldlevel": 0,
             "armourlevel": 0,
+            "maxshieldlevel": 0,
+            "maxarmourlevel": 0,
             "is3D": false
           },
           "leftarc": {
@@ -330,6 +337,8 @@
             "topspeed": "",
             "shieldlevel": 0,
             "armourlevel": 0,
+            "maxshieldlevel": 0,
+            "maxarmourlevel": 0,
             "is3D": false
           },
           "toparc": {
@@ -337,6 +346,8 @@
             "topspeed": "",
             "shieldlevel": 0,
             "armourlevel": 0,
+            "maxshieldlevel": 0,
+            "maxarmourlevel": 0,
             "is3D": true
           },
           "bottomarc": {
@@ -344,6 +355,8 @@
             "topspeed": "",
             "shieldlevel": 0,
             "armourlevel": 0,
+            "maxshieldlevel": 0,
+            "maxarmourlevel": 0,
             "is3D": true
           }
         }
@@ -416,6 +429,7 @@
       "affectstatus": false,
       "affectedstatus": "",
       "locked": false,
+      "droptext": "",
       "description": ""
     },
     "race": {

templates/actor-sheet.html

@@ -869,6 +869,12 @@
               <label class="generic-label">Hair</label>
               <input type="text" class="" name="system.biodata.hair" value="{{data.biodata.hair}}" data-dtype="String" />
             </li>
+            {{#if isGM}}
+              <li class="item flexrow">
+                <label class="generic-label">Manual bonuses only ?</label>
+                <input type="checkbox" class="change-worstfear" name="system.biodata.noautobonus" {{checked data.biodata.noautobonus}} />
+              </li>
+            {{/if}}
           </ul>
         </div>
        <div>

templates/item-effect-sheet.html

@@ -34,6 +34,27 @@
               </select> 
             </li>            
 
+            <li class="flexrow"><label class="generic-label">Effect Level is a Stat?</label>
+              <label class="attribute-value checkbox"><input type="checkbox" name="system.effectstatlevel" {{checked data.effectstatlevel}}/></label>
+            </li>
+            {{#if data.effectstatlevel}}
+              <li class="flexrow"><label class="generic-label">Stat to use for Effect Level</label>
+                <select class="competence-base flexrow" type="text" name="system.effectstat" value="{{data.effectstat}}" data-dtype="String">
+                  {{#select data.effectstat}}
+                  {{> systems/fvtt-pegasus-rpg/templates/partial-options-statistics.html notapplicable=false mr=true all=false}}
+                  {{/select}}
+                </select> 
+              </li>
+            {{else}}
+              <li class="flexrow"><label class="generic-label">Effect Level</label>
+                <input type="text" class="input-numeric-short padd-right" name="system.effectlevel" value="{{data.effectlevel}}" data-dtype="Number"/>
+              </li>
+              <li class="flexrow"><label class="generic-label">Affect size ?</label>
+                <label class="attribute-value checkbox"><input type="checkbox" name="system.affectsize" {{checked data.affectsize}}/></label>
+              </li>              
+            {{/if}}
+
+            
             <li class="flexrow"><label class="generic-label">One use?</label>
               <label class="attribute-value checkbox"><input type="checkbox" name="system.oneuse" {{checked data.oneuse}}/></label>
             </li>
@@ -64,27 +85,10 @@
             <li class="flexrow"><label class="generic-label">Locked (Only GM can change/edit) ?</label>
               <label class="attribute-value checkbox"><input type="checkbox" name="system.locked" {{checked data.locked}}/></label>
             </li>
-
-            <li class="flexrow"><label class="generic-label">Effect Level is a Stat?</label>
-              <label class="attribute-value checkbox"><input type="checkbox" name="system.effectstatlevel" {{checked data.effectstatlevel}}/></label>
+            <li class="flexrow"><label class="generic-label">Display Text when added to Actor</label>
+              <input type="text" class="input-numeric-short padd-right" name="system.droptext" value="{{data.droptext}}" data-dtype="String"/>
             </li>
-            {{#if data.effectstatlevel}}
-              <li class="flexrow"><label class="generic-label">Stat to use for Effect Level</label>
-                <select class="competence-base flexrow" type="text" name="system.effectstat" value="{{data.effectstat}}" data-dtype="String">
-                  {{#select data.effectstat}}
-                  {{> systems/fvtt-pegasus-rpg/templates/partial-options-statistics.html notapplicable=false mr=true all=false}}
-                  {{/select}}
-                </select> 
-              </li>
-            {{else}}
-              <li class="flexrow"><label class="generic-label">Effect Level</label>
-                <input type="text" class="input-numeric-short padd-right" name="system.effectlevel" value="{{data.effectlevel}}" data-dtype="Number"/>
-              </li>
-              <li class="flexrow"><label class="generic-label">Affect size ?</label>
-                <label class="attribute-value checkbox"><input type="checkbox" name="system.affectsize" {{checked data.affectsize}}/></label>
-              </li>              
-            {{/if}}
-
+            
             <li class="flexrow"><label class="generic-label">Affect Status?</label>
               <label class="attribute-value checkbox"><input type="checkbox" name="system.affectstatus" {{checked data.affectstatus}}/></label>
             </li>

templates/item-vehicleweaponmodule-sheet.html

@@ -105,8 +105,8 @@
 
 
           <li class="flexrow"><label class="generic-label">Turret</label>
-            <select class="competence-base flexrow" type="text" name="system.turret" value="{{data.turret}}" data-dtype="Number">
-              {{#select data.turret}} F Front, F Left, F Right, F Rear, F Up, F Down, T 180 Front, T 180 Left, T 180 Rear, T 180 Right, T 360
+            <select class="competence-base flexrow" type="text" name="system.turret" value="{{data.turret}}" data-dtype="String">
+              {{#select data.turret}} 
               <option value="ffront">F Front</option>
               <option value="fleft">F Left</option>
               <option value="fright">F Right</option>

templates/partial-actor-status.html

@@ -18,7 +18,7 @@
         </label>
       </span>
       <input type="text" class="padd-right status-small-label no-grow" name="system.secondary.{{key}}.value" value="{{stat2.value}}" data-dtype="Number"/>
-      <input type="text" class="padd-right status-small-label no-grow" name="system.secondary.{{key}}.bonus" value="{{stat2.bonus}}" data-dtype="Number" disabled/>
+      <input type="text" class="padd-right status-small-label no-grow" name="system.secondary.{{key}}.bonus" value="{{stat2.bonus}}" data-dtype="Number" {{@root.disabledBonus}}/>
       <input type="text" class="padd-right status-small-label no-grow" name="system.secondary.{{key}}.max" value="{{stat2.max}}" data-dtype="Number"/>
     </li>
   {{/each}}
@@ -27,7 +27,7 @@
       <label class="status-small-label"><strong>{{data.nrg.label}}</strong></label>               
     </span>
     <input type="text" class="padd-right status-small-label no-grow" name="system.nrg.value" value="{{data.nrg.value}}" data-dtype="Number"/>
-    <input type="text" class="padd-right status-small-label no-grow" name="system.nrg.mod" value="{{data.nrg.mod}}" data-dtype="Number" disabled/>
+    <input type="text" class="padd-right status-small-label no-grow" name="system.nrg.mod" value="{{data.nrg.mod}}" data-dtype="Number" {{@root.disabledBonus}}/>
     <input type="text" class="padd-right status-small-label no-grow" name="system.nrg.max" value="{{data.nrg.max}}" data-dtype="Number"/>
     <span class="small-label status-small-label">&nbsp;/ {{data.nrg.absolutemax}}</span>
   </li>

templates/partial-vehicle-arc.html

@@ -9,9 +9,15 @@
     <span class="item-field-label-long">
       <label class="short-label">Shield</label>
     </span>
+    <span class="item-field-label-short">
+      <label class="short-label">Max</label>
+    </span>
     <span class="item-field-label-long">
       <label class="short-label">Armour</label>
     </span>
+    <span class="item-field-label-short">
+      <label class="short-label">Max</label>
+    </span>
   </li>
   <li class="item flexrow list-item list-item-shadow" data-arc-name="{{idx}}">
 
@@ -31,16 +37,18 @@
         {{#select arc.shieldlevel}}
         {{{@root.optionsDiceList}}}
         {{/select}}
-        </select>
+      </select>
     </span>
+    <span class="item-field-label-short"><label class="short-label">{{getDice arc.maxshieldlevel}}</label></span>
 
     <span class="item-field-label-long">
       <select type="text" name="system.arcs.{{idx}}.armourlevel" value="{{arc.armourlevel}}" data-dtype="Number">
         {{#select arc.armourlevel}}
         {{{@root.optionsDiceList}}}
         {{/select}}
-        </select>
+      </select>
     </span>
+    <span class="item-field-label-short"><label class="short-label">{{getDice arc.maxarmourlevel}}</label></span>
 
   </li>
 </ul>

templates/partial-vehicle-stat-block.html

@@ -14,7 +14,7 @@
       </span>
       <select class="status-small-label color-class-common" type="text" name="system.statistics.{{key}}.level"
         value="{{stat.level}}" data-dtype="Number" disabled>
-        {{#select stat.level}}
+        {{#select (add stat.level stat.bonuseffect)}}
           {{#if (eq key "ad")}}
             {{{@root.optionsLevel}}}
           {{else}}

templates/vehicle-sheet.html

@@ -456,10 +456,10 @@
           <span class="item-name-label-header-long">
             <h3><label class="items-title-text">Vehicles modules</label></h3>
           </span>
-          <span class="item-field-label-long">
+          <span class="item-field-label-medium">
             <label class="short-label">Category</label>
           </span>
-          <span class="item-field-label-long">
+          <span class="item-field-label-medium">
             <label class="short-label">Location</label>
           </span>
           <span class="item-field-label-long">
@@ -480,12 +480,20 @@
           <a class="item-edit item-name-img" title="Edit Item"><img class="sheet-competence-img"
               src="{{vehiclemod.img}}" /></a>
           <span class="item-name-label-long"><a class="roll-spec">{{vehiclemod.name}}</a></span>
-          <span class="item-field-label-long">{{vehiclemod.system.category}}</span>
-          <span class="item-field-label-long">{{vehiclemod.system.location}}</span>
+          <span class="item-field-label-medium">{{vehiclemod.system.category}}</span>
+          <span class="item-field-label-medium">{{vehiclemod.system.location}}</span>
           <span class="item-field-label-long">{{vehiclemod.system.security}}</span>
           <span class="item-field-label-short">{{vehiclemod.system.nrg}}</span>
           <span class="item-field-label-medium">{{vehiclemod.system.range}}</span>
-          <span class="item-field-label-short">{{vehiclemod.system.idr}}</span>
+
+          <span class="item-field-label-short">
+              {{#if vehiclemod.system.idrDice}}
+            <a class="roll-idr" data-dice-value="{{vehiclemod.system.idrDice}}">{{vehiclemod.system.idrDice}}</a>
+            {{else}}
+            &nbsp;-&nbsp;
+            {{/if}}
+          </span>
+
           <div class="item-filler">&nbsp;</div>
           <div class="item-controls item-controls-fixed">
             <a class="item-control vehicle-module-activate" title="Activated">{{#if vehiclemod.system.activated}}<i
@@ -501,10 +509,10 @@
           <span class="item-name-label-header-long">
             <h3><label class="items-title-text">Vehicles weapons</label></h3>
           </span>
-          <span class="item-field-label-long">
+          <span class="item-field-label-medium">
             <label class="short-label">Site</label>
           </span>
-          <span class="item-field-label-long">
+          <span class="item-field-label-medium">
             <label class="short-label">Location</label>
           </span>
           <span class="item-field-label-short">
@@ -528,13 +536,21 @@
           <a class="item-edit item-name-img" title="Edit Item"><img class="sheet-competence-img"
               src="{{weapon.img}}" /></a>
           <span class="item-name-label-long"><a class="roll-spec">{{weapon.name}}</a></span>
-          <span class="item-field-label-long">{{weapon.system.site}}</span>
-          <span class="item-field-label-long">{{weapon.system.location}}</span>
+          <span class="item-field-label-medium">{{weapon.system.site}}</span>
+          <span class="item-field-label-medium">{{weapon.system.location}}</span>
           <span class="item-field-label-short">{{weapon.system.dmg}}</span>
           <span class="item-field-label-medium">{{weapon.system.aoe}}</span>
-          <span class="item-field-label-medium">{{weapon.system.turrent}}</span>
+          <span class="item-field-label-medium">{{weapon.system.turret}}</span>
           <span class="item-field-label-short">{{weapon.system.nrg}}</span>
-          <span class="item-field-label-short">{{weapon.system.idr}}</span>
+
+          <span class="item-field-label-short">
+            {{#if weapon.system.idrDice}}
+            <a class="roll-idr" data-dice-value="{{weapon.system.idrDice}}">{{weapon.system.idrDice}}</a>
+            {{else}}
+            &nbsp;-&nbsp;
+            {{/if}}
+          </span>
+
           <div class="item-filler">&nbsp;</div>
           <div class="item-controls item-controls-fixed">
             <a class="item-control vehicle-weapon-activate" title="Activated">{{#if weapon.system.activated}}<i