uberwald/fvtt-pegasus-rpg
1
0
Fork 0
Code Issues Pull Requests Projects Releases 44 Wiki Activity

FIX: Vehcile Stat Dice do not open when targetting a character actor token #103

New Issue
Closed
opened 2022-10-06 11:55:25 +02:00 by GMDOnline · 4 comments
GMDOnline commented 2022-10-06 11:55:25 +02:00
Collaborator
Copy Link
No description provided.
uberwald commented 2022-10-06 12:27:46 +02:00
Owner
Copy Link

It works on my side.
Again provide snapshot and full console log content (F12)

It works on my side. Again provide snapshot and full console log content (F12)
GMDOnline commented 2022-10-06 12:35:01 +02:00
Author
Collaborator
Copy Link
Uncaught TypeError: Cannot read properties of undefined (reading 'sizenum')
    at PegasusActor.processSizeBonus (pegasus-actor.js:1915:66)
    at PegasusActor.getCommonRollData (pegasus-actor.js:1902:10)
    at PegasusActor.rollStat (pegasus-actor.js:2014:27)
    at HTMLAnchorElement.<anonymous> (pegasus-vehicle-sheet.js:237:18)
    at HTMLAnchorElement.dispatch (jquery.min.js:2:43064)
    at y.handle (jquery.min.js:2:41048)
``` Uncaught TypeError: Cannot read properties of undefined (reading 'sizenum') at PegasusActor.processSizeBonus (pegasus-actor.js:1915:66) at PegasusActor.getCommonRollData (pegasus-actor.js:1902:10) at PegasusActor.rollStat (pegasus-actor.js:2014:27) at HTMLAnchorElement.<anonymous> (pegasus-vehicle-sheet.js:237:18) at HTMLAnchorElement.dispatch (jquery.min.js:2:43064) at y.handle (jquery.min.js:2:41048) ```
Vehicle Targetting an actor token.jpg
177 KiB
Vehicle Targetting an actor token.jpg
uberwald commented 2022-10-06 12:41:55 +02:00
Owner
Copy Link

The size value of the character is not set

The size value of the character is not set
uberwald referenced this issue from a commit 2022-10-06 12:42:12 +02:00
Fix #103 size warning
uberwald referenced this issue from a commit 2022-10-06 12:47:19 +02:00
Fix #103 size warning
uberwald referenced this issue from a commit 2022-10-06 12:49:00 +02:00
Fix #103 size warning
GMDOnline commented 2022-10-06 13:03:40 +02:00
Author
Collaborator
Copy Link

I have created a fresh vehcile and it still does not work

Target tokens Size = 0
Vehcile Size = 7

We had this issue before when the actor targettign a vehicle could not open the dice pool.

Now when a vehcile targets an actor the vehicles cannot open any of its top stats dic epool

This was the disord convo:

**LeRatierBretonnien — **Yes, but I need to compuute it anyway
Right now, there are no fields in the vehicle to input the size
**GMDOnline — **Yesterday at 8:36 AM
On a vehicle size is determined by the hull and is automatically calculated see HR
When you add a Hull Module it updates the Size under HR Stat
**LeRatierBretonnien — **Yesterday at 8:40 AM
OK, found.

What you did here worked..

This was the old error you fixed:

```

Uncaught TypeError: Cannot read properties of undefined (reading 'sizenum')
at PegasusUtility.updateWithTarget (pegasus-utility.js:1029:67)
at PegasusUtility.getBasicRollData (pegasus-utility.js:1018:22)
at PegasusActor.getCommonRollData (pegasus-actor.js:1800:35)
at PegasusActor.rollStat (pegasus-actor.js:1983:27)
at HTMLAnchorElement. (pegasus-actor-sheet.js:263:18)
at HTMLAnchorElement.dispatch (jquery.min.js:2:43064)
at y.handle (jquery.min.js:2:41048)

### This is the new error:
Uncaught TypeError: Cannot read properties of undefined (reading 'sizenum')
    at PegasusActor.processSizeBonus (pegasus-actor.js:1915:66)
    at PegasusActor.getCommonRollData (pegasus-actor.js:1902:10)
    at PegasusActor.rollStat (pegasus-actor.js:2014:27)
    at HTMLAnchorElement.<anonymous> (pegasus-vehicle-sheet.js:237:18)
    at HTMLAnchorElement.dispatch (jquery.min.js:2:43064)
    at y.handle (jquery.min.js:2:41048)
I have created a fresh vehcile and it still does not work Target tokens Size = 0 Vehcile Size = 7 We had this issue before when the actor targettign a vehicle could not open the dice pool. Now when a vehcile targets an actor the vehicles cannot open any of its top stats dic epool This was the disord convo: **LeRatierBretonnien — **Yes, but I need to compuute it anyway Right now, there are no fields in the vehicle to input the size **GMDOnline — **Yesterday at 8:36 AM On a vehicle size is determined by the hull and is automatically calculated see HR When you add a Hull Module it updates the Size under HR Stat **LeRatierBretonnien — **Yesterday at 8:40 AM OK, found. What you did here worked.. ### This was the old error you fixed: ### ``` Uncaught TypeError: Cannot read properties of undefined (reading 'sizenum') at PegasusUtility.updateWithTarget (pegasus-utility.js:1029:67) at PegasusUtility.getBasicRollData (pegasus-utility.js:1018:22) at PegasusActor.getCommonRollData (pegasus-actor.js:1800:35) at PegasusActor.rollStat (pegasus-actor.js:1983:27) at HTMLAnchorElement.<anonymous> (pegasus-actor-sheet.js:263:18) at HTMLAnchorElement.dispatch (jquery.min.js:2:43064) at y.handle (jquery.min.js:2:41048) ``` ### This is the new error: Uncaught TypeError: Cannot read properties of undefined (reading 'sizenum') at PegasusActor.processSizeBonus (pegasus-actor.js:1915:66) at PegasusActor.getCommonRollData (pegasus-actor.js:1902:10) at PegasusActor.rollStat (pegasus-actor.js:2014:27) at HTMLAnchorElement.<anonymous> (pegasus-vehicle-sheet.js:237:18) at HTMLAnchorElement.dispatch (jquery.min.js:2:43064) at y.handle (jquery.min.js:2:41048)
uberwald referenced this issue from a commit 2022-10-06 13:17:45 +02:00
Fix #103 size warning
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: uberwald/fvtt-pegasus-rpg#103
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?