fix: Correct critical bugs and complete Creature/Group DataModel implementation

- Fix TypeError: controls.find is not a function in hooks.mjs
- Fix undefined 'npc' variable in applications.mjs
- Fix CONFIG.VERMINE.model undefined by checking game.system.template existence
- Fix TypeError: html.find(...).forEach is not a function in roll.mjs
- Fix Cannot set properties of undefined (setting 'initial') in actor.mjs
- Fix Cannot read properties of undefined (reading 'difficulty') in actor.mjs
- Fix ActiveEffect application phase 'initial' already completed by adding combatStatus to base template
- Fix Missing helper: 'select' in roll-dialog.hbs (removed invalid Handlebars select block)
- Add SIZE_LEVELS labels to creatureSizeLevels config
- Add SIZE_LEVELS translations to fr.json
- Add combatStatus to base actor template
- Convert all .html templates to .hbs for Foundry v14 compatibility
- Update item-sheet.mjs to use .hbs extension
- Update handlebars-manager.mjs to use .hbs for all partials

Complete Vermine2047 Creature and Group sheet implementation:
- Creature: Pattern, Size, Role, Pack with computed values
- Group: Totem, Reserve, Morale, Objectives, Members management
- All templates functional with proper styling

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This commit is contained in:
2026-06-04 20:58:22 +02:00
parent f9f07cbc7e
commit 30d6f71fc7
43 changed files with 19225 additions and 609 deletions
+89 -30
View File
@@ -1,8 +1,9 @@
import { onManageActiveEffect, prepareActiveEffectCategories } from "../system/effects.mjs";
import { VermineActorSheet } from "./actor-sheet.mjs";
import { TotemPicker } from "../system/applications.mjs";
/**
* Extend the basic ActorSheet with some very simple modifications
* Extend the basic ActorSheet for NPC type
* @extends {VermineActorSheet}
*/
export class VermineNpcSheet extends VermineActorSheet {
@@ -12,9 +13,11 @@ export class VermineNpcSheet extends VermineActorSheet {
return foundry.utils.mergeObject(super.defaultOptions, {
classes: ["vermine2047", "sheet", "actor", "npc"],
template: "systems/vermine2047/templates/actor/actor-sheet.hbs",
width: 400,
height: 400,
tabs: [{ navSelector: ".sheet-tabs", contentSelector: ".sheet-body", initial: "features" }]
width: 600,
height: 700,
tabs: [
{ navSelector: ".sheet-tabs", contentSelector: ".sheet-body", initial: "characteristics" }
]
});
}
@@ -27,10 +30,7 @@ export class VermineNpcSheet extends VermineActorSheet {
/** @override */
getData() {
// Retrieve the data structure from the base sheet. You can inspect or log
// the context variable to see the structure, but some key properties for
// sheets are the actor object, the data object, whether or not it's
// editable, the items array, and the effects array.
// Retrieve the data structure from the base sheet.
const context = super.getData();
// Use a safe clone of the actor data for further operations.
@@ -41,19 +41,16 @@ export class VermineNpcSheet extends VermineActorSheet {
context.flags = actorData.flags;
context.config = CONFIG.VERMINE;
// Prepare character data and items.
if (actorData.type == 'character') {
this._prepareItems(context);
this._prepareCharacterData(context);
// Prepare items for all actor types
this._prepareItems(context);
// Prepare NPC-specific data
if (actorData.type === 'npc') {
this._prepareNpcData(context);
}
// Prepare NPC data and items.
if (actorData.type == 'npc') {
this._prepareItems(context);
}
// Add roll data for TinyMCE editors.
context.rollData = context.actor.getRollData();
// Add roll data for TinyMCE editors
context.rollData = this.actor.getRollData();
// Prepare active effects
context.effects = prepareActiveEffectCategories(this.actor.effects);
@@ -62,26 +59,75 @@ export class VermineNpcSheet extends VermineActorSheet {
}
/**
* Organize and classify Items for Character sheets.
*
* @param {Object} actorData The actor to prepare.
*
* @return {undefined}
* Prepare NPC specific data
*/
_prepareCharacterData(context) {
_prepareNpcData(context) {
// Calculate derived values from threat, experience, and role
const threat = CONFIG.VERMINE.npcThreatLevels[context.system.threat.value];
const experience = CONFIG.VERMINE.npcExperienceLevels[context.system.experience.value];
const role = CONFIG.VERMINE.npcRoleLevels[context.system.role.value];
// Add calculated values to context for easier access
context.threatData = threat;
context.experienceData = experience;
context.roleData = role;
// Set wound thresholds based on threat level
if (threat) {
context.system.minorWound.threshold = threat.minorWound || context.system.minorWound.threshold;
context.system.majorWound.threshold = threat.majorWound || context.system.majorWound.threshold;
context.system.deadlyWound.threshold = threat.deadlyWound || context.system.deadlyWound.threshold;
// Set max wounds
context.system.minorWound.max = threat.minorWound || context.system.minorWound.max;
context.system.majorWound.max = threat.majorWound || context.system.majorWound.max;
context.system.deadlyWound.max = threat.deadlyWound || context.system.deadlyWound.max;
}
// Set reserve max values based on role
if (role) {
context.system.attributes.effort.max = role.pools || context.system.attributes.effort.max;
context.system.attributes.self_control.max = role.reaction_bonus || context.system.attributes.self_control.max;
}
// Prepare abilities with labels
for (let [k, v] of Object.entries(context.system.abilities)) {
v.label = game.i18n.localize(CONFIG.VERMINE.abilities[k]) ?? k;
}
// Prepare skills with localized names
for (let [k, v] of Object.entries(context.system.skills)) {
const skillKey = `VERMINE.skill.${k}`;
v.name = game.i18n.localize(skillKey);
if (v.name === skillKey) {
// Fallback to key if no translation
v.name = k.charAt(0).toUpperCase() + k.slice(1);
}
}
// Prepare skill categories
for (let [k, v] of Object.entries(context.system.skill_categories)) {
if (k !== 'preferred') {
v.label = game.i18n.localize(v.label) ?? k;
}
}
}
/**
* Organize and classify Items for Character sheets.
* Organize and classify Items for NPC sheets.
*
* @param {Object} actorData The actor to prepare.
*
* @return {undefined}
* @param {Object} context - The context to prepare.
*/
_prepareItems(context) {
context.gear = this.actor.itemTypes['item'];
context.traits = this.actor.itemTypes['trait'];
context.weapons = this.actor.itemTypes['weapon'];
context.defenses = this.actor.itemTypes['defense'];
context.vehicles = this.actor.itemTypes['vehicle'];
context.abilities = this.actor.itemTypes['ability'];
context.specialties = this.actor.itemTypes['specialty'];
context.backgrounds = this.actor.itemTypes['background'];
context.traumas = this.actor.itemTypes['trauma'];
context.evolutions = this.actor.itemTypes['evolution'];
}
/* -------------------------------------------- */
@@ -90,6 +136,19 @@ export class VermineNpcSheet extends VermineActorSheet {
activateListeners(html) {
super.activateListeners(html);
// Choose Totem
html.find('.chooseTotem').click(this._onTotemButton.bind(this));
}
/**
* Handle totem pick
* @param {Event} event - The originating click event
* @private
*/
_onTotemButton(event) {
event.preventDefault();
const el = event.currentTarget;
const totemPicker = new TotemPicker(el, this.actor);
totemPicker.render(true);
}
}