New release with effects fixes

Reviewed-on: #102

compendium/wfrp4e-core.tables.json

@@ -4,7 +4,7 @@
     "Career Tables": "Table des Carrières",
     "Character Creation": "Création de Personnage",
     "Core Rulebook": "Livre de Base",
-    "Corruption & Mutation Tables": "ables de Corruption & Mutations",
+    "Corruption & Mutation Tables": "Tables de Corruption & Mutations",
     "Critical Hit Tables": "Tables de Critiques",
     "GM Booklet": "Livret du MJ",
     "Hit Location": "Table de Localisation",

module.json

@@ -8,7 +8,7 @@
     }
   ],
   "url": "https://www.uberwald.me/gitea/public/foundryvtt-wh4-lang-fr-fr",
-  "version": "7.2.1",
+  "version": "7.2.3",
   "esmodules": [
     "modules/babele-register.js",
     "modules/addon-register.js",
@@ -117,7 +117,7 @@
     }
   ],
   "manifest": "https://www.uberwald.me/gitea/public/foundryvtt-wh4-lang-fr-fr/raw/v10/module.json",
-  "download": "https://www.uberwald.me/gitea/public/foundryvtt-wh4-lang-fr-fr/archive/foundryvtt-wh4-lang-fr-7.2.1.zip",
+  "download": "https://www.uberwald.me/gitea/public/foundryvtt-wh4-lang-fr-fr/archive/foundryvtt-wh4-lang-fr-7.2.3.zip",
   "id": "wh4-fr-translation",
   "compatibility": {
     "minimum": "11",

modules/babele-register.js

@@ -300,7 +300,7 @@ Hooks.once('init', () => {
           }
         }
         if (results[0].documentCollection) {
-          return game.babele.instance.converters.tableResults(results)
+          return game.babele.converters.tableResults(results)
         }
         return results
       },

scripts/BHbFqhJPzZI2txLs.js

@@ -1,8 +1,9 @@
 let lore = this.effect.name.split("(")[1].split(")")[0].toLowerCase();
+let spellLore = game.wfrp4e.config.magicLores[args.spell.system.lore.value].toLowerCase();
 
 // If channelling corresponding lore
-if (args.type == "channelling" && args.spell.system.lore.value == lore)
+if (args.type == "channelling" && spellLore == lore)
     args.prefillModifiers.slBonus  += 2
 // If channelling or casting different lore
-else if (args.spell.system.lore.value != lore && args.spell.system.lore.value != "petty")
+else if (spellLore != lore && args.spell.system.lore.value != "petty")
     args.prefillModifiers.slBonus  -= 1

scripts/PeZYj8b0vedyJj00.js

@@ -1,12 +1,12 @@
 // This script needs to be separate because equipTransfer is off on the other effect, and thus won't execute when added to an actor
 
 let mainEffect = this.item.effects.contents[0];
-if (mainEffect.name.includes("(Savoir)"))
+if (mainEffect.name.includes("(Lore)"))
 {
     let choice = await ItemDialog.create(ItemDialog.objectToArray(game.wfrp4e.config.magicLores, this.item.img), 1, "Choisissez le Savoir");
     if (choice.length)
     {
-        mainEffect.update({name : mainEffect.name.replace("Savoir", choice[0].name)})
+        mainEffect.update({name : mainEffect.name.replace("Lore", choice[0].name)})
         this.item.update({name : this.item.name += ` (${choice[0].name})`})
     }
 }

scripts/R6SnyF3y4Vsq6oga.js

@@ -1,8 +1,9 @@
 let lore = this.effect.name.split("(")[1].split(")")[0].toLowerCase();
+let spellLore = game.wfrp4e.config.magicLores[args.spell.system.lore.value].toLowerCase();
 
 // If channelling corresponding lore
-if (args.type == "channelling" && args.spell.system.lore.value == lore)
+if (args.type == "channelling" && spellLore == lore)
     args.prefillModifiers.slBonus  += 1
 // If channelling or casting different lore
-else if (args.spell.system.lore.value != lore && args.spell.system.lore.value != "petty")
+else if (spellLore != lore && args.spell.system.lore.value != "petty")
     args.prefillModifiers.slBonus  -= 1

scripts/TGN070HeJLl3gSMY.js

@@ -1,4 +1,4 @@
-let test = await this.actor.setupCharacteristic("ag", {skipTargets: true, appendTitle :  ` - ${this.effect.name}`, context: { failure: "Goes Prone" }})
+let test = await this.actor.setupCharacteristic("ag", {skipTargets: true, appendTitle :  ` - ${this.effect.name}`, context: { failure: "A Terre" }})
 await test.roll();
 if (test.failed)
 {

scripts/UsuwsmU1TUQLQVM2.js

@@ -1,2 +1,3 @@
 let lore = this.effect.name.split("(")[1].split(")")[0].toLowerCase();
-return !args.spell || (args.type == "cast" && ["petty", lore].includes(args.spell.system.lore.value));
+let spellLore = game.wfrp4e.config.magicLores[args.spell.system.lore.value].toLowerCase();
+return !args.spell || (args.type == "cast" && [game.wfrp4e.config.magicLores["petty"].toLowerCase(), lore].includes(spellLore));

scripts/Wo4wQKUxSItAhRzZ.js

@@ -1,8 +1,9 @@
 let lore = this.effect.name.split("(")[1].split(")")[0].toLowerCase();
+let spellLore = game.wfrp4e.config.magicLores[args.spell.system.lore.value].toLowerCase();
 
 // If channelling corresponding lore
-if (args.type == "channelling" && args.spell.system.lore.value == lore)
+if (args.type == "channelling" && spellLore == lore)
     args.prefillModifiers.slBonus  += 3
 // If channelling or casting different lore
-else if (args.spell.system.lore.value != lore && args.spell.system.lore.value != "petty")
+else if (spellLore != lore && args.spell.system.lore.value != "petty")
     args.prefillModifiers.slBonus  -= 1

scripts/dfnCK8jCPXNLM7Gh.js

@@ -2,7 +2,7 @@ let aoeDamage = this.effect.sourceTest.result.damage - 5 // Easily handle magic
 
 this.script.scriptMessage(await this.actor.applyBasicDamage(aoeDamage, {damageType : game.wfrp4e.config.DAMAGE_TYPE.IGNORE_AP, suppressMsg : true}))
 
-let test = await this.actor.setupSkill(game.i18n.localize("NAME.Dodge"), {skipTargets: true, appendTitle :  ` - Ablaze`})
+let test = await this.actor.setupSkill(game.i18n.localize("NAME.Dodge"), {skipTargets: true, appendTitle :  ` - En Flammes`})
 
 await test.roll();
 

scripts/s6eZXfZkC1My6EXl.js

@@ -1,5 +1,5 @@
 let lore = this.effect.name.split(" ")[2].toLowerCase();
-if (args.item.type == "spell" && args.item.system.lore.value == lore)
+if (args.item.type == "spell" && game.wfrp4e.config.magicLores[args.item.system.lore.value].toLowerCase() == lore)
 {
     args.item.system.cn.value -= 1
-}
+}

scripts/sB4KB9bT3nQhAoqG.js

@@ -1,12 +1,12 @@
 // This script needs to be separate because equipTransfer is off on the other effect, and thus won't execute when added to an actor
 
 let mainEffect = this.item.effects.contents[0];
-if (mainEffect.name.includes("<Savoir>"))
+if (mainEffect.name.includes("<Lore>"))
 {
     let choice = await ItemDialog.create(ItemDialog.objectToArray(game.wfrp4e.config.magicLores, this.item.img), 1, "Choisissez le Savoir");
     if (choice.length)
     {
-        mainEffect.update({name : mainEffect.name.replace("<Savoir>", choice[0].name)})
+        mainEffect.update({name : mainEffect.name.replace("<Lore>", choice[0].name)})
         this.item.update({name : this.item.name += ` (${choice[0].name})`})
     }
 }

tools/detect_identical_files.lua

@@ -0,0 +1,24 @@
+local lfs = require"lfs"
+
+local src = "../reference_scripts/"
+local dst = "../scripts/"
+
+for file in lfs.dir(src) do
+  if file == '.' or file == '..'  then 
+  else 
+    local fp1 = io.open(dst..file, "r+")
+    local fp2 = io.open(src..file, "r+")
+    if fp1 and fp2 then
+      -- Compare files 
+      local content1 = fp1:read("*all")
+      local content2 = fp2:read("*all")
+      if content1 == content2 then
+        print("Identical files: "..file)
+      end
+      fp1:close()
+      fp2:close()
+    else
+      print("Error: Could not open file: "..file)
+    end
+  end
+end