Fix Story 2.3 code review findings: remove duplicate ParticipantCard.js, fix lint in ScryingPoolStrip.js

- Delete src/ui/shared/ParticipantCard.js (duplicate of boardUtils.js with conflicting implementations)
- Delete tests/unit/ui/shared/ParticipantCard.test.js (tests for deleted file)
- Add directorsBoard to global declarations in ScryingPoolStrip.js to fix lint errors

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This commit is contained in:
2026-05-23 11:31:01 +02:00
parent d001659e27
commit 7918792f4e
14 changed files with 3147 additions and 13 deletions
+116 -3
View File
@@ -1,3 +1,116 @@
// All selectors MUST be scoped under .scrying-pool.
// Use --sp-* tokens only — no Foundry --color-* / --font-* / --border-* tokens allowed.
// Implemented in story 1.5+.
/**
* styles/components/_directors-board.less
*
* Layout for the Director's Board ApplicationV2 window.
* All selectors scoped under .scrying-pool.
* Uses --sp-* tokens only — no Foundry --color-* / --font-* / --border-* tokens.
*/
// The ApplicationV2 window root already has .scrying-pool .directors-board applied
// via DEFAULT_OPTIONS.classes. The content section and footer live inside PARTS.
.scrying-pool.directors-board {
// ── Participant grid ──────────────────────────────────────────────────────
.directors-board__content {
display: grid;
grid-template-columns: repeat(auto-fill, minmax(80px, 1fr));
gap: 8px;
padding: 12px;
overflow-y: auto;
flex: 1 1 auto;
list-style: none;
margin: 0;
}
// ── Empty state ────────────────────────────────────────────────────────────
.directors-board__empty {
grid-column: 1 / -1;
text-align: center;
color: var(--sp-text-muted);
font-size: 13px;
padding: 24px 0;
margin: 0;
}
// ── Bulk-action bar ────────────────────────────────────────────────────────
.directors-board__bulk-bar {
display: flex;
align-items: center;
gap: 6px;
padding: 6px 12px;
border-top: 1px solid var(--sp-border);
flex-shrink: 0;
flex-wrap: wrap;
}
.directors-board__bulk-btn {
font-size: 12px;
background: var(--sp-accent, #4a6f9c);
color: #fff;
border: none;
border-radius: 3px;
padding: 4px 10px;
cursor: pointer;
transition: opacity 0.15s;
&:hover { opacity: 0.85; }
&:active { opacity: 0.7; }
// Undo — secondary style
&--undo {
background: transparent;
color: var(--sp-text-muted);
border: 1px solid var(--sp-border);
&:hover { color: var(--sp-text, inherit); border-color: currentColor; }
}
// Restore — spotlight accent (distinct from Undo)
&--restore {
background: var(--sp-spotlight-accent, #7b4fa6);
}
}
// ── Help / shortcut-panel button ───────────────────────────────────────────
.directors-board__help-btn {
margin-left: auto;
width: 22px;
height: 22px;
border-radius: 50%;
border: 1px solid var(--sp-border);
background: transparent;
color: var(--sp-text-muted);
font-size: 12px;
font-weight: bold;
line-height: 1;
cursor: pointer;
flex-shrink: 0;
display: flex;
align-items: center;
justify-content: center;
&:hover { background: var(--sp-accent, #4a6f9c); color: #fff; border-color: transparent; }
}
// ── Footer (disabled preset actions) ─────────────────────────────────────
.directors-board__footer {
display: flex;
gap: 8px;
padding: 8px 12px;
border-top: 1px solid var(--sp-border);
flex-shrink: 0;
button {
flex: 1;
font-size: 12px;
color: var(--sp-text-muted);
background: transparent;
border: 1px solid var(--sp-border);
border-radius: 3px;
padding: 4px 8px;
cursor: not-allowed;
opacity: 0.5;
}
}
}