Update package.json

Fix NPCs

See merge request wintermyst/kidsonbrooms!7

.gitlab-ci.yml

@@ -11,7 +11,7 @@ variables:
   PACKAGE_REGISTRY_URL: "${CI_API_V4_URL}/projects/${CI_PROJECT_ID}/packages/generic/${CI_PROJECT_NAME}/${CI_COMMIT_TAG}"
   MANIFEST_RELEASE_URL: "${PACKAGE_REGISTRY_URL}/${MANIFEST}"
   ZIPFILE_RELEASE_URL: "${PACKAGE_REGISTRY_URL}/${ZIPFILE}"
-  MANIFEST_PERMALINK_URL: "https://gitlab.com/${CI_PROJECT_NAMESPACE}/${CI_PROJECT_NAME}/-/releases/permalink/latest/downloads/${MANIFEST}"
+  MANIFEST_PERMALINK_URL: "https://gitlab.com/${CI_PROJECT_NAMESPACE}/${CI_PROJECT_NAME}/-/releases/${CI_COMMIT_TAG}/downloads/${MANIFEST}"
   ZIPFILE_PERMALINK_URL: "https://gitlab.com/${CI_PROJECT_NAMESPACE}/${CI_PROJECT_NAME}/-/releases/${CI_COMMIT_TAG}/downloads/${ZIPFILE}"
   dry_run: true
 
@@ -79,6 +79,6 @@ create-release:
           url: "${MANIFEST_RELEASE_URL}"
           filepath: "/${MANIFEST}"
         - name: "$ZIPFILE"
-          url: "${ZIPFILE_PERMALINK_URL}"
+          url: "${ZIPFILE_RELEASE_URL}"
           filepath: "/${ZIPFILE}"
 

gulpfile.js

@@ -268,8 +268,8 @@ async function publishToFoundry(done) {
   const compMin = moduleManifest.compatibility.minimum;
   const compVer = moduleManifest.compatibility.verified;
   const compMax = moduleManifest.compatibility.maximum;
-  const manifest = process.env.MANIFEST_RELEASE_URL || `https://gitlab.com/${process.env.CI_PROJECT_NAMESPACE}/${process.env.CI_PROJECT_NAME}/-/releases/${process.env.CI_COMMIT_TAG}/downloads/${moduleManifestPath}`;
-  const notes = `https://gitlab.com/${process.env.CI_PROJECT_NAMESPACE}/${process.env.CI_PROJECT_NAME}/-/tags/${process.env.CI_COMMIT_TAG}`;
+  const manifest = process.env.MANIFEST_PERMALINK_URL || `https://gitlab.com/${process.env.CI_PROJECT_NAMESPACE}/${process.env.CI_PROJECT_NAME}/-/releases/${process.env.CI_COMMIT_TAG}/downloads/${moduleManifestPath}`;
+  const notes = `https://gitlab.com/${process.env.CI_PROJECT_NAMESPACE}/${process.env.CI_PROJECT_NAME}/-/releases/${process.env.CI_COMMIT_TAG}`;
 
   const dryRun = process.env.dry_run === 'true';
   const authToken = process.env.FOUNDRY_API_KEY;
@@ -328,7 +328,7 @@ async function publishToFoundry(done) {
 function updateSystemJson(done) {
   const ManifestPath = 'system.json';
   const Manifest = JSON.parse(fs.readFileSync(ManifestPath));
-  const zipUrl = process.env.ZIPFILE_PERMALINK_URL || 'https://gitlab.com/wintermyst/kidsonbrooms/-/raw/master/kidsonbrooms.zip?inline=false';
+  const zipUrl = process.env.ZIPFILE_RELEASE_URL || 'https://gitlab.com/wintermyst/kidsonbrooms/-/raw/master/kidsonbrooms.zip?inline=false';
 
   Manifest.download = zipUrl;
 

module/documents/actor.mjs

@@ -7,7 +7,7 @@ export class KidsOnBroomsActor extends Actor {
   /**
    * Override getRollData() that's supplied to rolls.
    */
-  getRollData() {
+  getRollDataPC() {
     let data = { ...this.system };
   
     // Wand bonuses
@@ -18,6 +18,12 @@ export class KidsOnBroomsActor extends Actor {
   
     return data;
   }
+
+  getRollDataNPC() {
+    let data = { ...this.system};
+
+    return data;
+  }
   
   _getWandBonus(type) {
     const bonuses = {

module/sheets/actor-sheet.mjs

@@ -40,8 +40,6 @@ async getData()
 
   // Add roll data for TinyMCE editors.
   context.rollData = context.actor.getRollData();
-  // Add roll data for TinyMCE editors.
-  context.rollData = context.actor.getRollData();
 
 
   console.log(context);
@@ -87,7 +85,16 @@ async getData()
       if (dataset.roll) {
       let label = dataset.label ? `${dataset.label}` : '';
       // Get the roll data and include wand bonuses
-      let rollData = this.actor.getRollData();
+
+      let rollData;
+      if(this.actor.type == "character") {
+        rollData = this.actor.getRollDataPC();
+      } else if (this.actor.type == "npc") {
+        rollData = this.actor.getRollDataNPC();
+      } else {
+        console.log("ERROR: UNKNOWN AUTHOR TYPE");
+        return;
+      }
       let totalBonus = 0;
       console.log(dataset.roll);
       // Apply wood bonus if it matches the stat being rolled for

package.json

@@ -1,6 +1,6 @@
 {
   "name": "kidsonbrooms",
-  "version": "1.1.3",
+  "version": "1.1.5",
   "description": "CSS compiler for the Kids On Brooms system",
   "scripts": {
     "build": "gulp build",

system.json

@@ -2,7 +2,7 @@
   "id": "kidsonbrooms",
   "title": "Kids on Brooms System",
   "description": "The Kids on Brooms system for FoundryVTT!",
-  "version": "1.1.3",
+  "version": "1.1.5",
   "compatibility": {
     "minimum": 12,
     "verified": 12.331

templates/actor/parts/actor-stats.html

@@ -25,7 +25,7 @@
         <!-- Magic rolling and input -->
         <Fieldset class="flexrow flex-group-center">
           <legend>Magic</legend>
-          <span class="ability-mod rollable" data-roll="1{{stat.value}}x+1d4+{{stat.stat}}" data-label="Magic Roll for {{key}}" data-key="{{key}}">
+          <span class="ability-mod rollable" data-roll="1{{stat.value}}x+1d4x+{{stat.stat}}" data-label="Magic Roll for {{key}}" data-key="{{key}}">
             <i class="fas fa-dice-d20"></i>
           </span>
         </Fieldset>