Formatage changelog

Reviewed-on: #753

changelog.md

@@ -1,13 +1,35 @@
 # 12.0
+
+## 12.0.44 - Les errements d'Astrobazzarh, suite
+
+- on peut de nouveau dormir et se réveiller reposé
+- les possessions utilisent maintenant correctement le rêve actuel
+- les sorts variables ne causent plus de soucis de voie pour le lancement de sorts
+- les acteurs ayant un sort avec un coût de rêve entier ne sont plus considérés
+  comme pouvant avoir un rêve variable
+
+## 12.0.42 - Les errements d'Astrobazzarh
+
+- Correction de différentes automatisations de combat incorrectes
+- Correction des jets `@roll[vue/-2]` qui tentaient de chercher une compétence -2 (à cause des armes à 1/2 mains)
+
+## 12.0.41 - La loupe d'Astrobazzarh
+
+- On peut de nouveau effectuer des tirages cachés
+- Le stress transformé est bien diminué lorsqu'on met le stress dans une compétence
+
 ## 12.0.40 - Les mains d'Astrobazzarh
+
 - correction des attaques particulières en combat
 - correction de message sur les min/max liés aux modificateurs de races (s'applique uniquement sur la taille)
 
 ## 12.0.39 - Les mains d'Astrobazzarh
+
 - les armes à 1 ou 2 mains fonctionnent dans les liens de jets de dés
 - commande `/jet` pour poster une demande de jet de dés
 
 ## 12.0.38 - Les prévisions d'Astrobazzarh
+
 - Correction de modifications de personnages qui ne s'affichaient pas:
   - changements d'endurance/vie/fatigue, transformé, ...
 - Migration des compétences "Ecriture" en "Écriture" dans les tâches, livres, oeuvres et méditations
@@ -17,12 +39,14 @@
   - utilisation de l'extension hbs pour tous les fichiers handlebars
 
 ## 12.0.37 - Les enchantements d'Astrobazzarh
+
 - les potions ont un état, seules les potions liquides sont enchantables
 - les lancements de sorts du jour sont conservés jusqu'à chateau dormant
 - lorsqu'un joueur souhaite enchanter une potion, les sorts d'enchantements/purification/permanence doivent avoir été lancés auparavant
 - on peut enchanter des gemmes exactement comme des potions
 
 ## 12.0.36 - L'alchimie d'Astrobazzarh
+
 - Nouveautés
   - ajout d'un bouton pour enchanter les potions
   - standardisation des boutons d'actions sur les items
@@ -37,9 +61,11 @@
   - Corrections de descriptions pour proposer les jet de dés
 
 ## 12.0.35 - La Solution d'Astrobazzarh
+
 - Fix problème d'initialisation des feuilles d'items
 
 ## 12.0.34 - la tête d'Astrobazzarh
+
 - support de liens "jets de dés"
   - on peut ajouter des liens "jet de dés" dans les journaux, descriptions, notes, maladresses, ...
   - avec la syntaxe `@roll[...]` on peut ajouter le lien vers:
@@ -54,21 +80,26 @@
 - gestion des blocs secrets dans les descriptions
 
 ## 12.0.33 - la vieillesse d'Astrobazzarh
+
 - retour de l'expérience pour les joueurs
 - suppression du message "Pas de caractéristique" sur les jets d'odorat-goût
 
 ## 12.0.32 - les rêveries d'Astrobazzarh
+
 - Ajout des Items Race pour gérer les ajustements liés aux races
 
 ## 12.0.31 - le mausolée d'Astrobazzarh
+
 - Correction: les automatisation de combat jouer-MJ fonctionnentde nouveau
 
 ## 12.0.30 - le cauchemar d'Astrobazzarh
+
 - calcul automatique du niveau des entités selon leur rêve
 - la description des créatures venimeuses contient un lien vers leur venin
 - Correction: les messages de combats ne marchaient plus (Changement combiné Foundry + rêve de Dragon)
 
 ## 12.0.29 - L'indexation d'Astrobazzarh
+
 - les liens dans la descriptions des sorts pointent vers les sorts du compendium
 - la description du chrasme contient le lien vers son venin plutôt qu'un tableau
 

module/actor-sheet.js

@@ -237,7 +237,11 @@ export class RdDActorSheet extends RdDBaseActorSangSheet {
 
     this.html.find('.carac-xp-augmenter').click(async event => await this.actor.updateCaracXPAuto(event.currentTarget.name.replace("augmenter.", "")))
     this.html.find('.competence-xp-augmenter').click(async event => await this.actor.updateCompetenceXPAuto(RdDSheetUtility.getItemId(event)))
-    this.html.find('.competence-stress-augmenter').click(async event => await this.actor.updateCompetenceStress(RdDSheetUtility.getItemId(event)))
+    this.html.find('.competence-stress-augmenter').click(async event =>{
+      await this.actor.updateCompetenceStress(RdDSheetUtility.getItemId(event))
+      this.render(true)
+    } 
+  )
 
     if (this.options.vueDetaillee) {
       // On carac change

module/actor.js

@@ -243,7 +243,7 @@ export class RdDActor extends RdDBaseActorSang {
     }
     await this.resetInfoSommeil()
     ChatMessage.create(message);
-    this.sheet.render(true);
+    setTimeout(() => this.sheet.render(), 20)
   }
 
   async _recuperationSante(message) {
@@ -299,7 +299,7 @@ export class RdDActor extends RdDBaseActorSang {
         ChatMessage.create(message);
       }
       await this.resetInfoSommeil();
-      this.sheet.render(true);
+      setTimeout(() => this.sheet.render(), 20)
     }
   }
 
@@ -442,10 +442,9 @@ export class RdDActor extends RdDBaseActorSang {
       message.content += 'Vous ne trouvez pas le sommeil';
     }
     else {
-      let jetsReve = [];
+      let dormi = await this.$dormirDesHeures(message, heures, options);
-      let dormi = await this.dormirDesHeures(jetsReve, message, heures, options);
+      if (dormi.jetsReve.length > 0) {
-      if (jetsReve.length > 0) {
+        message.content += `Vous récupérez ${dormi.jetsReve.map(it => it < 0 ? '0 (réveil)' : it).reduce(Misc.joining("+"))} Points de rêve. `;
-        message.content += `Vous récupérez ${jetsReve.map(it => it < 0 ? '0 (réveil)' : it).reduce(Misc.joining("+"))} Points de rêve. `;
       }
       if (dormi.etat == 'eveil') {
         await this.reveilReveDeDragon(message, dormi.heures);
@@ -461,7 +460,7 @@ export class RdDActor extends RdDBaseActorSang {
       await this.dormirChateauDormant();
     }
     else {
-      this.sheet.render(true);
+      setTimeout(() => this.sheet.render(), 20)
     }
   }
 
@@ -472,18 +471,18 @@ export class RdDActor extends RdDBaseActorSang {
     }
   }
 
-  async dormirDesHeures(jetsReve, message, heures, options) {
+  async $dormirDesHeures(message, heures, options) {
-    const dormi = { heures: 0, etat: 'dort' };
+    const dormi = { heures: 0, etat: 'dort', jetsReve: [] };
     for (; dormi.heures < heures && dormi.etat == 'dort'; dormi.heures++) {
-      await this._recupererEthylisme(message);
+      await this.$recupererEthylisme(message);
       if (options.grisReve) {
-        await this.recupererFatigue(message);
+        await this.$recupererFatigue(message);
       }
       else if (!this.system.sommeil?.insomnie) {
-        await this.recupererFatigue(message);
+        await this.$recupererFatigue(message);
-        dormi.etat = await this.jetRecuperationReve(jetsReve, message);
+        await this.$jetRecuperationReve(dormi, message);
         if (dormi.etat == 'dort' && EffetsDraconiques.isDonDoubleReve(this)) {
-          dormi.etat = await this.jetRecuperationReve(jetsReve, message);
+          dormi.etat = await this.$jetRecuperationReve(dormi, message);
         }
       }
     }
@@ -491,35 +490,36 @@ export class RdDActor extends RdDBaseActorSang {
   }
 
   /* -------------------------------------------- */
-  async jetRecuperationReve(jetsReve, message) {
+  async $jetRecuperationReve(dormi, message) {
     if (this.getReveActuel() < this.system.reve.seuil.value) {
-      let reve = await RdDDice.rollTotal("1dr");
+      const reve = await RdDDice.rollTotal("1dr")
       if (reve >= 7) {
         // Rêve de Dragon !
         message.content += `Vous faites un <strong>Rêve de Dragon</strong> de ${reve} Points de rêve qui vous réveille! `;
         await this.combattreReveDeDragon(reve);
-        jetsReve.push(-1);
+        dormi.jetsReve.push(-1);
-        return 'eveil';
+        dormi.etat = 'eveil'
+        return
       }
       else {
         if (!ReglesOptionnelles.isUsing("recuperation-reve")) {
           ChatMessage.create({
             whisper: ChatUtility.getOwners(this),
             content: `Pas de récupération de rêve (${reve} points ignorés)`
-          });
+          })
-          jetsReve.push(0);
+          dormi.jetsReve.push(0)
         }
         else {
-          await this.reveActuelIncDec(reve);
+          await this.reveActuelIncDec(reve)
-          jetsReve.push(reve);
+          dormi.jetsReve.push(reve)
         }
       }
     }
-    return 'dort';
+    dormi.etat = 'dort'
   }
 
   /* -------------------------------------------- */
-  async _recupererEthylisme(message) {
+  async $recupererEthylisme(message) {
     if (!ReglesOptionnelles.isUsing("recuperation-ethylisme")) { return; }
     let value = Math.min(Number.parseInt(this.system.compteurs.ethylisme.value) + 1, 1);
     if (value <= 0) {
@@ -549,15 +549,16 @@ export class RdDActor extends RdDBaseActorSang {
   }
 
   /* -------------------------------------------- */
-  async recupererFatigue(message) {
+  async $recupererFatigue(message) {
     if (ReglesOptionnelles.isUsing("appliquer-fatigue")) {
-      let fatigue = this.system.sante.fatigue.value;
+      let fatigue = this.system.sante.fatigue.value
-      const fatigueMin = this.getFatigueMin();
+      const fatigueMin = this.getFatigueMin()
       if (fatigue <= fatigueMin) {
-        return;
+        return
       }
-      fatigue = Math.max(fatigueMin, this._calculRecuperationSegment(fatigue));
+      fatigue = Math.max(fatigueMin, this._calculRecuperationSegment(fatigue))
-      await this.update({ "system.sante.fatigue.value": fatigue });
+      await this.update({ 'system.sante.fatigue.value': fatigue });
+      await new Promise(resolve => setTimeout(resolve, 200)); 
       if (fatigue == 0) {
         message.content += "Vous êtes complêtement reposé. ";
       }
@@ -736,7 +737,7 @@ export class RdDActor extends RdDBaseActorSang {
       await competence.update({
         "system.xp": toXp,
         "system.niveau": toNiveau,
-      });
+      }, { render: false })
       await ExperienceLog.add(this, XP_TOPIC.XP, fromXp, toXp, competence.name);
       await ExperienceLog.add(this, XP_TOPIC.NIVEAU, fromNiveau, toNiveau, competence.name);
     }
@@ -767,7 +768,7 @@ export class RdDActor extends RdDBaseActorSang {
     await competence.update({
       "system.xp": newXp,
       "system.niveau": toNiveau,
-    });
+    }, { render: false })
     const toXpStress = Math.max(0, fromXpStress - xpUtilise);
     await this.update({ "system.compteurs.experience.value": toXpStress });
 
@@ -783,7 +784,7 @@ export class RdDActor extends RdDBaseActorSang {
       const toNiveau = compValue ?? RdDItemCompetence.getNiveauBase(competence.system.categorie, competence.getCategories());
       this.notifyCompetencesTronc(competence, toNiveau);
       const fromNiveau = competence.system.niveau;
-      await competence.update({ 'system.niveau': toNiveau });
+      await competence.update({ 'system.niveau': toNiveau }, { render: false })
       await ExperienceLog.add(this, XP_TOPIC.NIVEAU, fromNiveau, toNiveau, competence.name, true);
     }
   }
@@ -808,7 +809,7 @@ export class RdDActor extends RdDBaseActorSang {
       if (isNaN(toXp) || typeof (toXp) != 'number') toXp = 0;
       const fromXp = competence.system.xp;
       this.checkCompetenceXP(idOrName, toXp);
-      await competence.update({ 'system.xp': toXp });
+      await competence.update({ 'system.xp': toXp }, { render: false })
       await ExperienceLog.add(this, XP_TOPIC.XP, fromXp, toXp, competence.name, true);
       if (toXp > fromXp) {
         RdDUtility.checkThanatosXP(competence)
@@ -822,7 +823,7 @@ export class RdDActor extends RdDBaseActorSang {
     if (competence) {
       if (isNaN(toXpSort) || typeof (toXpSort) != 'number') toXpSort = 0;
       const fromXpSort = competence.system.xp_sort;
-      await competence.update({ 'system.xp_sort': toXpSort });
+      await competence.update({ 'system.xp_sort': toXpSort }, { render: false })
       await ExperienceLog.add(this, XP_TOPIC.XPSORT, fromXpSort, toXpSort, competence.name, true);
       if (toXpSort > fromXpSort) {
         RdDUtility.checkThanatosXP(competence)
@@ -834,7 +835,7 @@ export class RdDActor extends RdDBaseActorSang {
   async updateCompetenceArchetype(idOrName, compValue) {
     let competence = this.getCompetence(idOrName)
     if (competence) {
-      await competence.update({ 'system.niveau_archetype': Math.max(compValue ?? 0, 0) });
+      await competence.update({ 'system.niveau_archetype': Math.max(compValue ?? 0, 0) })
     }
   }
 
@@ -1800,8 +1801,10 @@ export class RdDActor extends RdDBaseActorSang {
     };
     RollDataAjustements.calcul(rollData, this);
     await RdDResolutionTable.rollData(rollData);
-    this.gererExperience(rollData);
     await RdDRollResult.displayRollData(rollData, this)
+
+    this.gererExperience(rollData);
+
     return rollData.rolled;
   }
 
@@ -2527,7 +2530,6 @@ export class RdDActor extends RdDBaseActorSang {
       })
     }
     const blessure = this.getItem(blessureId, 'blessure')
-    console.log('TODO update blessure', this, blessureId, rollData, rollData.tache);
     if (blessure && !blessure.system.premierssoins.done) {
       const tache = rollData.tache;
       if (rollData.rolled.isETotal) {
@@ -2644,12 +2646,13 @@ export class RdDActor extends RdDBaseActorSang {
   }
 
   /* -------------------------------------------- */
-  async incDecItemUse(itemId, inc = 1) {
+  async incDecItemUse(itemId, shouldIncrease = true) {
+    if (shouldIncrease) {
       const currentItemUse = this.getFlag(SYSTEM_RDD, 'itemUse');
       let itemUse = currentItemUse ? foundry.utils.duplicate(currentItemUse) : {};
-    itemUse[itemId] = (itemUse[itemId] ?? 0) + inc;
+      itemUse[itemId] = (itemUse[itemId] ?? 0) + 1;
       await this.setFlag(SYSTEM_RDD, 'itemUse', itemUse);
-    console.log("ITEM USE INC", inc, itemUse);
+    }
   }
 
   /* -------------------------------------------- */

module/actor/base-actor-reve.js

@@ -277,14 +277,9 @@ export class RdDBaseActorReve extends RdDBaseActor {
     return dialog
   }
 
-  createEmptyCallback() {
+  createCallbackExperience() { return { action: r => { } } }
-    return {
+  createCallbackAppelAuMoral() { return { action: r => { } } }
-      condition: r => false,
+
-      action: r => { }
-    };
-  }
-  createCallbackExperience() { return this.createEmptyCallback(); }
-  createCallbackAppelAuMoral() { return this.createEmptyCallback(); }
   async _onCloseRollDialog(html) { }
 
   async rollCaracCompetence(caracName, compName, diff, options = { title: "" }) {

module/actor/base-actor.js

@@ -244,16 +244,19 @@ export class RdDBaseActor extends Actor {
   async onUpdateActor(update, options, actorId) { }
   async onDeleteItem(item, options, id) {
     if (item.isInventaire()) {
-      this._removeItemFromConteneur(item)
+      await this._removeItemFromConteneur(item)
     }
   }
 
-  _removeItemFromConteneur(item) {
+  async _removeItemFromConteneur(item) {
-    this.items.filter(it => it.isConteneur() && it.system.contenu.includes(item.id))
+    const updates = this.items.filter(it => it.isConteneur() && it.system.contenu.includes(item.id))
-      .forEach(conteneur => {
+      .map(conteneur => {
-        const nouveauContenu = conteneur.system.contenu.filter(id => id != item.id);
+        const nouveauContenu = conteneur.system.contenu.filter(id => id != item.id)
-        conteneur.update({ 'system.contenu': nouveauContenu });
+        return { _id: conteneur.id, 'system.contenu': nouveauContenu }
-      });
+      })
+    if (updates.length > 0) {
+      await this.updateEmbeddedDocuments('Item', updates)
+    }
   }
 
   async onTimeChanging(oldTimestamp, newTimestamp) {
@@ -744,7 +747,7 @@ export class RdDBaseActor extends Actor {
   async jetDeMoral() { this.actionImpossible("jet de moral") }
 
   async resetItemUse() { }
-  async incDecItemUse(itemId, inc = 1) { }
+  async incDecItemUse(itemId, shouldIncrease = true) { }
   getItemUse(itemId) { return 0; }
 
   async finDeRound(options = { terminer: false }) { }

module/applications/sheets/_module.mjs

@@ -1,2 +0,0 @@
-export { default as RdDItemBaseSheet} from "./common-item-sheet.mjs"
-export { default as RdDMonnaieSheet } from "./monnaie-sheet.mjs"

module/applications/sheets/common-item-sheet.mjs

@@ -1,111 +0,0 @@
-const { HandlebarsApplicationMixin } = foundry.applications.api
-import { SYSTEM_RDD } from "../../constants.js"
-import { Misc } from "../../misc.js"
-import { RdDSheetUtility } from "../../rdd-sheet-utility.js";
-
-
-export default class RdDItemBaseSheet extends HandlebarsApplicationMixin(foundry.applications.sheets.ItemSheetV2) {
-
-  static preloadHandlebars(...templatesList) {
-    const handlebars = ["systems/foundryvtt-reve-de-dragon/templates/sheets/item/common/header.hbs"]
-    templatesList.forEach(templates =>
-      templates.forEach(t =>
-        t.handlebars().forEach(h => handlebars.push(h))
-      )
-    )
-    loadTemplates(Misc.distinct(handlebars))
-  }
-  
-  static register(sheetClass) {
-    const itemType = sheetClass.ITEM_TYPE
-    Items.registerSheet(SYSTEM_RDD, sheetClass, {
-      label: Misc.typeName('Item', itemType),
-      types: [itemType],
-      makeDefault: true
-    })
-  }
-  
-  static registerAll(...sheetClasses) {
-    const handlebars = ["systems/foundryvtt-reve-de-dragon/templates/sheets/item/common/header.hbs"]
-    sheetClasses.forEach(sheetClass => {
-      sheetClass.TEMPLATES.forEach(t =>
-        t.handlebars().forEach(h => handlebars.push(h))
-      )
-      const itemType = sheetClass.ITEM_TYPE
-      Items.registerSheet(SYSTEM_RDD, sheetClass, {
-        label: Misc.typeName('Item', itemType),
-        types: [itemType],
-        makeDefault: true
-      })
-    })
-    loadTemplates(Misc.distinct(handlebars))
-  }
-
-  static get ITEM_TYPE() { return undefined }
-
-  constructor(options = {}) {
-    super(options)
-  }
-
-  static get TEMPLATES() { return [] }
-
-  /** @override */
-  static DEFAULT_OPTIONS = {
-    classes: ["fvtt-rdd", "item"],
-    position: {
-      width: 600,
-      height: "auto",
-    },
-    form: {
-      submitOnChange: true,
-    },
-    window: {
-      resizable: true,
-    },
-    actions: {
-      editImage: RdDItemBaseSheet.#onEditImage,
-    }
-  }
-
-  /** @override */
-  async _prepareContext() {
-    return {
-      item: this.document,
-      options: RdDSheetUtility.getOptions(this.document, this.isEditable),
-      fields: this.document.schema.fields,
-      systemFields: this.document.system.schema.fields,
-      system: this.document.system,
-      source: this.document.toObject(),
-      isEditable: this.isEditable,
-    }
-  }
-
-  // #region Actions
-
-  /**
-   * Handle changing a Document's image.
-   *
-   * @this RdDItemBaseSheet
-   * @param {PointerEvent} event   The originating click event
-   * @param {HTMLElement} target   The capturing HTML element which defined a [data-action]
-   * @returns {Promise}
-   * @private
-   */
-  static async #onEditImage(event, target) {
-    const attr = target.dataset.edit
-    const current = foundry.utils.getProperty(this.document, attr)
-    const { img } = this.document.constructor.getDefaultArtwork?.(this.document.toObject()) ?? {}
-    const fp = new FilePicker({
-      current,
-      type: "image",
-      redirectToRoot: img ? [img] : [],
-      callback: (path) => {
-        this.document.update({ [attr]: path })
-      },
-      top: this.position.top + 40,
-      left: this.position.left + 10,
-    })
-    return fp.browse()
-  }
-  // #endregion
-}

module/applications/sheets/monnaie-sheet.mjs

@@ -1,40 +0,0 @@
-import { TEMPLATE_DESCRIPTION, TEMPLATE_INVENTAIRE } from "../../common/_module.mjs";
-import { ITEM_TYPES } from "../../constants.js";
-import RdDItemBaseSheet from "./common-item-sheet.mjs";
-
-export default class RdDMonnaieSheet extends RdDItemBaseSheet {
-
-  /** @override */
-  static get ITEM_TYPE() { return ITEM_TYPES.monnaie }
-  static get TEMPLATES() { return [TEMPLATE_DESCRIPTION, TEMPLATE_INVENTAIRE] }
-
-  /** @override */
-  static DEFAULT_OPTIONS = Object.assign({},
-    RdDItemBaseSheet.DEFAULT_OPTIONS,
-    {
-      classes: ["fvtt-rdd", "item", "monnaie"],
-      position: {
-        width: 400,
-      },
-      window: {
-        contentClasses: ["monnaie-content"],
-      }
-    })
-
-
-  /** @override */
-  static PARTS = {
-    main: {
-      template: "systems/foundryvtt-reve-de-dragon/templates/sheets/item/monnaie.hbs",
-    },
-  }
-
-  /** @override */
-  async _prepareContext() {
-    return Object.assign(
-      await super._prepareContext(),
-      await TEMPLATE_DESCRIPTION.prepareContext(this.document),
-      await TEMPLATE_INVENTAIRE.prepareContext(this.document)
-    )
-  }
-}

module/apps/textroll/text-roll-carac-competence.js

@@ -5,7 +5,7 @@ import { RdDUtility } from "../../rdd-utility.js";
 import { TextRollManager } from "./text-roll-formatter.js";
 
 const REGECP_CARAC = "(?<carac>[A-Za-zÀ-ÖØ-öø-ÿ\\s\\-]+)"
-const REGEXP_COMP = "(\\/(?<competence>[A-Za-z0-9À-ÖØ-öø-ÿ -]+))?"
+const REGEXP_COMP = "(\\/(?<competence>[A-Za-zÀ-ÖØ-öø-ÿ ]+([1-2]?[A-Za-zÀ-ÖØ-öø-ÿ ]+)?))?"
 const REGEXP_DIFF = "(/(?<diff>[\\+\\-]?\\d+(d\\d+)?))?"
 const REGEXP_ROLL_CARAC_COMP = REGECP_CARAC + REGEXP_COMP + REGEXP_DIFF
 const XREGEXP_ROLL_CARAC_COMP = XRegExp("@roll\\[" + REGEXP_ROLL_CARAC_COMP + "\\]", 'giu')

module/chat-utility.js

@@ -62,7 +62,6 @@ export class ChatUtility {
   }
 
   /* -------------------------------------------- */
-
   static removeMessages(socketData) {
     if (Misc.isFirstConnectedGM()) {
       ChatUtility.onRemoveMessages(socketData);
@@ -97,7 +96,7 @@ export class ChatUtility {
         }
         break
       case "gmroll":
-        messageData.whisper = ChatUtility.getOwners(actor)
+        messageData.whisper = actor ? ChatUtility.getOwners(actor) : ChatUtility.getUserAndGMs()
         break
       case "selfroll":
         messageData.whisper = [game.user]
@@ -108,7 +107,7 @@ export class ChatUtility {
   }
 
   static getOwners(document) {
-    return game.users.filter(it => document.getUserLevel(it) == CONST.DOCUMENT_OWNERSHIP_LEVELS.OWNER)
+    return document ? game.users.filter(it => document.getUserLevel(it) == CONST.DOCUMENT_OWNERSHIP_LEVELS.OWNER) : [game.user]
   }
 
   static getUserAndGMs() {

module/common/_module.mjs

@@ -1,8 +0,0 @@
-import { CommonDescription } from "./description.mjs";
-import { CommonInventaire } from "./inventaire.mjs";
-
-export const TEMPLATE_DESCRIPTION = new CommonDescription()
-export const TEMPLATE_INVENTAIRE = new CommonInventaire()
-
-export const ALL_COMMON_TEMPLATES = [TEMPLATE_DESCRIPTION, TEMPLATE_INVENTAIRE]
-

module/common/common-template.mjs

@@ -1,10 +0,0 @@
-/**
- * class describing common methods implemented by template parts,
- * used for sheet/models/documents
- */
-export default class CommonTemplate {
-  fields() { }
-  handlebars() { return [] }
-  actions() { return {} }
-  async prepareContext(item) { }
-}

module/common/description.mjs

@@ -1,32 +0,0 @@
-import { RdDTextEditor } from "../apps/rdd-text-roll-editor.js"
-import CommonTemplate from "./common-template.mjs"
-import { HTMLSTRING } from "./field-types.mjs"
-
-const fields = foundry.data.fields
-
-export class CommonDescription extends CommonTemplate {
-  fields() {
-    return {
-      description: new fields.HTMLField({ ...HTMLSTRING }),
-      descriptionmj: new fields.HTMLField({ gmOnly: true, ...HTMLSTRING })
-    }
-  }
-
-  handlebars() {
-    return [
-      "systems/foundryvtt-reve-de-dragon/templates/sheets/item/common/template-description.hbs",
-    ]
-  }
-  actions() {
-    return {}
-  }
-
-  async prepareContext(item) {
-    const enriched = {
-      description: await RdDTextEditor.enrichHTML(item.system.description, item),
-      descriptionmj: await RdDTextEditor.enrichHTML(item.system.descriptionmj, item),
-    }
-    return { enriched }
-  }
-
-}

module/common/field-types.mjs

@@ -1,9 +0,0 @@
-export const INTEGER = { required: true, nullable: false, min: 0, integer: true }
-export const DECIMAL = { required: true, nullable: false, min: 0, integer: false } /* TODO: validation de nombre décimales?*/
-export const INTEGER_SIGNED = { required: true, nullable: false, integer: true }
-export const DECIMAL_SIGNED = { required: true, nullable: false, integer: false }
-export const STRING = { required: true, nullable: false, blank: true, trim: true }
-export const HTMLSTRING = { initial: "", required: true, nullable: false, blank: true, textSearch: true }
-
-export const MODEL_ARRAY = { initial: [], required: true, nullable: false }
-

module/common/inventaire.mjs

@@ -1,36 +0,0 @@
-import CommonTemplate from "./common-template.mjs"
-import { RARETES } from "../item/raretes.js"
-import { DECIMAL, INTEGER, INTEGER_SIGNED, MODEL_ARRAY, STRING } from "./field-types.mjs"
-
-const fields = foundry.data.fields
-
-export class CommonInventaire extends CommonTemplate {
-  fields() {
-    return {
-      encombrement: new fields.NumberField({ label: "Encombrement", initial: 0, ...INTEGER }),
-      quantite: new fields.NumberField({ label: "Quantité", initial: 1, ...INTEGER }),
-      qualite: new fields.NumberField({ label: "Qualité", initial: 0, ...INTEGER_SIGNED }),
-      cout: new fields.NumberField({ label: "Coût", initial: 0.0, ...DECIMAL }),
-      environnement: new fields.ArrayField(
-        new fields.SchemaField({
-          milieu: new fields.StringField({ label: "Milieu", initial: "", ...STRING }),
-          rarete: new fields.StringField({
-            label: "Rareté", initial: RARETES[0].code, ...STRING,
-            validate: (value, options) => RARETES.find(it => it.code == value)
-          }),
-          frequence: new fields.NumberField({ label: "Fréquence", initial: RARETES[0].frequence, ...INTEGER }),
-        }),
-        { label: "Environnement", ...MODEL_ARRAY }),
-    }
-  }
-
-  handlebars() {
-    return [
-      "systems/foundryvtt-reve-de-dragon/templates/sheets/item/common/template-inventaire.hbs"
-    ]
-  }
-
-  async prepareContext(item) {
-    return {}
-  }
-}

module/documents/_module.mjs

@@ -1,2 +0,0 @@
-export { default as RdDModelMonnaie } from "./monnaie.mjs"
-export { default as RdDModelMunition } from "./munition.mjs"

module/documents/monnaie.mjs

@@ -1,7 +0,0 @@
-import { RdDItem } from "../item.js";
-
-export default class RdDItemMonnaie extends RdDItem {
-  static get defaultIcon() {
-    return 'systems/foundryvtt-reve-de-dragon/icons/objets/piece_etain_poisson.webp'
-  }
-}

module/item-sheet.js

@@ -14,11 +14,12 @@ import { RdDItem } from "./item.js";
 import { FLEUVE_COORD, TMRUtility } from "./tmr-utility.js";
 import { RdDTextEditor } from "./apps/rdd-text-roll-editor.js";
 import { ItemAction } from "./item/item-actions.js";
+import { RdDItemGemme } from "./item/gemme.js";
 
 /**
  * Extend the basic ItemSheet for RdD specific items
  */
-export class RdDItemSheetV1 extends ItemSheet {
+export class RdDItemSheet extends ItemSheet {
 
   static get ITEM_TYPE() {
     return undefined
@@ -42,7 +43,7 @@ export class RdDItemSheetV1 extends ItemSheet {
   static get defaultOptions() {
     return foundry.utils.mergeObject(super.defaultOptions, {
       classes: [SYSTEM_RDD, "sheet", "item"],
-      template: RdDItemSheetV1.defaultTemplate(RdDItemSheetV1.ITEM_TYPE),
+      template: RdDItemSheet.defaultTemplate(RdDItemSheet.ITEM_TYPE),
       width: 550,
       height: 550
     }, { inplace: false });
@@ -50,7 +51,7 @@ export class RdDItemSheetV1 extends ItemSheet {
 
   /* -------------------------------------------- */
   get template() {
-    return RdDItemSheetV1.defaultTemplate(this.item.type);
+    return RdDItemSheet.defaultTemplate(this.item.type);
   }
 
   get title() {
@@ -100,7 +101,7 @@ export class RdDItemSheetV1 extends ItemSheet {
       description: await RdDTextEditor.enrichHTML(this.item.system.description, this.item),
       descriptionmj: await RdDTextEditor.enrichHTML(this.item.system.descriptionmj, this.item),
       isComestible: this.item.getUtilisationCuisine(),
-      options: RdDSheetUtility.mergeDocumentRights({}, this.item, this.isEditable),
+      options: RdDSheetUtility.mergeDocumentRights(this.options, this.item, this.isEditable),
       competences: await SystemCompendiums.getCompetences(ACTOR_TYPES.personnage),
       categories: RdDItem.getCategories(this.item.type),
     }
@@ -263,7 +264,7 @@ export class RdDItemSheetV1 extends ItemSheet {
   _updateObject(event, formData) {
     switch (this.item.type) {
       case ITEM_TYPES.sort:
-        formData['system.bonuscase'] = RdDItemSort.bonuscasesToString(RdDItemSheetV1._listCaseTmr(
+        formData['system.bonuscase'] = RdDItemSort.bonuscasesToString(RdDItemSheet._listCaseTmr(
           formData.caseTmrCoord,
           formData.caseTmrBonus,
           formData.caseTmrAdd
@@ -313,7 +314,7 @@ export class RdDItemSheetV1 extends ItemSheet {
 
   async _onDrop(event) {
     // Try to extract the dragData
-    let dragData = RdDItemSheetV1.$extractDragData(event);
+    let dragData = RdDItemSheet.$extractDragData(event);
     if (!dragData) return false;
     const allowed = Hooks.call("dropActorSheetData", this.actor, this, dragData);
     if (allowed === false) return false;

module/item-sort.js

@@ -56,6 +56,10 @@ export class RdDItemSort extends Item {
     return voies.map(voie => RdDItemCompetence.getVoieDraconic(competencesDraconic, voie))
   }
 
+  static getBestDraconicSort(competencesDraconic, sort) {
+    return  RdDItemSort.getDraconicsSort(competencesDraconic, sort).sort(Misc.descending(it => it.system.niveau)).find(it=>true)
+  }
+
   static getOrdreCode(code) {
     return (VOIES_DRACONIC.find(it => it.code == code)?.ordre ?? '?')
   }
@@ -92,7 +96,7 @@ export class RdDItemSort extends Item {
 
   /* -------------------------------------------- */
   static isCoutVariable(sort) {
-    return sort && (sort.system.ptreve.toLowerCase() == "variable" || sort.system.ptreve.indexOf("+") >= 0);
+    return sort && !Number.isInteger(sort.system.ptreve) && (sort.system.ptreve.toLowerCase() == "variable" || sort.system.ptreve.indexOf("+") >= 0);
   }
 
   /* -------------------------------------------- */

module/item/sheet-base-inventaire.js

@@ -1,14 +1,14 @@
 import { HtmlUtility } from "../html-utility.js";
-import { RdDItemSheetV1 } from "../item-sheet.js";
+import { RdDItemSheet } from "../item-sheet.js";
 import { Misc } from "../misc.js";
 import { RdDRaretes } from "./raretes.js";
 
 const TYPE_ITEMS_NATURELS = ["faune", "herbe", "plante", "ingredient"];
 
-export class RdDItemInventaireSheet extends RdDItemSheetV1 {
+export class RdDItemInventaireSheet extends RdDItemSheet {
 
   static get defaultOptions() {
-    return foundry.utils.mergeObject(RdDItemSheetV1.defaultOptions, {
+    return foundry.utils.mergeObject(RdDItemSheet.defaultOptions, {
       tabs: [{ navSelector: ".sheet-tabs", contentSelector: ".sheet-body", initial: "informations" }]
     }, { inplace: false })
   }

module/item/sheet-blessure.js

@@ -1,6 +1,6 @@
-import { RdDItemSheetV1 } from "../item-sheet.js";
+import { RdDItemSheet } from "../item-sheet.js";
 
-export class RdDBlessureItemSheet extends RdDItemSheetV1 {
+export class RdDBlessureItemSheet extends RdDItemSheet {
 
   static get ITEM_TYPE() { return "blessure" };
 

module/item/sheet-rencontre.js

@@ -1,7 +1,7 @@
 import { RdDRencontre } from "./rencontre.js";
-import { RdDItemSheetV1 } from "../item-sheet.js";
+import { RdDItemSheet } from "../item-sheet.js";
 
-export class RdDRencontreItemSheet extends RdDItemSheetV1 {
+export class RdDRencontreItemSheet extends RdDItemSheet {
   
   static get ITEM_TYPE() { return "rencontre" };
 

module/item/sheet-service.js

@@ -1,6 +1,6 @@
-import { RdDItemSheetV1 } from "../item-sheet.js";
+import { RdDItemSheet } from "../item-sheet.js";
 
-export class RdDServiceItemSheet extends RdDItemSheetV1 {
+export class RdDServiceItemSheet extends RdDItemSheet {
 
   static get ITEM_TYPE() { return "service" };
 

module/item/sheet-signedraconique.js

@@ -1,12 +1,12 @@
-import { RdDItemSheetV1 } from "../item-sheet.js";
+import { RdDItemSheet } from "../item-sheet.js";
 import { RdDItemSigneDraconique } from "./signedraconique.js";
 import { TMRUtility } from "../tmr-utility.js";
 
 /**
  * Item sheet pour signes draconiques
- * @extends {RdDItemSheetV1}
+ * @extends {RdDItemSheet}
  */
-export class RdDSigneDraconiqueItemSheet extends RdDItemSheetV1 {
+export class RdDSigneDraconiqueItemSheet extends RdDItemSheet {
 
   static get ITEM_TYPE() { return "signedraconique" }
 

module/misc.js

@@ -265,7 +265,7 @@ export class Misc {
     const subset = elements.filter(options.preFilter)
       .filter(it => Grammar.toLowerCaseNoAccent(options.mapper(it))?.includes(value))
       .sort(Misc.ascending(it => options.mapper(it)))
-    if (subset.length == 0) {
+    if (subset.length == 0 && options?.onMessage) {
       options.onMessage(`Pas de ${options.description} correspondant à ${value}`);
     }
     return subset;

module/models/_module.mjs

@@ -1 +0,0 @@
-export { default as RdDModelMonnaie } from "./monnaie.mjs"

module/models/monnaie.mjs

@@ -1,10 +0,0 @@
-import { TEMPLATE_DESCRIPTION, TEMPLATE_INVENTAIRE } from "../common/_module.mjs";
-
-export default class RdDModelMonnaie extends foundry.abstract.TypeDataModel {
-  static defineSchema() {
-    return Object.assign({},
-      TEMPLATE_DESCRIPTION.fields(),
-      TEMPLATE_INVENTAIRE.fields()
-    )
-  }
-}

module/rdd-combat.js

@@ -743,23 +743,13 @@ export class RdDCombat {
           this.attacker.createCallbackExperience(),
           this.attacker.createCallbackAppelAuMoral(),
           { action: r => this.removeChatMessageActionsPasseArme(r.passeArme) },
-          { action: r => this._increaseItemUse(r, arme) },
+          { action: async r => await this.attacker.incDecItemUse(arme._id, arme && !RdDCombat.isParticuliere(r)) },
-          { action: r => this._onAttaqueNormale(r) },
+          { action: r => this._onAttaque(r) },
-          { action: r => this._onAttaqueParticuliere(r) },
-          { action: r => this._onAttaqueEchec(r) },
-          { action: r => this._onAttaqueEchecTotal(r) },
         ]
       });
     dialog.render(true);
   }
 
-  _increaseItemUse(rollData, arme) {
-    if (!arme || RdDCombat.isParticuliere(rollData)) {
-      return
-    }
-    this.attacker.incDecItemUse(arme._id)
-  }
-
   /* -------------------------------------------- */
   _prepareAttaque(competence, arme) {
     let rollData = {
@@ -790,11 +780,23 @@ export class RdDCombat {
     return rollData;
   }
 
+  async _onAttaque(attackerRoll) {
+    if (RdDCombat.isParticuliere(attackerRoll)) {
+      return await this._onAttaqueParticuliere(attackerRoll)
+    }
+    if (RdDCombat.isReussite(attackerRoll)) {
+      return await this._onAttaqueNormale(attackerRoll)
+    }
+    // if (RdDCombat.isParticuliere(attackerRoll) && attackerRoll.particuliere == undefined) {
+    //   return
+    // }
+    if (RdDCombat.isEchecTotal(attackerRoll)) {
+      return await this._onAttaqueEchecTotal(attackerRoll)
+    }
+    return await this._onAttaqueEchec(attackerRoll)
+  }
   /* -------------------------------------------- */
   async _onAttaqueParticuliere(rollData) {
-    if (!RdDCombat.isParticuliere(rollData)) {
-      return
-    }
     const isMeleeDiffNegative = (rollData.competence.type == 'competencecreature' || rollData.selectedCarac.label == "Mêlée") && rollData.diffLibre < 0;
     // force toujours, sauf empoignade
     // finesse seulement en mélée, pour l'empoignade, ou si la difficulté libre est de -1 minimum
@@ -832,12 +834,6 @@ export class RdDCombat {
 
   /* -------------------------------------------- */
   async _onAttaqueNormale(attackerRoll) {
-    if (!RdDCombat.isReussite(attackerRoll)) {
-      return
-    }
-    if (RdDCombat.isParticuliere(attackerRoll) && attackerRoll.particuliere == undefined) {
-      return
-    }
     console.log("RdDCombat.onAttaqueNormale >>>", attackerRoll);
 
     attackerRoll.dmg = RdDBonus.dmg(attackerRoll, this.attacker, this.defender.isEntite());
@@ -954,9 +950,6 @@ export class RdDCombat {
 
   /* -------------------------------------------- */
   async _onAttaqueEchecTotal(attackerRoll) {
-    if (!RdDCombat.isEchecTotal(attackerRoll)) {
-      return
-    }
     const choixEchecTotal = await ChatMessage.create({
       whisper: ChatUtility.getOwners(this.attacker),
       content: await renderTemplate('systems/foundryvtt-reve-de-dragon/templates/chat-demande-attaque-etotal.hbs', {
@@ -983,22 +976,16 @@ export class RdDCombat {
   }
 
   /* -------------------------------------------- */
-  async _onAttaqueEchec(rollData) {
+  async _onAttaqueEchec(attackerRoll) {
-    if (!RdDCombat.isEchec(rollData)) {
+    console.log("RdDCombat.onAttaqueEchec >>>", attackerRoll);
-      return
+    await RdDRollResult.displayRollData(attackerRoll, this.attacker, 'chat-resultat-attaque.hbs');
-    }
-    console.log("RdDCombat.onAttaqueEchec >>>", rollData);
-    await RdDRollResult.displayRollData(rollData, this.attacker, 'chat-resultat-attaque.hbs');
-
   }
 
   /* -------------------------------------------- */
   async choixParticuliere(rollData, choix) {
     console.log("RdDCombat.choixParticuliere >>>", rollData, choix);
 
-    if (choix != "rapidite") {
+    await this.attacker.incDecItemUse(rollData.arme.id, choix != "rapidite")
-      this.attacker.incDecItemUse(rollData.arme.id);
-    }
 
     this.removeChatMessageActionsPasseArme(rollData.passeArme);
     rollData.particuliere = choix;
@@ -1026,10 +1013,8 @@ export class RdDCombat {
           this.defender.createCallbackExperience(),
           this.defender.createCallbackAppelAuMoral(),
           { action: r => this.removeChatMessageActionsPasseArme(r.passeArme) },
-          { condition: r => !RdDCombat.isParticuliere(r), action: r => this.defender.incDecItemUse(armeParadeId) },
+          { action: async r => await this.defender.incDecItemUse(armeParadeId, !RdDCombat.isParticuliere(r)) },
-          { condition: RdDCombat.isReussite, action: r => this._onParadeNormale(r) },
+          { action: r => this._onParade(r) },
-          { condition: RdDCombat.isParticuliere, action: r => this._onParadeParticuliere(r) },
-          { condition: RdDCombat.isEchec, action: r => this._onParadeEchec(r) },
         ]
       });
     dialog.render(true);
@@ -1060,8 +1045,19 @@ export class RdDCombat {
     return defenderRoll;
   }
 
+
+  async _onParade(defenderRoll) {
+    if (RdDCombat.isParticuliere(defenderRoll)) {
+      return await this._onParadeParticuliere(defenderRoll)
+    }
+    if (RdDCombat.isReussite(defenderRoll)) {
+      return await this._onParadeNormale(defenderRoll)
+    }
+    await this._onParadeEchec(defenderRoll)
+  }
+
   /* -------------------------------------------- */
-  _onParadeParticuliere(defenderRoll) {
+  async _onParadeParticuliere(defenderRoll) {
     console.log("RdDCombat._onParadeParticuliere >>>", defenderRoll);
     if (!defenderRoll.attackerRoll.isPart) {
       // TODO: attaquant doit jouer résistance et peut être désarmé p132
@@ -1070,7 +1066,6 @@ export class RdDCombat {
         this.defender)
     }
   }
-
   /* -------------------------------------------- */
   async _onParadeNormale(defenderRoll) {
     console.log("RdDCombat._onParadeNormale >>>", defenderRoll);
@@ -1109,11 +1104,9 @@ export class RdDCombat {
         callbacks: [
           this.defender.createCallbackExperience(),
           this.defender.createCallbackAppelAuMoral(),
-          { condition: r => !RdDCombat.isParticuliere(r), action: r => this.defender.incDecItemUse(esquive._id) },
+          { action: async r => await this.defender.incDecItemUse(esquive._id, !RdDCombat.isParticuliere(r)) },
           { action: r => this.removeChatMessageActionsPasseArme(r.passeArme) },
-          { condition: RdDCombat.isReussite, action: r => this._onEsquiveNormale(r) },
+          { action: r => this._onEsquive(r) },
-          { condition: RdDCombat.isParticuliere, action: r => this._onEsquiveParticuliere(r) },
-          { condition: RdDCombat.isEchec, action: r => this._onEsquiveEchec(r) },
         ]
       });
     dialog.render(true);
@@ -1141,9 +1134,18 @@ export class RdDCombat {
     return rollData;
   }
 
+  async _onEsquive(defenderRoll) {
+    if (RdDCombat.isParticuliere(defenderRoll)) {
+      return await this._onEsquiveParticuliere(defenderRoll)
+    }
+    if (RdDCombat.isReussite(defenderRoll)) {
+      return await this._onEsquiveNormale(defenderRoll)
+    }
+    return await this._onEsquiveEchec(defenderRoll)
+  }
   /* -------------------------------------------- */
-  _onEsquiveParticuliere(rollData) {
+  async _onEsquiveParticuliere(defenderRoll) {
-    console.log("RdDCombat._onEsquiveParticuliere >>>", rollData);
+    console.log("RdDCombat._onEsquiveParticuliere >>>", defenderRoll);
     ChatUtility.createChatWithRollMode(
       { content: "<strong>Vous pouvez esquiver une deuxième fois!</strong>" },
       this.defender);

module/rdd-main.js

@@ -54,7 +54,7 @@ import { RdDItemSouffle } from "./item/souffle.js"
 
 import { RdDRencontre } from "./item/rencontre.js"
 
-import { RdDItemSheetV1 } from "./item-sheet.js"
+import { RdDItemSheet } from "./item-sheet.js"
 import { RdDBlessureItemSheet } from "./item/sheet-blessure.js"
 import { RdDServiceItemSheet } from "./item/sheet-service.js"
 import { RdDRencontreItemSheet } from "./item/sheet-rencontre.js"
@@ -80,10 +80,6 @@ import { RdDItemPotion } from "./item/potion.js"
 import { RdDItemGemme } from "./item/gemme.js"
 import { RdDGemmeItemSheet } from "./item/sheet-gemme.js"
 
-import * as models from "./models/_module.mjs"
-import * as items from "./documents/_module.mjs"
-import * as sheets from "./applications/sheets/_module.mjs"
-
 /**
  * RdD system
  * Author: LeRatierBretonnien
@@ -104,7 +100,6 @@ export class SystemReveDeDragon {
     this.RdDHotbar = RdDHotbar
     this.RdDStatBlockParser = RdDStatBlockParser
     this.itemClasses = {
-      monnaie: items.RdDModelMonnaie,
       armure: RdDItemArmure,
       blessure: RdDItemBlessure,
       gemme: RdDItemGemme,
@@ -134,9 +129,6 @@ export class SystemReveDeDragon {
   /* -------------------------------------------- */
   onInit() {
     game.system.rdd = this
-
-    globalThis.RdD = game.system
-
     this.AppAstrologie = AppAstrologie
 
     console.log(`Initializing Reve de Dragon System Settings`)
@@ -183,9 +175,6 @@ export class SystemReveDeDragon {
     console.log(`Initializing Reve de Dragon Documents`)
     CONFIG.Actor.documentClass = RdDBaseActor
     CONFIG.Item.documentClass = RdDItem
-    CONFIG.Item.dataModels = {
-      monnaie: models.RdDModelMonnaie,
-    }
     CONFIG.RDD = {
       resolutionTable: RdDResolutionTable.resolutionTable,
       carac_array: RdDUtility.getCaracArray(),
@@ -206,18 +195,12 @@ export class SystemReveDeDragon {
 
     Items.registerSheet(SYSTEM_RDD, RdDItemInventaireSheet, {
       types: [
-        "objet", "arme", "armure", "livre", "munition", "nourritureboisson",
+        "objet", "arme", "armure", "livre", "munition",
+        "monnaie", "nourritureboisson",
       ],
       makeDefault: true
     })
-
+    Items.registerSheet(SYSTEM_RDD, RdDItemSheet, {
-    sheets.RdDItemBaseSheet.registerAll(
-      sheets.RdDMonnaieSheet
-    )
-
-    // ,
-    //   sheets.RdDMunitionSheet
-    Items.registerSheet(SYSTEM_RDD, RdDItemSheetV1, {
       types: [
         "competence", "competencecreature",
         "recettealchimique", "musique", "chant", "danse", "jeu", "race",
@@ -229,17 +212,17 @@ export class SystemReveDeDragon {
       makeDefault: true
     })
     
-    RdDItemSheetV1.register(RdDBlessureItemSheet)
+    RdDItemSheet.register(RdDBlessureItemSheet)
-    RdDItemSheetV1.register(RdDConteneurItemSheet)
+    RdDItemSheet.register(RdDConteneurItemSheet)
-    RdDItemSheetV1.register(RdDFauneItemSheet)
+    RdDItemSheet.register(RdDFauneItemSheet)
-    RdDItemSheetV1.register(RdDGemmeItemSheet)
+    RdDItemSheet.register(RdDGemmeItemSheet)
-    RdDItemSheetV1.register(RdDHerbeItemSheet)
+    RdDItemSheet.register(RdDHerbeItemSheet)
-    RdDItemSheetV1.register(RdDIngredientItemSheet)
+    RdDItemSheet.register(RdDIngredientItemSheet)
-    RdDItemSheetV1.register(RdDPlanteItemSheet)
+    RdDItemSheet.register(RdDPlanteItemSheet)
-    RdDItemSheetV1.register(RdDPotionItemSheet)
+    RdDItemSheet.register(RdDPotionItemSheet)
-    RdDItemSheetV1.register(RdDRencontreItemSheet)
+    RdDItemSheet.register(RdDRencontreItemSheet)
-    RdDItemSheetV1.register(RdDServiceItemSheet)
+    RdDItemSheet.register(RdDServiceItemSheet)
-    RdDItemSheetV1.register(RdDSigneDraconiqueItemSheet)
+    RdDItemSheet.register(RdDSigneDraconiqueItemSheet)
     RdDJournalSheet.register()
 
     // préparation des différents modules

module/rdd-possession.js

@@ -104,8 +104,8 @@ export class RdDPossession {
       rollData.selectedCarac = carac.reve
     }
     else {
-      rollData.selectedCarac = rollingActor.system.carac.reve
       rollData.forceCarac = { 'reve-actuel': { label: "Rêve Actuel", value: rollingActor.getReveActuel() } }
+      rollData.selectedCarac = rollData.forceCarac['reve-actuel']
       rollData.competence.system.defaut_carac = 'reve-actuel'
     }
   }

module/rdd-resolution-table.js

@@ -1,4 +1,3 @@
-import { ChatUtility } from "./chat-utility.js";
 import { Misc } from "./misc.js";
 import { RdDDice } from "./rdd-dice.js";
 import { ReglesOptionnelles } from "./settings/regles-optionnelles.js";

module/rdd-roll.js

@@ -279,7 +279,7 @@ export class RdDRoll extends Dialog {
 
   async setSelectedSort(sort) {
     this.rollData.selectedSort = sort; // Update the selectedCarac
-    this.rollData.competence = RdDItemCompetence.getVoieDraconic(this.rollData.draconicList, sort.system.draconic);
+    this.rollData.competence = RdDItemSort.getBestDraconicSort(this.rollData.draconicList, sort)
     this.rollData.bonus = RdDItemSort.getCaseBonus(sort, this.rollData.tmr.coord);
     this.rollData.diffLibre = RdDItemSort.getDifficulte(sort, -7);
     RdDItemSort.setCoutReveReel(sort);

module/rdd-sheet-utility.js

@@ -3,11 +3,11 @@ import { RdDItem } from "./item.js";
 
 export class RdDSheetUtility {
 
-  static getOptions(document, editable) {
+  static mergeDocumentRights(options, document, editable) {
     const userRightLevel = game.user.isGM
       ? CONST.DOCUMENT_OWNERSHIP_LEVELS.OWNER
       : document.getUserLevel(game.user);
-    return {
+    let newOptions = {
       isGM: game.user.isGM,
       isOwned: document.parent ? true : false,
       editable: editable,
@@ -16,15 +16,10 @@ export class RdDSheetUtility {
       isObserver: userRightLevel >= CONST.DOCUMENT_OWNERSHIP_LEVELS.OBSERVER,
       isOwner: userRightLevel >= CONST.DOCUMENT_OWNERSHIP_LEVELS.OWNER
     }
-  }
-
-  static mergeDocumentRights(options, document, editable) {
-    const newOptions = RdDSheetUtility.getOptions(document, editable);
     foundry.utils.mergeObject(options, newOptions);
     return options;
   }
 
-
   static getItem(event, actor) {
     return actor.items.get(RdDSheetUtility.getItemId(event))
   }

package.json

@@ -1,6 +1,7 @@
 {
   "scripts": {
     "build": "npx vite build",
+    "run": "npx vite serve",
     "packCompendiumsToDist": "node ./tools/packCompendiumsToDist.mjs",
     "packCompendiumsToPublic": "node ./tools/packCompendiumsToPublic.mjs",
     "unpackCompendiumsFromPublic": "node ./tools/unpackCompendiumsFromPublic.mjs"

styles/simple.css

@@ -28,9 +28,6 @@
     font-weight: normal;
     font-style: normal;
 }
-body {
-  --input-height: 1.4rem;
-}
 :root {
 /* =================== 1. ACTOR SHEET FONT STYLES =========== */
   --window-header-title-font-family: CaslonAntique;
@@ -734,36 +731,10 @@ input:is(.blessure-premiers_soins, .blessure-soins_complets) {
 .flex-grow-3 {
   flex-grow: 3;
 }
-fieldset {
+
-  border-style: groove;
+.editor.prosemirror {
-  border-width: 0.1rem;
-  padding-inline: 0.2rem;
-  padding-block: 0.1rem;
-  margin-inline: 0.1rem;
-  margin-block: 0.1rem;
-}
-form.application.sheet.fvtt-rdd fieldset :is(label, input) {
-  font-family: CaslonAntique;
-  text-align: justify;
-  font-size: 1rem;
-  letter-spacing: 1px;
-}
-form.application.sheet.fvtt-rdd div.form-group {
-  clear: both;
-  display: flex;
-  flex-direction: row;
-  flex-wrap: wrap;
-  margin: 0.1rem 0;
-  align-items: center;
-}
-form.application.sheet.fvtt-rdd .editor.prosemirror {
   height: fit-content;
-  min-height: 5rem;
+  min-height: 20rem;
-}
-form.application.sheet.fvtt-rdd prose-mirror.prosemirror .editor-container {
-  min-height: 5rem;
-  height: fit-content;
-  margin: 0;
 }
 .large-editor {
   border: 2;
@@ -771,7 +742,6 @@ form.application.sheet.fvtt-rdd prose-mirror.prosemirror .editor-container {
   min-height: 12rem;
   padding: 0 3px;
 }
-
 .editor {
   border: 2;
   height: fit-content;
@@ -795,7 +765,6 @@ form.application.sheet.fvtt-rdd prose-mirror.prosemirror .editor-container {
 .foundryvtt-reve-de-dragon.sheet :is(.large-editor,.editor,.medium-editor,.small-editor){
   align-items: start;
 }
-
 .foundryvtt-reve-de-dragon.sheet :is(.large-editor,.editor,.medium-editor,.small-editor) .editor.prosemirror{
   align-items: normal;
 }

system.json

@@ -1,9 +1,9 @@
 {
   "id": "foundryvtt-reve-de-dragon",
   "title": "Rêve de Dragon",
-  "version": "12.0.38",
+  "version": "12.0.44",
-  "download": "https://www.uberwald.me/gitea/public/foundryvtt-reve-de-dragon/releases/download/12.0.38/rddsystem.zip",
+  "download": "https://www.uberwald.me/gitea/public/foundryvtt-reve-de-dragon/releases/download/12.0.44/rddsystem.zip",
-  "manifest": "https://www.uberwald.me/gitea/public/foundryvtt-reve-de-dragon/releases/download/12.0.38/system.json",
+  "manifest": "https://www.uberwald.me/gitea/public/foundryvtt-reve-de-dragon/releases/download/12.0.44/system.json",
   "changelog": "https://www.uberwald.me/gitea/public/foundryvtt-reve-de-dragon/raw/branch/v11/changelog.md",
   "compatibility": {
     "minimum": "11",

template.json

@@ -742,6 +742,9 @@
     "objet": {
       "templates": ["description", "equipement", "inventaire"]
     },
+    "monnaie": {
+      "templates": ["description", "inventaire"]
+    },
     "gemme": {
       "templates": ["description", "enchantable", "inventaire", "temporel"],
       "type": "",

templates/actor/xp-competences.hbs

@@ -1,15 +1,18 @@
 <div>
   <ul class="item-list">
-    <li class="item flexrow">
+    <li class="flexrow">
       <label class="derivee-label" for="system.compteurs.experience.value">Stress transformé</label>
       {{#if options.vueDetaillee}}
-      <input class="derivee-value" type="number" name="system.compteurs.experience.value" value="{{system.compteurs.experience.value}}" data-dtype="number" size="3"/>
+      <input class="resource-content"
+        type="text" data-dtype="Number" size="3"
+        name="system.compteurs.experience.value"
+        value="{{system.compteurs.experience.value}}"/>
       {{else}}
       <label name="system.compteurs.experience.value">{{system.compteurs.experience.value}}</label>
       {{/if}}
     </li>
     {{#if options.vueDetaillee}}
-    <li class="item flexrow">
+    <li class="flexrow">
       <span class="generic-label">Total XP compétences</span>
       <span class="competence-value">{{calc.competenceXPTotal}}</span>
     </li>

templates/chat-resultat-lecture-signedraconique.hbs

@@ -4,7 +4,7 @@
 <hr>
 <div>
   {{#if rolled.isSuccess}}
-  {{alias}} a gagné {{xpSort}} points d'expérience en sorts dans la {{competence.name}}.
+  {{alias}} a gagné {{xpSort}} points d'expérience en sorts en {{competence.name}}.
   {{else}}
   {{alias}} n'a pas pu interpréter le signe draconique.
   {{/if}}

templates/sheets/item/common/header.hbs

@@ -1,6 +0,0 @@
-<header class="sheet-header">
-    <img class="profile-img" src="{{item.img}}" data-edit="img" data-tooltip="{{item.name}}"/>
-    <div class="header-fields">
-        <h1 class="charname"><input name="name" type="text" value="{{item.name}}" placeholder="Name"/></h1>
-    </div>
-</header>

templates/sheets/item/common/template-description.hbs

@@ -1,21 +0,0 @@
-<fieldset>
-<div>
-  <label>Description :</label>
-    {{formInput
-      systemFields.description 
-      enriched=enriched.description
-      value=system.description
-      name="system.description"
-      toggled=true}}
-</div>
-{{#if options.isGM}}
-<div>
-  <label>Description (MJ seulement):</label>
-    {{formInput
-      systemFields.descriptionmj
-      enriched=enriched.descriptionmj
-      value=system.descriptionmj
-      name="system.descriptionmj" toggled=true}}
-</div>
-{{/if}}
-</fieldset>

templates/sheets/item/common/template-inventaire.hbs

@@ -1,6 +0,0 @@
-<fieldset>
-  {{formField systemFields.qualite value=system.qualite}}
-  {{formField systemFields.encombrement value=system.encombrement}}
-  {{formField systemFields.quantite value=system.quantite}}
-  {{formField systemFields.cout value=system.cout}}
-</fieldset>

templates/sheets/item/monnaie.hbs

@@ -1,6 +0,0 @@
-<section>
-  {{> "systems/foundryvtt-reve-de-dragon/templates/sheets/item/common/header.hbs"}}
-
-  {{>"systems/foundryvtt-reve-de-dragon/templates/sheets/item/common/template-inventaire.hbs"}}
-  {{>"systems/foundryvtt-reve-de-dragon/templates/sheets/item/common/template-description.hbs"}}
-</section>