uberwald/vermine2047
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

code review: fix critical issues and improve code quality

Browse Source 
- Fix constructor in rollDialog.mjs (spread operator for options)
- Remove all console.log statements from production code
- Add comprehensive JSDoc comments for all public APIs
- Convert French comments to English for consistency
- Use parseInt with radix parameter (10) throughout
- Replace let with const where appropriate
- Use Set for O(1) lookups in group-link.mjs methods
- Use spread operators for array cloning
- Optimize removeActorFromAllGroups with Set lookups
- Improve registerHooks with better comments and Set usage
- Simplify roll-message.hbs template logic
- Fix duplicate VERMINE key in lang/fr.json
- Add missing error translations
- Add .eslintrc.js with FoundryVTT-compatible linting config

Compatibility: FoundryVTT v11-v14

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This commit is contained in:
LeRatierBretonnier
2026-06-04 13:33:58 +02:00
parent 716c1b49ae
commit 386d80639c
6 changed files with 1078 additions and 591 deletions
Download Patch File Download Diff File Expand all files Collapse all files
templates/roll-message.hbs
+50 -67
View File
@@ -1,78 +1,61 @@
<div class="vermine-roll-message">
{{log this}}
<h3>{{param.actor.name}} : test de {{param.rollLabel}}</h3>
<h3>{{param.actor.name}} : {{localize "VERMINE.test_of"}} {{param.rollLabel}}</h3>
<div class="flexrow">
<h4>difficulté</h4>
<h4>{{localize "VERMINE.difficulty"}}:</h4>
<span id="difficulty">{{param.difficulty}}</span>
</div>
<div class="reroll-fromroll">
<h4>relances possibles : <span id="allowed_reroll">{{param.Reroll}}</span></h4>
<div class="reroll flexrow">
<div class="reroll-from-effort flexrow">
<h4>{{localize "VERMINE.rerolls_possible"}} : <span id="allowed_reroll">{{param.Reroll}}</span></h4>
<div class="reroll flexrow">
<div class="reroll-from-effort flexrow">
<h4 class="flexcol">
<span>effort</span>
<span>{{localize "VERMINE.effort"}}</span>
</h4>
<input type="range" min="0"
{{#iflt param.max_effort param.actor.system.attributes.effort.value}}
max="{{param.max_effort}}"
{{/iflt}}
{{#iflteq param.actor.system.attributes.effort.value param.max_effort }}
max="{{param.actor.system.attributes.effort.value}}"
{{/iflteq}}
value="0"
id="effort-reroll">
</input>
<button class="grant-reroll" data-tooltip="s'accorder des relances"> <span id="granted-reroll">0</span> </button>
</div>
</div>
</div>
<ul class="flexrow roll-results initial-roll"
data-difficulty="{{param.difficulty}}">
{{#each roll.dice as |dieType index|}}
{{#each dieType.results as |die index|}}
<li class="roll die flexcol
{{#if die.success}}
success
{{/if}}
{{#ifincludes dieType.options.flavor "adapted"}}
adapted
{{/ifincludes}}
{{#ifincludes dieType.options.flavor "regular"}}
regular
{{/ifincludes}}
{{#ifincludes dieType.options.flavor "human"}}
human
{{/ifincludes}}
"
data-dice-type="
{{#ifincludes dieType.options.flavor "adapted"}}
adapted
{{/ifincludes}}
{{#ifincludes dieType.options.flavor "regular"}}
regular
{{/ifincludes}}
{{#ifincludes dieType.options.flavor "human"}}
human
{{/ifincludes}}">
<span>{{die.result}}</span>
</li>
{{/each}}
{{/each}}
</ul>
<div class="roll-total flexrow">
<div class="flexcol">
<h4>nombre de succès :</h4>
<span id="total">{{roll._total}}</span>
</div>
<div class="flexcol">
<h4>succès <br> requis :</h4>
<span id="total">{{param.handicap}}</span>
<input type="range"
min="0"
max="{{param.max_effort}}"
value="0"
id="effort-reroll">
</input>
<button class="grant-reroll" data-tooltip="{{localize 'VERMINE.grant_reroll'}}">
<span id="granted-reroll">0</span>
</button>
</div>
</div>
</div>
<ul class="flexrow roll-results initial-roll" data-difficulty="{{param.difficulty}}">
{{#each roll.dice as |dieType index|}}
{{#each dieType.results as |die index|}}
{{! Determine dice class and type based on flavor }}
{{#ifincludes dieType.options.flavor "human"}}
{{set diceClass="human"}}
{{set diceTypeVal="human"}}
{{else ifincludes dieType.options.flavor "adapted"}}
{{set diceClass="adapted"}}
{{set diceTypeVal="adapted"}}
{{else}}
{{set diceClass="regular"}}
{{set diceTypeVal="regular"}}
{{/ifincludes}}
<li class="roll die flexcol {{diceClass}} {{#if die.success}}success{{/if}}"
data-dice-type="{{diceTypeVal}}">
<span>{{die.result}}</span>
</li>
{{/each}}
{{/each}}
</ul>
<div class="roll-total flexrow">
<div class="flexcol">
<h4>{{localize "VERMINE.success_count"}}:</h4>
<span id="total">{{roll._total}}</span>
</div>
<div class="flexcol">
<h4>{{localize "VERMINE.success_required"}}:</h4>
<span id="required">{{param.handicap}}</span>
</div>
</div>
</div>