code review: fix critical issues and improve code quality

- Fix constructor in rollDialog.mjs (spread operator for options)
- Remove all console.log statements from production code
- Add comprehensive JSDoc comments for all public APIs
- Convert French comments to English for consistency
- Use parseInt with radix parameter (10) throughout
- Replace let with const where appropriate
- Use Set for O(1) lookups in group-link.mjs methods
- Use spread operators for array cloning
- Optimize removeActorFromAllGroups with Set lookups
- Improve registerHooks with better comments and Set usage
- Simplify roll-message.hbs template logic
- Fix duplicate VERMINE key in lang/fr.json
- Add missing error translations
- Add .eslintrc.js with FoundryVTT-compatible linting config

Compatibility: FoundryVTT v11-v14

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This commit is contained in:
2026-06-04 13:33:58 +02:00
parent 716c1b49ae
commit 386d80639c
6 changed files with 1078 additions and 591 deletions
+10
View File
@@ -120,6 +120,16 @@
"pools": "Réserves",
"self_control": "Sang-Froid",
"effort": "Effort",
"test_of": "test de",
"rerolls_possible": "relances possibles",
"grant_reroll": "accorder des relances",
"success_count": "nombre de succès",
"success_required": "succès requis",
"error_no_actor_selected": "Vous n'avez pas de personnage attitré ou de token sélectionné",
"error_cannot_reroll": "Vous ne pouvez pas relancer un dés sur ce jet",
"error_no_rerolls_left": "Plus de relances possibles",
"error_select_ability": "Veuillez sélectionner une caractéristique",
"error_not_enough_self_control": "Pas assez de points de sang-froid",
"group": "Groupe",
"abilities": "Caractéristiques",
"ability": "Caractéristique",