uberwald
ea2c2ea093
Security & Quality Improvements:
- Fix XSS vulnerabilities in PresetImportDialog, PresetExportDialog, and templates
- Add resource leak protection in downloadExportFile() with try/finally
- Fix encapsulation violation by using public API instead of _presetsCache
- Add rollback mechanism for partial failures in replace mode
- Add preset name validation (length, characters, empty check)
- Add duplicate name detection within import files
- Add file size validation (5MB limit) and type validation
- Fix event listener leaks with proper cleanup in _onRender/_onClose
- Add constructor parameter validation for all dialogs
Acceptance Criteria Compliance:
- Fix AC-2: Export filename now uses world name (via parent.name)
- Fix AC-6: Error message matches spec exactly ('Import failed: invalid JSON format')
- Fix AC-8: Merge/Replace messages match spec format
Code Quality:
- Add shared HTML escaping utilities (src/utils/html.js)
- Consolidate duplicate localization strings (removed 28 duplicates from SCRYING_POOL)
- Use SCENE_PRESET_VERSION constant instead of hardcoded 1
- Handle null options in importPresets()
- Graceful handling of skipValidation with invalid data
Test Results: 679 passed, 3 failed (pre-existing in DirectorsBoard)
Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
91 lines
3.6 KiB
Handlebars
91 lines
3.6 KiB
Handlebars
<div class="sp-dialog-content">
|
|
<p class="sp-import-description">
|
|
{{localize "video-view-manager.presetImport.description"}}
|
|
</p>
|
|
|
|
{{#if hasExistingPresets}}
|
|
<div class="sp-warning-box">
|
|
<i class="fas fa-exclamation-triangle"></i>
|
|
<span>{{localize "video-view-manager.presetImport.existingPresetsWarning" existingPresetCount=existingPresetCount}}</span>
|
|
</div>
|
|
{{/if}}
|
|
|
|
{{!-- File Selection --}}
|
|
<div class="sp-form-group">
|
|
<label class="sp-form-label">{{localize "video-view-manager.presetImport.selectFile"}}</label>
|
|
<div class="sp-file-upload">
|
|
<input type="file" class="sp-file-input" accept=".json" />
|
|
<label class="sp-file-label">
|
|
<i class="fas fa-upload"></i>
|
|
<span class="sp-file-text">{{localize "video-view-manager.presetImport.chooseFile"}}</span>
|
|
</label>
|
|
</div>
|
|
{{#if selectedFileName}}
|
|
<div class="sp-file-selected">
|
|
<i class="fas fa-check-circle"></i>
|
|
<span>{{selectedFileName}}</span>
|
|
</div>
|
|
{{/if}}
|
|
</div>
|
|
|
|
{{!-- Mode Selection --}}
|
|
<div class="sp-form-group">
|
|
<label class="sp-form-label">{{localize "video-view-manager.presetImport.importMode"}}</label>
|
|
<div class="sp-radio-group">
|
|
<label class="sp-radio-label">
|
|
<input type="radio" name="import-mode" class="sp-mode-merge" value="merge" {{checked (eq mode "merge")}} />
|
|
<span class="sp-radio-text">{{mergeLabel}}</span>
|
|
<span class="sp-radio-hint">{{localize "video-view-manager.presetImport.importModeMergeHint"}}</span>
|
|
</label>
|
|
<label class="sp-radio-label">
|
|
<input type="radio" name="import-mode" class="sp-mode-replace" value="replace" {{checked (eq mode "replace")}} />
|
|
<span class="sp-radio-text">{{replaceLabel}}</span>
|
|
<span class="sp-radio-hint">{{localize "video-view-manager.presetImport.importModeReplaceHint"}}</span>
|
|
</label>
|
|
</div>
|
|
</div>
|
|
|
|
{{!-- Preview Section --}}
|
|
{{#if previewItems.length}}
|
|
<div class="sp-preview-section">
|
|
<h3 class="sp-preview-title">{{localize "video-view-manager.presetImport.previewTitle"}}</h3>
|
|
<ul class="sp-preview-list">
|
|
{{#each previewItems as |item|}}
|
|
<li class="sp-preview-item {{unless item.valid 'sp-preview-item--invalid'}}">
|
|
<i class="fas {{if item.valid 'fa-check-circle sp-valid' 'fa-exclamation-circle sp-invalid'}}"></i>
|
|
<span class="sp-preview-name">{{item.name}}</span>
|
|
{{#if item.error}}
|
|
<span class="sp-preview-error" title="{{item.error}}">{{item.error}}</span>
|
|
{{/if}}
|
|
</li>
|
|
{{/each}}
|
|
</ul>
|
|
</div>
|
|
{{/if}}
|
|
|
|
{{!-- Confirmation Section (shown for replace mode) --}}
|
|
{{#if requiresConfirmation}}
|
|
<div class="sp-confirmation-section">
|
|
<div class="sp-confirmation-warning">
|
|
<i class="fas fa-exclamation-triangle"></i>
|
|
<span>{{localize "video-view-manager.presetImport.replaceConfirmation" existingPresetCount=existingPresetCount}}</span>
|
|
</div>
|
|
</div>
|
|
{{/if}}
|
|
</div>
|
|
|
|
<div class="sp-dialog-buttons">
|
|
{{#unless requiresConfirmation}}
|
|
<button type="button" class="sp-btn sp-btn-primary sp-import-btn" {{disabled (not previewItems.length) }}>
|
|
<i class="fas fa-file-import"></i> {{localize "video-view-manager.presetImport.import"}}
|
|
</button>
|
|
{{else}}
|
|
<button type="button" class="sp-btn sp-btn-danger sp-confirm-btn">
|
|
<i class="fas fa-check"></i> {{localize "video-view-manager.presetImport.confirmReplace"}}
|
|
</button>
|
|
{{/unless}}
|
|
<button type="button" class="sp-btn sp-btn-secondary sp-cancel-btn">
|
|
{{localize "video-view-manager.presetImport.cancel"}}
|
|
</button>
|
|
</div>
|