Module cleanup and tests

templates/player-privacy-panel.hbs

@@ -1,9 +1,5 @@
 {{!-- Player Privacy Panel --}}
 <div class="player-privacy-panel__container">
-  <header class="player-privacy-panel__header">
-    <h2 class="player-privacy-panel__title">{{title}}</h2>
-  </header>
-
   <div class="player-privacy-panel__body">
     {{#if isReadOnly}}
     <div class="player-privacy-panel__notice player-privacy-panel__notice--readonly">
@@ -15,7 +11,7 @@
       <h3 class="player-privacy-panel__section-header">{{sectionHeader}}</h3>
       
       <p class="player-privacy-panel__section-description">
-        {{SCRYING_POOL.PrivacyPanel.sectionDescription}}
+        {{localize "SCRYING_POOL.PrivacyPanel.sectionDescription"}}
       </p>
 
       <div class="player-privacy-panel__effects-list">
@@ -24,18 +20,22 @@
           <div class="player-privacy-panel__effect-header">
             <h4 class="player-privacy-panel__effect-label">{{label}}</h4>
             <div class="player-privacy-panel__toggle">
-              <label class="player-privacy-panel__toggle-label">
+              <label class="player-privacy-panel__toggle-label"
+                     data-tooltip="{{description}}">
                 <input 
                   type="checkbox" 
                   {{#if enabled}}checked{{/if}}
                   {{#if ../isReadOnly}}disabled{{/if}}
                   data-setting="{{settingKey}}"
                   class="player-privacy-panel__toggle-input"
+                  aria-label="{{label}}"
                 >
                 <span class="player-privacy-panel__toggle-text">
                   {{#if enabled}}
+                    <i class="fas fa-check" aria-hidden="true"></i>
                     {{../toggleOnLabel}}
                   {{else}}
+                    <i class="fas fa-times" aria-hidden="true"></i>
                     {{../toggleOffLabel}}
                   {{/if}}
                 </span>
@@ -64,7 +64,10 @@
 
         {{#unless isReadOnly}}
         <div class="player-privacy-panel__portrait-actions">
-          <button type="button" class="player-privacy-panel__portrait-choose sp-btn sp-btn--primary">
+          <button type="button" 
+                  class="player-privacy-panel__portrait-choose sp-btn sp-btn--primary"
+                  data-tooltip="{{chooseImageLabel}}">
+            <i class="fas fa-image" aria-hidden="true"></i>
             {{chooseImageLabel}}
           </button>
           <input 
@@ -74,7 +77,10 @@
             style="display: none;"
           >
           {{#if hasCustomPortrait}}
-          <button type="button" class="player-privacy-panel__portrait-remove sp-btn sp-btn--secondary">
+          <button type="button" 
+                  class="player-privacy-panel__portrait-remove sp-btn sp-btn--secondary"
+                  data-tooltip="{{removeImageLabel}}">
+            <i class="fas fa-trash-alt" aria-hidden="true"></i>
             {{removeImageLabel}}
           </button>
           {{/if}}