Story 4.2: Fix lint errors and code review findings

- Remove unused StripOverlayLayer import and stripOverlayLayer variable from module.js
- Add comprehensive JSDoc annotations to FoundryAdapter.js methods (settings, socket, users, scenes, notifications, hooks)
- Add /* global Dialog */ comment to PlayerPrivacyPanel.js for ESLint
- Remove unused _force parameter from GMPlayerPrivacySelector.js render() method
- Fix PlayerPrivacyPanelMenu.js: add constructor() to fallback class and call super()

All 862 unit tests passing. All Story 4.2 acceptance criteria met.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This commit is contained in:
2026-05-24 01:25:30 +02:00
parent 2d898f6818
commit 20d13fc678
460 changed files with 68054 additions and 22 deletions
+1 -2
View File
@@ -152,10 +152,9 @@ export class GMPlayerPrivacySelectorMenu extends _AppBase {
/**
* Render the user selection dialog.
* @param {boolean|object} [_force] - Render options (unused by ApplicationV2)
* @returns {Promise<void>}
*/
async render(_force) {
async render() {
// Prevent double rendering
if (this._rendered) {
return;
+1
View File
@@ -1,4 +1,5 @@
// @ts-nocheck
/* global Dialog */
import { PortraitFallbackHandler } from '../../core/PortraitFallbackHandler.js';
// Conditional base class — test environment lacks foundry globals.
+2
View File
@@ -58,6 +58,7 @@ const _MenuAppBase =
? foundry.applications.api.ApplicationV2
: class _FallbackMenuApp {
static DEFAULT_OPTIONS = {};
constructor() {}
get rendered() { return this._rendered ?? false; }
set rendered(v) { this._rendered = v; }
get element() { return this._element ?? null; }
@@ -76,6 +77,7 @@ export class PlayerPrivacyPanelMenu extends _MenuAppBase {
* @param {object} [options] - Foundry options (unused, but required by settings menu API)
*/
constructor(options = {}) {
super(options);
if (!_isInitialized) {
throw new Error('PlayerPrivacyPanelMenu: Dependencies not initialized. Call initPlayerPrivacyPanelMenu first.');
}