Story 4.2: Fix lint errors and code review findings

- Remove unused StripOverlayLayer import and stripOverlayLayer variable from module.js
- Add comprehensive JSDoc annotations to FoundryAdapter.js methods (settings, socket, users, scenes, notifications, hooks)
- Add /* global Dialog */ comment to PlayerPrivacyPanel.js for ESLint
- Remove unused _force parameter from GMPlayerPrivacySelector.js render() method
- Fix PlayerPrivacyPanelMenu.js: add constructor() to fallback class and call super()

All 862 unit tests passing. All Story 4.2 acceptance criteria met.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This commit is contained in:
2026-05-24 01:25:30 +02:00
parent 2d898f6818
commit 20d13fc678
460 changed files with 68054 additions and 22 deletions
@@ -0,0 +1,41 @@
# Product Brief Template
A flexible starting structure for the executive product brief. Adapt aggressively to the product, the purpose, and the domain. Drop sections that do not earn their place, add sections the product needs, reorder freely. The brief serves the product's story, not the template's shape.
## Default Structure
```markdown
# Product Brief: {Product Name}
## Executive Summary
[2-3 paragraph narrative: what this is, what problem it solves, why it matters, why now. Compelling enough to stand alone — if someone reads only this section, they should understand the vision.]
## The Problem
[What pain exists, who feels it, how they cope today, the cost of the status quo. Be specific: real scenarios, real frustrations, real consequences.]
## The Solution
[What is being built, how it solves the problem. Focus on the experience and the outcome, not the implementation.]
## What Makes This Different
[Key differentiators. Why this approach over alternatives, what is the unfair advantage. Be honest. If the moat is execution speed, say so. Do not fabricate technical moats.]
## Who This Serves
[Primary users — vivid but brief. Who they are, what they need, what success looks like for them. Secondary users if relevant.]
## Success Criteria
[How we know this is working. Mix of user success signals and business objectives. Measurable.]
## Scope
[What is in for the first version. What is explicitly out. Keep this tight — boundary document, not a feature list.]
## Vision
[Where this goes if it succeeds. What it becomes in 2-3 years. Inspiring but grounded.]
```