Release v1.10.1

Css fixes and add the ability to have a different name on the custom-compendium

CHANGELOG.md

@@ -1,6 +1,12 @@
 # Changelog
 Date format : day/month/year
 
+## 1.10.1 - 22/08/2023 - Litasa's fixes
+All these changes are thanks to Litasa.
+- Roll-n-Keep dialog now waits for the DiceSoNice animation to finish before displaying the result when re-rolling or exploding dice (!28).
+- Adding the ability to have a different name for the custom-compendium (needed to disable the system embedded ones).
+- Fixes some CSS issues when the font size is not the default (#50, #51 and #52).
+
 ## 1.10.0 - 11/06/2023 - FoundryVTT v11 Compatibility
 __! Be certain to carefully back up any critical user data before installing this update !__
 - Updated the System to FoundryVTT v11.

LICENSE.md

@@ -1,16 +1,14 @@
-# Copyright (c) CC BY-NC-SA 4.0 2020 - 2021 This System is licensed under a Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International License.
+# Copyright (c) CC BY-NC-SA 4.0 2020 - 2023 This System is licensed under a Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International License.
 
 By exercising the Licensed Rights (link below), You accept and agree to be bound by the terms and conditions of this Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International Public License ("Public License"). To the extent this Public License may be interpreted as a contract, You are granted the Licensed Rights in consideration of Your acceptance of these terms and conditions, and the Licensor grants You such rights in consideration of benefits the Licensor receives from making the Licensed Material available under these terms and conditions.
 
 https://creativecommons.org/licenses/by-nc-sa/4.0/
 
-
+# Copyright (c) 2018 - 2023 Fantasy Flight Games. Legend of the Five Rings est TM de Fantasy Flight Games.
-# Copyright (c) 2018 - 2021 Fantasy Flight Games. Legend of the Five Rings est TM de Fantasy Flight Games.
 
 All images, texts and contents are the property of their creator / legal owner.
 
-
+# Copyright (c) 2020 - 2023 Foundry Network
-# Copyright (c) 2020 - 2021 Foundry Network
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

system/lang/en-en.json

@@ -17,6 +17,11 @@
         "CustomTechniques": {
             "Title": "Use custom techniques",
             "Hint": "Add 'Specificity' technique type to serve as a catch-all."
+        },
+        "CustomCompendiumName": {
+            "Title": "Custom Compendium Name",
+            "Hint": "For advanced users that want to change the name of the custom compendiums (Used to disables the embedded ones).",
+            "Notification": "Unable set Custom Compendium: '{name}'. Is it activated and registered with Babele?"
         }
     },
     "TYPES": {

system/lang/es-es.json

@@ -17,6 +17,11 @@
         "CustomTechniques": {
             "Title": "Use custom techniques",
             "Hint": "Add 'Specificity' technique type to serve as a catch-all."
+        },
+        "CustomCompendiumName": {
+            "Title": "Custom Compendium Name",
+            "Hint": "For advanced users that want to change the name of the custom compendiums (Used to disables the embedded ones).",
+            "Notification": "Unable set Custom Compendium: '{name}'. Is it activated and registered with Babele?"
         }
     },
     "TYPES": {

system/lang/fr-fr.json

@@ -17,6 +17,11 @@
         "CustomTechniques": {
             "Title": "Utiliser les techniques personnalisées",
             "Hint": "Ajoute un type de technique 'Particularités' pour servir de fourre-tout."
+        },
+        "CustomCompendiumName": {
+            "Title": "Nom du CustomCompendium",
+            "Hint": "Pour les utilisateurs avancés qui souhaitent modifier le nom du compendium personnalisé (utilisé pour désactiver ceux intégrés).",
+            "Notification": "Impossible de définir le compendium personnalisé : '{name}'. Est-il activé et enregistré auprès de Babele ?"
         }
     },
     "TYPES": {

system/lang/it-it.json

@@ -17,6 +17,11 @@
         "CustomTechniques": {
             "Title": "Usa tecniche custom",
             "Hint": "Aggiunge il tipo 'Speciale' come termine generale."
+        },
+        "CustomCompendiumName": {
+            "Title": "Custom Compendium Name",
+            "Hint": "For advanced users that want to change the name of the custom compendiums (Used to disables the embedded ones).",
+            "Notification": "Unable set Custom Compendium: '{name}'. Is it activated and registered with Babele?"
         }
     },
     "TYPES": {

system/scripts/dice/roll-n-keep-dialog.js

@@ -535,7 +535,7 @@ export class RollnKeepDialog extends FormApplication {
 
         // Show DsN dice for the new roll
         if (game.dice3d !== undefined) {
-            game.dice3d.showForRoll(
+            await game.dice3d.showForRoll(
                 roll,
                 game.user,
                 true,

system/scripts/hooks.js

@@ -6,7 +6,7 @@ export default class HooksL5r5e {
         // Enable embed Babele compendiums only if custom compendium is not found or disabled
         if (
             typeof Babele !== "undefined" &&
-            Babele.get().modules.every((module) => module.module !== "l5r5e-custom-compendiums")
+            Babele.get().modules.every((module) => module.module !== game.settings.get(CONFIG.l5r5e.namespace, "custom-compendium-name"))
         ) {
             Babele.get().setSystemTranslationsDir("babele"); // Since Babele v2.0.7
         }

system/scripts/settings.js

@@ -2,6 +2,8 @@
  * Custom system settings register
  */
 export const RegisterSettings = function () {
+    const isBabeleRegistered = (typeof Babele !== "undefined");
+
     /* ------------------------------------ */
     /* User settings                        */
     /* ------------------------------------ */
@@ -36,6 +38,20 @@ export const RegisterSettings = function () {
         type: Boolean,
         default: false,
     });
+    game.settings.register(CONFIG.l5r5e.namespace, "custom-compendium-name", {
+        name: "SETTINGS.CustomCompendiumName.Title",
+        hint: "SETTINGS.CustomCompendiumName.Hint",
+        scope: "world",
+        config: isBabeleRegistered,
+        requiresReload: true,
+        type: String,
+        default: "l5r5e-custom-compendiums",
+        onChange: (name) => {
+            if (!Babele.get().modules.find((module) => module.module === name)) {
+                ui.notifications.warn(game.i18n.format("SETTINGS.CustomCompendiumName.Notification", { name }), { permanent: true });
+            }
+        }
+    });
 
     /* ------------------------------------ */
     /* Update                               */

system/styles/scss/dices.scss

@@ -118,7 +118,7 @@
 
 // Dice Picker
 .dice-picker-dialog {
-    min-width: 600px;
+    min-width: 35rem;
     min-height: auto;
     // Utility
     * {
@@ -225,6 +225,7 @@
         background: none;
         border: none;
         font-size: large;
+        padding: 0;
 
         &-ring {
             color: #f0f0e0;

system/styles/scss/sheets.scss

@@ -1,11 +1,13 @@
 /** Sheets **/
 &.sheet {
-    min-width: 600px;
+    min-width: 37rem;
+
     label {
         &:hover {
             text-shadow: 0 0 2px $red;
         }
     }
+
     .l5r-buttons-bar {
         display: flex;
         flex: 0 0 100%;
@@ -21,6 +23,7 @@
             margin: 0 0 0 8px;
         }
     }
+
     &.actor {
         .sheet-header {
             h1 {
@@ -44,11 +47,13 @@
             font-size: 1rem;
         }
     }
+
     form {
         display: flex;
         flex-wrap: wrap;
         align-content: flex-start;
     }
+
     .sheet-body {
         flex: 0 0 100%;
         align-items: flex-start;
@@ -84,6 +89,7 @@
             }
         }
     }
+
     section,
     article {
         &.tab[data-tab] {
@@ -93,6 +99,7 @@
             }
         }
     }
+
     .sheet-header {
         flex: 0 0 100%;
         align-items: flex-start;
@@ -575,6 +582,7 @@
             }
         }
     }
+
     article {
         background: $l5r5e-white-light;
         padding: 0.5rem;
@@ -740,6 +748,7 @@
             flex: 0 0 calc(50% - 0.5rem);
         }
     }
+
     .xp,
     .money-wrapper {
         flex: 100%;
@@ -758,6 +767,7 @@
             line-height: 13px;
         }
     }
+
     table {
         font-size: 0.85rem;
         color: $black-light;
@@ -824,6 +834,7 @@
             }
         }
     }
+
     .inventory {
         .items-wrapper {
             h3 {
@@ -918,6 +929,7 @@
             }
         }
     }
+
     nav {
         &.sheet-tabs {
             flex: 100%;

system/styles/scss/ui.scss

@@ -32,8 +32,7 @@ button {
     overflow: initial;
     height: calc(100% - 1.1rem);
     top: 0.2rem;
-    width: 320px;
+    min-width: 20rem;
-    min-width: 40px;
     letter-spacing: 0.1rem;
     position: relative;
     margin-right: 0.5rem;
@@ -172,6 +171,9 @@ button {
         }
     }
     &.collapsed {
+        min-width: 0;
+        width: 3rem !important;
+
         #sidebar-tabs {
             > .item {
                 &.active {

system/system.json

@@ -7,11 +7,11 @@
     "changelog": "https://gitlab.com/teaml5r/l5r5e/-/blob/master/CHANGELOG.md",
     "license": "https://gitlab.com/teaml5r/l5r5e/-/blob/master/LICENSE.md",
     "manifest": "https://gitlab.com/teaml5r/l5r5e/-/raw/master/system/system.json",
-    "download": "https://gitlab.com/teaml5r/l5r5e/-/jobs/artifacts/v1.10.0/raw/l5r5e.zip?job=build",
+    "download": "https://gitlab.com/teaml5r/l5r5e/-/jobs/artifacts/v1.10.1/raw/l5r5e.zip?job=build",
-    "version": "1.10.0",
+    "version": "1.10.1",
     "compatibility": {
         "minimum": 11,
-        "verified": "11.301"
+        "verified": "11.307"
     },
     "manifestPlusVersion": "1.2.0",
     "socket": true,