Merge branch 'dev' into dev_skillslist
# Conflicts: # CHANGELOG.md # system/lang/en-en.json # system/lang/fr-fr.json # system/scripts/actor.js # system/scripts/actors/base-character-sheet.js # system/scripts/combat.js # system/scripts/config.js # system/scripts/dice/dice-picker-dialog.js # system/scripts/dice/roll-n-keep-dialog.js # system/scripts/gm/gm-monitor.js # system/scripts/gm/gm-toolbox.js # system/scripts/hooks.js # system/scripts/items/technique-sheet.js # system/scripts/main-l5r5e.js # system/scripts/migration.js # system/scripts/preloadTemplates.js # system/scripts/settings.js # system/scripts/socket-handler.js # system/styles/l5r5e.css # system/system.json # system/templates/actors/character-sheet.html
This commit is contained in:
@@ -43,16 +43,13 @@ export class ItemL5r5e extends Item {
|
||||
* TODO probably useless if we can add "items" in metadata.embedded, but no clue how to.
|
||||
*
|
||||
* @param {string} embeddedName The name of the embedded Document type
|
||||
* @return {Collection} The Collection instance of embedded Documents of the requested type
|
||||
* @return {DocumentCollection} The Collection instance of embedded Documents of the requested type
|
||||
*/
|
||||
getEmbeddedCollection(embeddedName) {
|
||||
const collectionName = embeddedName === "Item" ? "items" : this.constructor.metadata.embedded[embeddedName];
|
||||
if (!collectionName) {
|
||||
throw new Error(
|
||||
`${embeddedName} is not a valid embedded Document within the ${this.documentName} Document`
|
||||
);
|
||||
if (embeddedName === "Item") {
|
||||
return this.items;
|
||||
}
|
||||
return this[collectionName];
|
||||
return super.getEmbeddedCollection(embeddedName);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -86,7 +83,7 @@ export class ItemL5r5e extends Item {
|
||||
// **** Embed Items, need to get the parents ****
|
||||
const parentItem = this.getItemFromParentId();
|
||||
if (!parentItem) {
|
||||
console.warn(`L5R5E | Embed parentItem not found`);
|
||||
console.warn(`L5R5E | Helpers | Embed parentItem not found`);
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -202,7 +199,7 @@ export class ItemL5r5e extends Item {
|
||||
}
|
||||
|
||||
/**
|
||||
* Add a Embed Item
|
||||
* Add an Embed Item
|
||||
* @param {ItemL5r5e} item Object to add
|
||||
* @param {boolean} save if we save in db or not (used internally)
|
||||
* @param {boolean} newId if we change the id
|
||||
@@ -257,7 +254,7 @@ export class ItemL5r5e extends Item {
|
||||
}
|
||||
|
||||
/**
|
||||
* Update a Embed Item
|
||||
* Update an Embed Item
|
||||
* @param {ItemL5r5e} item Object to add
|
||||
* @param {boolean} save if we save in db or not (used internally)
|
||||
* @return {Promise<string>}
|
||||
|
||||
Reference in New Issue
Block a user