Merge branch 'dev' into dev_skillslist

# Conflicts:
#	CHANGELOG.md
#	system/lang/en-en.json
#	system/lang/fr-fr.json
#	system/scripts/actor.js
#	system/scripts/actors/base-character-sheet.js
#	system/scripts/combat.js
#	system/scripts/config.js
#	system/scripts/dice/dice-picker-dialog.js
#	system/scripts/dice/roll-n-keep-dialog.js
#	system/scripts/gm/gm-monitor.js
#	system/scripts/gm/gm-toolbox.js
#	system/scripts/hooks.js
#	system/scripts/items/technique-sheet.js
#	system/scripts/main-l5r5e.js
#	system/scripts/migration.js
#	system/scripts/preloadTemplates.js
#	system/scripts/settings.js
#	system/scripts/socket-handler.js
#	system/styles/l5r5e.css
#	system/system.json
#	system/templates/actors/character-sheet.html

system/scripts/dice/dice-picker-dialog.js

@@ -176,7 +176,7 @@ export class DicePickerDialog extends FormApplication {
 
         // Difficulty
         if (!options.difficulty || !this.parseDifficulty(options.difficulty)) {
-            this.difficulty = game.settings.get(CONFIG.l5r5e.systemName, "initiative-difficulty-value");
+            this.difficulty = game.settings.get(CONFIG.l5r5e.namespace, "initiative-difficulty-value");
         }
 
         // DifficultyHidden
@@ -201,7 +201,7 @@ export class DicePickerDialog extends FormApplication {
      */
     async refresh() {
         if (this._difficultyHiddenIsLock.option) {
-            this.difficulty = game.settings.get(CONFIG.l5r5e.systemName, "initiative-difficulty-value");
+            this.difficulty = game.settings.get(CONFIG.l5r5e.namespace, "initiative-difficulty-value");
             this.difficultyHidden = false;
         }
         this.render(false);
@@ -246,11 +246,8 @@ export class DicePickerDialog extends FormApplication {
         if (!targetToken) {
             return;
         }
-        if (!(targetToken instanceof TokenDocument) || !targetToken.isOwner) {
-            console.warn(
-                "L5R5E | DP | target rejected : Not a valid TokenDocument instance or permission was denied",
-                targetToken
-            );
+        if (!(targetToken instanceof TokenDocument)) {
+            console.warn("L5R5E | DP | target rejected : Not a valid TokenDocument instance", targetToken);
             return;
         }
         this._target = targetToken;
@@ -308,7 +305,7 @@ export class DicePickerDialog extends FormApplication {
             name: "",
         };
 
-        this.skillCatId = CONFIG.l5r5e.skills.get(skillId);// TODO refacto avec les skill items
+        this.skillCatId = CONFIG.l5r5e.skills.get(skillId); // TODO refacto with skill items
     }
 
     /**
@@ -365,7 +362,7 @@ export class DicePickerDialog extends FormApplication {
      */
     set difficultyHidden(isHidden) {
         // If GM hide, then player choice don't matter
-        this._difficultyHiddenIsLock.gm = game.settings.get(CONFIG.l5r5e.systemName, "initiative-difficulty-hidden");
+        this._difficultyHiddenIsLock.gm = game.settings.get(CONFIG.l5r5e.namespace, "initiative-difficulty-hidden");
         if (this._difficultyHiddenIsLock.gm || this._difficultyHiddenIsLock.option) {
             isHidden = true;
         }

system/scripts/dice/roll-n-keep-dialog.js

@@ -196,21 +196,12 @@ export class RollnKeepDialog extends FormApplication {
             new DragDrop({
                 dragSelector: ".dice.draggable",
                 dropSelector: ".dropbox",
-                permissions: { dragstart: this._canDragStart.bind(this), drop: this._canDragDrop.bind(this) },
+                permissions: { dragstart: this.isEditable, drop: this.isEditable },
                 callbacks: { dragstart: this._onDragStart.bind(this), drop: this._onDropItem.bind(this) },
             }),
         ];
     }
 
-    /**
-     * Define whether a user is able to begin a dragstart workflow for a given drag selector
-     * @param selector	The candidate HTML selector for dragging
-     * @return			Can the current user drag this selector?
-     */
-    _canDragStart(selector) {
-        return this.options.editable;
-    }
-
     /**
      * Callback actions which occur at the beginning of a drag start workflow.
      * @param {DragEvent} event	The originating DragEvent
@@ -544,7 +535,7 @@ export class RollnKeepDialog extends FormApplication {
 
         // Show DsN dice for the new roll
         if (game.dice3d !== undefined) {
-            game.dice3d.showForRoll(
+            await game.dice3d.showForRoll(
                 roll,
                 game.user,
                 true,
@@ -683,7 +674,7 @@ export class RollnKeepDialog extends FormApplication {
         }
 
         // Delete old chat message related to this series
-        if (game.settings.get(CONFIG.l5r5e.systemName, "rnk-deleteOldMessage")) {
+        if (game.settings.get(CONFIG.l5r5e.namespace, "rnk-deleteOldMessage")) {
             if (game.user.isFirstGM) {
                 const message = game.messages.get(msgOldId);
                 if (message) {