Stop some missing propagation

This commit is contained in:
Vlyan
2021-01-05 17:49:38 +01:00
parent 5fb1fbb595
commit 6ef4dd3bde
7 changed files with 33 additions and 2 deletions

View File

@@ -168,6 +168,8 @@ export class BaseSheetL5r5e extends ActorSheet {
// Toggle
html.find(".toggle-on-click").on("click", (event) => {
event.preventDefault();
event.stopPropagation();
const elmt = $(event.currentTarget).data("toggle");
const tgt = html.find("." + elmt);
tgt.hasClass("toggle-active") ? tgt.removeClass("toggle-active") : tgt.addClass("toggle-active");
@@ -180,6 +182,8 @@ export class BaseSheetL5r5e extends ActorSheet {
// *** Dice event on Skills clic ***
html.find(".dice-picker").on("click", (event) => {
event.preventDefault();
event.stopPropagation();
const li = $(event.currentTarget);
new game.l5r5e.DicePickerDialog({
skillId: li.data("skill") || null,
@@ -191,17 +195,25 @@ export class BaseSheetL5r5e extends ActorSheet {
// On focus on one numeric element, select all text for better experience
html.find(".select-on-focus").on("focus", (event) => {
event.preventDefault();
event.stopPropagation();
event.target.select();
});
// *** Items : add, edit, delete ***
html.find(".item-add").on("click", (event) => {
event.preventDefault();
event.stopPropagation();
this._addSubItem(event);
});
html.find(`.item-edit`).on("click", (event) => {
event.preventDefault();
event.stopPropagation();
this._editSubItem(event);
});
html.find(`.item-delete`).on("click", (event) => {
event.preventDefault();
event.stopPropagation();
this._deleteSubItem(event);
});
}

View File

@@ -75,11 +75,14 @@ export class CharacterSheetL5r5e extends BaseSheetL5r5e {
// *** Items : curriculum management ***
html.find(`.item-curriculum`).on("click", (event) => {
event.preventDefault();
event.stopPropagation();
this._switchSubItemCurriculum(event);
});
html.find(`button[name=validate-curriculum]`).on("click", (event) => {
event.preventDefault();
event.stopPropagation();
this.actor.data.data.identity.school_rank = this.actor.data.data.identity.school_rank + 1;
// Update actor
this.actor.update({
data: {
identity: {

View File

@@ -147,6 +147,8 @@ export class TwentyQuestionsDialog extends FormApplication {
// Toggle
html.find(".toggle-on-click").on("click", (event) => {
event.preventDefault();
event.stopPropagation();
const elmt = $(event.currentTarget).data("toggle");
const tgt = html.find("." + elmt);
tgt.hasClass("toggle-active") ? tgt.removeClass("toggle-active") : tgt.addClass("toggle-active");
@@ -179,6 +181,8 @@ export class TwentyQuestionsDialog extends FormApplication {
// Delete a dnd element
html.find(".property-delete").on("click", (event) => {
event.preventDefault();
event.stopPropagation();
const stepKey = $(event.currentTarget).parents(".tq-drag-n-drop").data("step");
const itemId = $(event.currentTarget).parents(".property").data("propertyId");
this._deleteOwnedItem(stepKey, itemId);
@@ -187,6 +191,8 @@ export class TwentyQuestionsDialog extends FormApplication {
// Submit button
html.find("#generate").on("click", async (event) => {
event.preventDefault();
event.stopPropagation();
await this.object.toActor(this.actor, flattenObject(this.cache));
await this.close({ submit: true, force: true });
});