Fix layperson skills ate character creation

- roll-prompt.mjs: explicitly save rollType, actorId, actorName, actorImage
  to rollBase.options so mulligan reroll context reads valid values
- chat-reaction.mjs: replace canRerollDefense/canRerollAttack = false with
  recomputation from updated D30 message — aligns same-client with
  cross-client behavior (new D30 always takes effect, mulligan chain loops)

AGENTS.md

@@ -50,6 +50,14 @@ Fix Grit/Luck defense reaction dialog UX (stacking dialogs, multiple clicks, rev
 - **Import `hasD30Reroll` added** to `utils/combat.mjs`
 - **`bleed` top-level type handler added** to `processD30BonusDice` in `d30.mjs:79-81` — returns `specialEffect: "bleed"` same as combo path, so ranged attack bleed (values 5,10,15) creates reaction message and sets damage button bleed flag.
 
+### Pass 7 — Cross-Client Attack D30 Pre-Processing
+- **BUG FIX: D30 attack bonus processed at source (defense request time) instead of in defense handler** — `chat-reaction.mjs:136-148` now calls `processD30BonusDice` in the defense request button click handler, sends the boosted `attackRoll` and full `d30AttackEffects` result in the defense request. The `createChatMessage` handler at `chat-reaction.mjs:622-626` uses the pre-computed values instead of re-processing (avoids double dice roll and ensures both clients agree on attack value).
+- **Fix ensures cross-client agreement**: Player and GM clients see the same boosted attack roll because it's computed once at attack time and sent via socket, not separately per client in the defense handler.
+- **BUG FIX: `d30AttackEffects` not propagated through `_storeNextDefenseData`** — added `d30AttackEffects` to `nextDefenseData` in `combat.mjs:353-355` so the `createChatMessage` handler finds pre-computed values for same-client path (was silently falling back to legacy dice-roll, causing double boost).
+- **BUG FIX: `d30AttackPrecomputedStale` flag for mulligan rerolls** — added `chat-reaction.mjs:464` flag and check at `chat-reaction.mjs:632-634`. After a mulligan reroll updates `attackD30message`, the stale pre-computed effects are bypassed and the new D30 message is processed fresh via `processD30BonusDice`.
+- **BUG FIX: `_dice-breakdown.hbs` partial never registered** — `loadTemplates([path])` registers partials with the full file path as the Handlebars ID, but the template references it by the short name `chat/dice-breakdown`. Fixed by passing an object `{"chat/dice-breakdown": "path"}` which explicitly sets the partial ID to match the template reference.
+- **SAFETY: do-while loop body wrapped in try/catch** — any exception from `createReactionMessage` calls now logs the error and continues safely instead of silently aborting the handler.
+
 ## Key Decisions
 - **Auto-roll bonus dice without dialog** — matches existing D30=27 (d6E) flow
 - **`buildDefenseReactionButtons` extracts only button-building** — defense while-loop structures differ between same-client and cross-client; merging loops risks behavioral divergence

lethal-fantasy.mjs

@@ -108,11 +108,19 @@ function preLocalizeConfig() {
   }
 }
 
-Hooks.once("ready", function () {
+Hooks.once("ready", async function () {
   console.info("LETHAL FANTASY | Ready")
 
   // Initialiser la table des résultats D30
-  documents.D30Roll.initialize()
+  await documents.D30Roll.initialize()
+
+  // Register Handlebars partials used by chat templates.
+  // The object key is the partial ID referenced in templates (e.g., {{> chat/dice-breakdown}}),
+  // the value is the file path. Using an array would register with the full path as the ID,
+  // which does NOT match the template reference.
+  await foundry.applications.handlebars.loadTemplates({
+    "chat/dice-breakdown": "systems/fvtt-lethal-fantasy/templates/chat/_dice-breakdown.hbs"
+  })
 
   // Saignement piloté par le combat tracker
   _registerBleedingHooks()

module/documents/actor.mjs

@@ -7,8 +7,10 @@ export default class LethalFantasyActor extends Actor {
     if (data instanceof Array) {
       return super.create(data, options);
     }
-    // If the created actor has items (only applicable to duplicated actors) bypass the new actor creation logic
-    if (data.items) {
+    // If the created actor already has items (duplicated or imported) bypass the new actor creation logic.
+    // Use .length check because Foundry V2 initializes data.items as an empty array by default
+    // (truthy), which would incorrectly skip the layperson skill auto-population.
+    if (data.items?.length > 0) {
       let actor = super.create(data, options);
       return actor;
     }

module/documents/roll-prompt.mjs

@@ -570,6 +570,10 @@ export async function prompt(options = {}) {
     rollBase.options.D30result = options.D30result
     rollBase.options.D30message = options.D30message
     rollBase.options.badResult = badResult
+    rollBase.options.rollType = options.rollType
+    rollBase.options.actorId = options.actorId
+    rollBase.options.actorName = options.actorName
+    rollBase.options.actorImage = options.actorImage
     rollBase.options.rollData = foundry.utils.duplicate(rollData)
     rollBase.options.defenderId = options.defenderId
     rollBase.options.defenderTokenId = options.defenderTokenId

module/hooks/chat-reaction.mjs

@@ -66,7 +66,7 @@ Hooks.on("renderChatMessageHTML", (message, html, data) => {
     btn.addEventListener("mouseleave", () => canvas.tokens.releaseAll())
 
     // Gestionnaire pour les boutons de demande de défense
-    btn.addEventListener("click", event => {
+    btn.addEventListener("click", async event => {
       event.preventDefault()
       event.stopPropagation()
 
@@ -140,13 +140,24 @@ Hooks.on("renderChatMessageHTML", (message, html, data) => {
         || (attackerWeapon?.system?.weaponType === "ranged")
         || (rollTargetOptions?.isRangedAttack === true)
 
+      // Process D30 attack bonus at source so both clients get the same boosted value.
+      // The d30BonusRoll chat message is created here (by _rollD30BonusDie inside processD30BonusDice).
+      let d30AttackEffects = null
+      let boostedAttackRoll = attackRoll
+      if (attackD30message && attacker) {
+        d30AttackEffects = await LethalFantasyUtils.processD30BonusDice(attackD30message, "attack", attackNaturalRoll, attacker, true)
+        if (d30AttackEffects.modifier) {
+          boostedAttackRoll = attackRoll + d30AttackEffects.modifier
+        }
+      }
+
       const defenseMsg = {
         type: "requestDefense",
         attackerName,
         attackerId,
         defenderName,
         weaponName,
-        attackRoll,
+        attackRoll: boostedAttackRoll,
         attackWeaponId,
         attackRollType,
         attackRollKey,
@@ -157,7 +168,8 @@ Hooks.on("renderChatMessageHTML", (message, html, data) => {
         damageTier,
         combatantId,
         tokenId,
-        isRanged: isRangedAttack
+        isRanged: isRangedAttack,
+        d30AttackEffects
       }
 
       // Envoyer le message socket à l'utilisateur contrôlant le combatant
@@ -448,8 +460,13 @@ Hooks.on("createChatMessage", async (message) => {
   let d30Bleed = false
   let d30DamageMultiplier = 1
   let d30DrMultiplier = 1
+  // Tracks whether the pre-computed D30 effects are stale (invalidated by a mulligan reroll
+  // that produced a new D30 message). When a reroll updates attackD30message, the original
+  // d30AttackEffects from the defense request no longer apply — the new D30 must be processed.
+  let d30AttackPrecomputedStale = false
 
   do {
+    try {
     mulliganRestart = false
     defenderHandledBonus = false
     attackerHandledBonus = false
@@ -532,9 +549,9 @@ Hooks.on("createChatMessage", async (message) => {
         if (choice === "rerollDefense" && canRerollDefense) {
           const oldDefenseRoll = defenseRoll
           const reroll = await LethalFantasyUtils.rerollConfiguredRoll(defenseRerollContext)
-          canRerollDefense = false
           if (!reroll) continue
           defenseRoll = reroll.options?.rollTotal || reroll.total || oldDefenseRoll
+          try {
             await createReactionMessage(defender, {
               type: "mulligan",
               actorName: defenderName,
@@ -545,12 +562,16 @@ Hooks.on("createChatMessage", async (message) => {
               D30result: reroll.options?.D30result,
               D30message: reroll.options?.D30message
             })
-          // Apply new D30 result on the restart
+          } catch(e) {
+            console.error("Mulligan message creation failed (non-fatal):", e)
+          }
+          // Apply new D30 result on the restart — the new D30 always takes effect,
+          // and if it's another mulligan the reroll button reappears.
           if (reroll.options?.D30message) {
             defenseD30message = reroll.options.D30message
             defenseD30Processed = false
           }
-          // Restart the full comparison so both sides can react to the new roll
+          canRerollDefense = LethalFantasyUtils.hasD30Reroll(defenseD30message)
           mulliganRestart = true
           break
         }
@@ -605,26 +626,42 @@ Hooks.on("createChatMessage", async (message) => {
     // ── D30 bonus dice (attack) — resolved before grit/luck ────────────────
     if (attackD30message && !attackD30Processed) {
       const preD30AttackRoll = attackRollFinal
-      const canDialog = isPrimaryController(attacker)
-      const d30Result = await LethalFantasyUtils.processD30BonusDice(attackD30message, "attack", attackNaturalRoll, attacker, canDialog)
+      const canShow = isPrimaryController(attacker)
+
+      // Use pre-computed D30 effects (processed at attack time in the defense
+      // request handler) to avoid re-rolling dice on the defense handler.
+      // This ensures both clients agree on the boosted attack roll.
+      // When d30AttackPrecomputedStale is true (invalidated by a mulligan reroll),
+      // skip the pre-computed effects and process the new D30 message fresh.
+      const usePrecomputed = !!attackData.d30AttackEffects && !d30AttackPrecomputedStale
+      const d30Result = usePrecomputed
+        ? attackData.d30AttackEffects
+        : await LethalFantasyUtils.processD30BonusDice(attackD30message, "attack", attackNaturalRoll, attacker, canShow)
+      d30AttackPrecomputedStale = false
+
       if (d30Result.modifier) {
+        if (!usePrecomputed) {
+          // Legacy or post-reroll path: bonus was just rolled, apply now
           attackRollFinal += d30Result.modifier
-        if (d30Result.modifier > 0 && canDialog) {
+        }
+        // d30BonusRoll message was created at attack time (pre-processed)
+        // or inside _rollD30BonusDie (legacy). Either way, show the application.
+        if (d30Result.modifier > 0 && canShow) {
           await createReactionMessage(attacker, {type:"d30Bonus", actorName:attackerName, value:d30Result.modifier, side:"attack"})
         }
       }
-      if (d30Result.specialEffect === "flag" && canDialog) {
+      if (d30Result.specialEffect === "flag" && canShow) {
         await createReactionMessage(attacker, {type:"d30Flag", actorName:attackerName, specialName:d30Result.specialName||"Special Effect"})
       }
       if (d30Result.specialEffect === "bleed") {
         d30Bleed = true
-        if (canDialog) {
+        if (canShow) {
           await createReactionMessage(attacker, {type:"d30Bleed", actorName:attackerName})
         }
       }
       if (d30Result.specialEffect === "damageMultiplier") {
         d30DamageMultiplier = d30Result.multiplier
-        if (canDialog) {
+        if (canShow) {
           await createReactionMessage(attacker, {type:"d30DamageMultiplier", actorName:attackerName, value:d30Result.multiplier})
         }
       }
@@ -718,9 +755,9 @@ Hooks.on("createChatMessage", async (message) => {
         if (choice === "rerollAttack" && canRerollAttack && attackRerollContext) {
           const oldAttackRoll = attackRollFinal
           const reroll = await LethalFantasyUtils.rerollConfiguredRoll(attackRerollContext)
-          canRerollAttack = false
           if (!reroll) continue
           attackRollFinal = reroll.options?.rollTotal || reroll.total || oldAttackRoll
+          try {
             await createReactionMessage(attacker, {
               type: "mulligan",
               actorName: attackerName,
@@ -731,12 +768,17 @@ Hooks.on("createChatMessage", async (message) => {
               D30result: reroll.options?.D30result,
               D30message: reroll.options?.D30message
             })
-          // Apply new D30 result on the restart
+          } catch(e) {
+            console.error("Mulligan message creation failed (non-fatal):", e)
+          }
+          // Apply new D30 result on the restart — the new D30 always takes effect,
+          // and if it's another mulligan the reroll button reappears.
           if (reroll.options?.D30message) {
             attackD30message = reroll.options.D30message
             attackD30Processed = false
+            d30AttackPrecomputedStale = true
           }
-          // Restart the full comparison so both sides can react to the new roll
+          canRerollAttack = LethalFantasyUtils.hasD30Reroll(attackD30message)
           mulliganRestart = true
           break
         }
@@ -787,6 +829,10 @@ Hooks.on("createChatMessage", async (message) => {
         mulliganRestart = true
       }
     }
+  } catch(e) {
+    console.error("Defense handler loop error (non-fatal):", e)
+    mulliganRestart = false
+  }
   } while (mulliganRestart)
 
   const shieldDamageReduction = shieldBlocked ? shieldReaction?.damageReduction ?? 0 : 0

module/utils/combat.mjs

@@ -206,6 +206,7 @@ export async function handleAttackBoosted(msg) {
         if (!reroll) continue
         updatedDefenseRoll = reroll.options?.rollTotal || reroll.total || oldDefenseRoll
         let newD30message = reroll.options?.D30message || null
+        try {
           const mulliganContent = await foundry.applications.handlebars.renderTemplate("systems/fvtt-lethal-fantasy/templates/chat/reaction-message.hbs", {
             type: "mulligan",
             actorName: defenderName,
@@ -217,6 +218,9 @@ export async function handleAttackBoosted(msg) {
             D30message: newD30message
           })
           await ChatMessage.create({content: mulliganContent, speaker: ChatMessage.getSpeaker({actor: defender})})
+        } catch(e) {
+          console.error("Mulligan message creation failed (non-fatal):", e)
+        }
         // Process new D30 bonus dice from the reroll
         if (newD30message) {
           defenseD30message = newD30message
@@ -302,6 +306,7 @@ export async function showDefenseRequest(msg) {
   const attackD30result = msg.attackD30result
   const attackD30message = msg.attackD30message
   const attackRerollContext = msg.attackRerollContext
+  const d30AttackEffects = msg.d30AttackEffects
   const combatantId = msg.combatantId
   const tokenId = msg.tokenId
 
@@ -351,6 +356,7 @@ export async function showDefenseRequest(msg) {
       damageTier: msg.damageTier,
       defenderId: defender.id, defenderTokenId,
       ...(msg.attackNaturalRoll !== undefined && { attackNaturalRoll: msg.attackNaturalRoll }),
+      ...(d30AttackEffects !== undefined && { d30AttackEffects }),
       ...(opts.isRanged !== undefined && { isRanged: opts.isRanged })
     }
   }