Better rolls + perks

modules/dark-stars-actor-sheet.js

@@ -38,6 +38,7 @@ export class DarkStarsActorSheet extends ActorSheet {
       system: actorData,
       limited: this.object.limited,
       skills: this.actor.getSkills( ),
+      perks: this.actor.getPerks( ),
       weapons: this.actor.checkAndPrepareEquipments( duplicate(this.actor.getWeapons()) ),
       armors: this.actor.checkAndPrepareEquipments( duplicate(this.actor.getArmors())),
       shields: this.actor.checkAndPrepareEquipments( duplicate(this.actor.getShields())),

modules/dark-stars-actor.js

@@ -202,6 +202,13 @@ export class DarkStarsActor extends Actor {
     DarkStarsUtility.sortArrayObjectsByName(comp)
     return comp
   }
+  
+  /* -------------------------------------------- */
+  getPerks() {
+    let comp = duplicate(this.items.filter(item => item.type == 'perk') || [])
+    DarkStarsUtility.sortArrayObjectsByName(comp)
+    return comp
+  }
 
   /* -------------------------------------------- */
   async equipItem(itemId) {
@@ -567,10 +574,6 @@ export class DarkStarsActor extends Actor {
   rollSkill(skillId) {
     let skill = this.items.get(skillId)
     if (skill) {
-      if (skill.system.islore && skill.system.level == 0) {
-        ui.notifications.warn("You can't use Lore Skills with a SL of 0.")
-        return
-      }
       skill = duplicate(skill)
       this.updateSkill(skill)
       let rollData = this.getCommonRollData()

modules/dark-stars-utility.js

@@ -271,8 +271,11 @@ export class DarkStarsUtility {
     }
     rollData.roll = myRoll
     rollData.diceResult = myRoll.total
-    rollData.isSuccess = rollData.diceResult <= rollData.percentValue
-    rollData.isFailure = rollData.diceResult > rollData.percentValue
+    rollData.isCriticalSuccess = rollData.diceResult <= rollData.skill.derivated.value
+    rollData.isCriticalFailure = rollData.diceResult == 100
+    rollData.isSuccess = rollData.diceResult == 1 || rollData.diceResult <= rollData.percentValue
+    rollData.isFailure = rollData.diceResult == 100 || rollData.diceResult > rollData.percentValue
+    rollData.degrees = Math.floor(rollData.percentValue/10) - Math.floor(rollData.diceResult/10)
 
     let msg = await this.createChatWithRollMode(rollData.alias, {
       content: await renderTemplate(`systems/fvtt-dark-stars/templates/chat/chat-generic-result.hbs`, rollData)