${game.i18n.format("MGT2.Dialog.ConfirmDeleteContent", { name })}
`, + yes: { label: game.i18n.localize("MGT2.Dialog.Yes"), icon: "fas fa-trash" }, + no: { label: game.i18n.localize("MGT2.Dialog.No"), icon: "fas fa-times" }, + rejectClose: false, + modal: true + }); + } + static async #onDeleteItem(event, target) { event.preventDefault(); const li = target.closest("[data-item-id]"); if (!li?.dataset.itemId) return; + const item = this.actor.items.get(li.dataset.itemId); + if (!item) return; + const confirmed = await TravellerCharacterSheet.#confirmDelete(item.name); + if (!confirmed) return; this.actor.deleteEmbeddedDocuments("Item", [li.dataset.itemId]); } static async #onEquipItem(event, target) { event.preventDefault(); const li = target.closest("[data-item-id]"); - const item = this.actor.getEmbeddedDocument("Item", li?.dataset.itemId); + const itemId = li?.dataset.itemId; + if (!itemId) return; + const item = this.actor.items.get(itemId); if (!item) return; await item.update({ "system.equipped": !item.system.equipped }); } @@ -2262,6 +2416,9 @@ class TravellerCharacterSheet extends MGT2ActorSheet { const container = containers.find(x => x._id === this.actor.system.containerView); if (!container) return; + const confirmed = await TravellerCharacterSheet.#confirmDelete(container.name); + if (!confirmed) return; + const containerItems = this.actor.items.filter( x => x.system.hasOwnProperty("container") && x.system.container.id === container._id ); @@ -2296,6 +2453,7 @@ class TravellerCharacterSheet extends MGT2ActorSheet { encumbrance: this.actor.system.states.encumbrance, difficulty: null, damageFormula: null, + isMelee: false, }; const cardButtons = []; @@ -2363,6 +2521,9 @@ class TravellerCharacterSheet extends MGT2ActorSheet { if (itemObj?.system.hasOwnProperty("damage")) { rollOptions.damageFormula = itemObj.system.damage; + if (itemObj.type === "weapon") { + rollOptions.isMelee = itemObj.system.range?.isMelee === true; + } if (itemObj.type === "disease") { if (itemObj.system.subType === "disease") rollOptions.rollTypeName = game.i18n.localize("MGT2.DiseaseSubType.disease"); @@ -2427,13 +2588,13 @@ class TravellerCharacterSheet extends MGT2ActorSheet { rollModifiers.push(game.i18n.localize("MGT2.Actor.Fatigue") + " -2"); } - if (userRollData.customDM) { - const s = userRollData.customDM.trim(); - if (/^[0-9]/.test(s)) rollFormulaParts.push("+"); - rollFormulaParts.push(s); + const customDMVal = parseInt(userRollData.customDM ?? "0", 10); + if (!isNaN(customDMVal) && customDMVal !== 0) { + rollFormulaParts.push(customDMVal > 0 ? `+${customDMVal}` : `${customDMVal}`); + rollModifiers.push(game.i18n.localize("MGT2.RollPrompt.CustomDM") + " " + (customDMVal > 0 ? `+${customDMVal}` : `${customDMVal}`)); } - if (MGT2Helper.hasValue(userRollData, "difficulty")) rollOptions.difficulty = userRollData.difficulty; + if (MGT2Helper.hasValue(userRollData, "difficulty") && userRollData.difficulty !== "") rollOptions.difficulty = userRollData.difficulty; const rollFormula = rollFormulaParts.join(""); if (!Roll.validate(rollFormula)) { @@ -2447,37 +2608,74 @@ class TravellerCharacterSheet extends MGT2ActorSheet { await this.token.combatant.update({ initiative: roll.total }); } + // ── Compute effect and effective damage formula ────────────────────── + let rollSuccess = false; + let rollFailure = false; + let rollEffect = undefined; + let rollEffectStr = undefined; + let difficultyValue = null; + + if (MGT2Helper.hasValue(rollOptions, "difficulty")) { + difficultyValue = MGT2Helper.getDifficultyValue(rollOptions.difficulty); + rollEffect = roll.total - difficultyValue; + rollEffectStr = (rollEffect >= 0 ? "+" : "") + rollEffect; + rollSuccess = rollEffect >= 0; + rollFailure = !rollSuccess; + } + + // Build effective damage formula: base + effect + STR DM (melee) + let effectiveDamageFormula = rollOptions.damageFormula || null; + if (effectiveDamageFormula) { + if (rollEffect !== undefined && rollEffect !== 0) { + effectiveDamageFormula += (rollEffect >= 0 ? "+" : "") + rollEffect; + } + if (rollOptions.isMelee) { + const strDm = this.actor.system.characteristics.strength?.dm ?? 0; + if (strDm !== 0) effectiveDamageFormula += (strDm >= 0 ? "+" : "") + strDm; + } + } + + // ── Build roll breakdown tooltip ───────────────────────────────────── + const diceRawTotal = roll.dice.reduce((s, d) => s + d.total, 0); + const breakdownParts = [game.i18n.localize("MGT2.Chat.Roll.Dice") + " " + diceRawTotal]; + for (const mod of rollModifiers) breakdownParts.push(mod); + if (rollEffectStr !== undefined) + breakdownParts.push(game.i18n.localize("MGT2.Chat.Roll.Effect") + " " + rollEffectStr); + const rollBreakdown = breakdownParts.join(" | "); + const chatData = { user: game.user.id, speaker: this.actor ? ChatMessage.getSpeaker({ actor: this.actor }) : null, formula: roll._formula, tooltip: await roll.getTooltip(), total: Math.round(roll.total * 100) / 100, + rollBreakdown, showButtons: true, showLifeButtons: false, showRollRequest: false, rollTypeName: rollOptions.rollTypeName, rollObjectName: rollOptions.rollObjectName, rollModifiers: rollModifiers, - showRollDamage: rollOptions.damageFormula !== null && rollOptions.damageFormula !== "", + // Show damage button only if there's a formula AND (no difficulty check OR roll succeeded) + showRollDamage: !!effectiveDamageFormula && (!difficultyValue || rollSuccess), cardButtons: cardButtons, }; if (MGT2Helper.hasValue(rollOptions, "difficulty")) { chatData.rollDifficulty = rollOptions.difficulty; chatData.rollDifficultyLabel = MGT2Helper.getDifficultyDisplay(rollOptions.difficulty); - if (roll.total >= MGT2Helper.getDifficultyValue(rollOptions.difficulty)) - chatData.rollSuccess = true; - else - chatData.rollFailure = true; + chatData.rollEffect = rollEffect; + chatData.rollEffectStr = rollEffectStr; + chatData.rollSuccess = rollSuccess || undefined; + chatData.rollFailure = rollFailure || undefined; } const html = await foundry.applications.handlebars.renderTemplate("systems/mgt2/templates/chat/roll.html", chatData); chatData.content = html; let flags = null; - if (rollOptions.damageFormula) { - flags = { mgt2: { damage: { formula: rollOptions.damageFormula, rollObjectName: rollOptions.rollObjectName, rollTypeName: rollOptions.rollTypeName } } }; + if (effectiveDamageFormula) { + flags = { mgt2: { damage: { formula: effectiveDamageFormula, rollObjectName: rollOptions.rollObjectName, rollTypeName: rollOptions.rollTypeName } } }; } if (cardButtons.length > 0) { if (!flags) flags = { mgt2: {} }; @@ -2548,6 +2746,8 @@ class TravellerCharacterSheet extends MGT2ActorSheet { static async #onTraitDelete(event, target) { event.preventDefault(); + const confirmed = await TravellerCharacterSheet.#confirmDelete(game.i18n.localize("MGT2.Actor.ThisTrait")); + if (!confirmed) return; const element = target.closest("[data-traits-part]"); const index = Number(element.dataset.traitsPart); const traits = foundry.utils.deepClone(this.actor.system.personal.traits); @@ -2564,6 +2764,325 @@ class TravellerCharacterSheet extends MGT2ActorSheet { this.actor.system.personal.speciesText.descriptionLong ); } + + static async #onHeal(event, target) { + event.preventDefault(); + const healType = target.dataset.healType; + + if (canvas.tokens.controlled.length === 0) { + ui.notifications.warn(game.i18n.localize("MGT2.Errors.NoTokenSelected")); + return; + } + + if (healType === "firstaid") { + // Find Medicine skill to pre-select + // Use normalized string matching to handle accents + const medSkill = this.actor.items.find(i => { + if (i.type !== "talent" || i.system.subType !== "skill") return false; + const normalized = i.name.toLowerCase().normalize("NFD").replace(/[\u0300-\u036f]/g, ""); + return normalized.includes("medecin") || normalized.includes("medicine"); + }); + + // Only EDU characteristic available for First Aid + const characteristics = [ + { _id: "education", name: game.i18n.localize("MGT2.Characteristics.education.name") } + ]; + + const rollOptions = { + rollTypeName: game.i18n.localize("MGT2.Healing.FirstAid"), + rollObjectName: this.actor.name, + characteristics: characteristics, // Only EDU + characteristic: "education", // Pre-selected + skill: medSkill?.id ?? "", // Medicine skill ID for pre-selection (must match _id in array) + skillName: medSkill?.name ?? game.i18n.localize("MGT2.Healing.NoMedicineSkill"), // Display name + skillLevel: medSkill?.system.level ?? -3, // -3 if not found + skills: medSkill ? [{ _id: medSkill.id, name: medSkill.name, level: medSkill.system.level }] : [], + difficulty: "Average", // First Aid difficulty is 8 (Average) + showHeal: true, + healType: MGT2.HealingType.FIRST_AID, + }; + const userRollData = await RollPromptHelper.roll(rollOptions); + if (userRollData) { + // Build formula with all DMs — same pattern as standard skill roll + const rollFormulaParts = []; + const rollModifiers = []; + + if (userRollData.diceModifier) { + rollFormulaParts.push("3d6"); + rollFormulaParts.push(userRollData.diceModifier); + } else { + rollFormulaParts.push("2d6"); + } + + if (userRollData.characteristic) { + const c = this.actor.system.characteristics[userRollData.characteristic]; + rollFormulaParts.push(MGT2Helper.getFormulaDM(c.dm)); + rollModifiers.push(game.i18n.localize(`MGT2.Characteristics.${userRollData.characteristic}.name`) + MGT2Helper.getDisplayDM(c.dm)); + } + + if (userRollData.skill && userRollData.skill !== "") { + if (userRollData.skill === "NP") { + rollFormulaParts.push("-3"); + rollModifiers.push(game.i18n.localize("MGT2.Items.NotProficient")); + } else { + const skillObj = this.actor.getEmbeddedDocument("Item", userRollData.skill); + rollFormulaParts.push(MGT2Helper.getFormulaDM(skillObj.system.level)); + rollModifiers.push(skillObj.getRollDisplay()); + } + } + + if (userRollData.customDM && userRollData.customDM !== "") { + let s = userRollData.customDM.trim(); + if (/^[0-9]/.test(s)) rollFormulaParts.push("+"); + rollFormulaParts.push(s); + rollModifiers.push("DM " + s); + } + + const rollFormula = rollFormulaParts.join(""); + const roll = await new Roll(rollFormula, this.actor.getRollData()).roll(); + + // Difficulty for First Aid is Average (8) + const difficulty = 8; + const effect = roll.total - difficulty; + const isSuccess = effect >= 0; + const healing = isSuccess ? Math.max(1, effect) : 0; + + const cardButtons = isSuccess + ? [{ label: game.i18n.localize("MGT2.Healing.ApplyHealing"), action: "healing" }] + : []; + + const chatData = { + user: game.user.id, + speaker: ChatMessage.getSpeaker({ actor: this.actor }), + formula: roll._formula, + tooltip: await roll.getTooltip(), + total: Math.round(roll.total * 100) / 100, + rollTypeName: game.i18n.localize("MGT2.Healing.FirstAid"), + rollObjectName: this.actor.name, + rollModifiers: rollModifiers, + rollDifficulty: difficulty, + rollDifficultyLabel: MGT2Helper.getDifficultyDisplay("Average"), + rollEffectStr: isSuccess ? effect.toString() : undefined, + healingAmount: isSuccess ? healing : undefined, + rollSuccess: isSuccess || undefined, + rollFailure: !isSuccess || undefined, + showButtons: isSuccess, + hasDamage: false, + showRollDamage: false, + cardButtons: cardButtons, + }; + + const html = await foundry.applications.handlebars.renderTemplate("systems/mgt2/templates/chat/roll.html", chatData); + chatData.content = html; + chatData.flags = { mgt2: { healing: { amount: healing } } }; + + return roll.toMessage(chatData); + } + } else if (healType === "surgery") { + // Find Medicine skill to pre-select (same as first aid) + const medSkill = this.actor.items.find(i => { + if (i.type !== "talent" || i.system.subType !== "skill") return false; + const normalized = i.name.toLowerCase().normalize("NFD").replace(/[\u0300-\u036f]/g, ""); + return normalized.includes("medecin") || normalized.includes("medicine"); + }); + + const characteristics = [ + { _id: "education", name: game.i18n.localize("MGT2.Characteristics.education.name") } + ]; + + const rollOptions = { + rollTypeName: game.i18n.localize("MGT2.Healing.Surgery"), + rollObjectName: this.actor.name, + characteristics: characteristics, + characteristic: "education", + skill: medSkill?.id ?? "", + skillName: medSkill?.name ?? game.i18n.localize("MGT2.Healing.NoMedicineSkill"), + skillLevel: medSkill?.system.level ?? -3, + skills: medSkill ? [{ _id: medSkill.id, name: medSkill.name, level: medSkill.system.level }] : [], + difficulty: "Average", + showHeal: true, + healType: MGT2.HealingType.SURGERY, + }; + const userRollData = await RollPromptHelper.roll(rollOptions); + if (userRollData) { + // Build formula with all DMs — same pattern as standard skill roll + const rollFormulaParts = []; + const rollModifiers = []; + + if (userRollData.diceModifier) { + rollFormulaParts.push("3d6"); + rollFormulaParts.push(userRollData.diceModifier); + } else { + rollFormulaParts.push("2d6"); + } + + if (userRollData.characteristic) { + const c = this.actor.system.characteristics[userRollData.characteristic]; + rollFormulaParts.push(MGT2Helper.getFormulaDM(c.dm)); + rollModifiers.push(game.i18n.localize(`MGT2.Characteristics.${userRollData.characteristic}.name`) + MGT2Helper.getDisplayDM(c.dm)); + } + + if (userRollData.skill && userRollData.skill !== "") { + if (userRollData.skill === "NP") { + rollFormulaParts.push("-3"); + rollModifiers.push(game.i18n.localize("MGT2.Items.NotProficient")); + } else { + const skillObj = this.actor.getEmbeddedDocument("Item", userRollData.skill); + rollFormulaParts.push(MGT2Helper.getFormulaDM(skillObj.system.level)); + rollModifiers.push(skillObj.getRollDisplay()); + } + } + + if (userRollData.customDM && userRollData.customDM !== "") { + let s = userRollData.customDM.trim(); + if (/^[0-9]/.test(s)) rollFormulaParts.push("+"); + rollFormulaParts.push(s); + rollModifiers.push("DM " + s); + } + + const rollFormula = rollFormulaParts.join(""); + const roll = await new Roll(rollFormula, this.actor.getRollData()).roll(); + + // Difficulty for Surgery is Average (8) + const difficulty = 8; + const effect = roll.total - difficulty; + const isSuccess = effect >= 0; + + // Success: heal Math.max(1, effect); Failure: patient takes 3 + |effect| damage + const healing = isSuccess ? Math.max(1, effect) : 0; + const surgeryDamage = isSuccess ? 0 : 3 + Math.abs(effect); + + const cardButtons = []; + if (isSuccess) { + cardButtons.push({ label: game.i18n.localize("MGT2.Healing.ApplyHealing"), action: "healing" }); + } else { + cardButtons.push({ label: game.i18n.localize("MGT2.Healing.ApplySurgeryDamage"), action: "surgeryDamage" }); + } + + const chatData = { + user: game.user.id, + speaker: ChatMessage.getSpeaker({ actor: this.actor }), + formula: roll._formula, + tooltip: await roll.getTooltip(), + total: Math.round(roll.total * 100) / 100, + rollTypeName: game.i18n.localize("MGT2.Healing.Surgery"), + rollObjectName: this.actor.name, + rollModifiers: rollModifiers, + rollDifficulty: difficulty, + rollDifficultyLabel: MGT2Helper.getDifficultyDisplay("Average"), + rollEffectStr: effect.toString(), + healingAmount: isSuccess ? healing : undefined, + surgeryDamageAmount: isSuccess ? undefined : surgeryDamage, + rollSuccess: isSuccess || undefined, + rollFailure: !isSuccess || undefined, + showButtons: true, + hasDamage: false, + showRollDamage: false, + cardButtons: cardButtons, + }; + + const html = await foundry.applications.handlebars.renderTemplate("systems/mgt2/templates/chat/roll.html", chatData); + chatData.content = html; + chatData.flags = { mgt2: { surgery: { healing, surgeryDamage } } }; + + return roll.toMessage(chatData); + } + } else if (healType === "medical") { + const result = await CharacterPrompts.openHealingDays(); + if (result) { + const endMD = this.actor.system.characteristics.endurance.dm; + const medSkill = this.actor.items.find(i => + i.type === "talent" && + i.system.subType === "skill" && + (i.name.toLowerCase().includes("medecin") || i.name.toLowerCase().includes("medicine")) + ); + const skillValue = medSkill ? medSkill.system.level : 0; + const days = result.days; + const healingPerDay = Math.max(1, 3 + endMD + skillValue); + const totalHealing = healingPerDay * days; + + const rollModifiers = [ + `3 (base)`, + `${endMD >= 0 ? "+" : ""}${endMD} END`, + `+${skillValue} ${medSkill?.name ?? "Médecine"}`, + `× ${days} ${game.i18n.localize("MGT2.RollPrompt.Days").toLowerCase()}` + ]; + + const templateData = { + rollObjectName: this.actor.name, + rollTypeName: game.i18n.localize("MGT2.Healing.MedicalCare"), + rollModifiers, + formula: `${healingPerDay} ${game.i18n.localize("MGT2.Items.PerDay")}`, + tooltip: "", + total: totalHealing, + rollSuccess: true, + showButtons: true, + cardButtons: [ + { action: "healing", label: game.i18n.localize("MGT2.Healing.ApplyHealing") } + ] + }; + + const content = await renderTemplate( + "systems/mgt2/templates/chat/roll.html", + templateData + ); + await ChatMessage.create({ + user: game.user.id, + speaker: ChatMessage.getSpeaker({ actor: this.actor }), + content, + flags: { mgt2: { healing: { amount: totalHealing } } } + }); + } + } else if (healType === "natural") { + const result = await CharacterPrompts.openHealingDays(); + if (result) { + const endMD = this.actor.system.characteristics.endurance.dm; + let totalAmount = 0; + const rolls = []; + + for (let i = 0; i < result.days; i++) { + const roll = await new Roll("1d6").evaluate(); + const dayHealing = Math.max(1, roll.total + endMD); + rolls.push({ roll, dayHealing }); + totalAmount += dayHealing; + } + + // Build roll details + const rollDisplay = rolls.map((r, idx) => + `${game.i18n.format(\"MGT2.Dialog.ConfirmDeleteContent\", { name })}
`,\n yes: { label: game.i18n.localize(\"MGT2.Dialog.Yes\"), icon: \"fas fa-trash\" },\n no: { label: game.i18n.localize(\"MGT2.Dialog.No\"), icon: \"fas fa-times\" },\n rejectClose: false,\n modal: true\n });\n }\n\n static async #onDeleteItem(event, target) {\n event.preventDefault();\n const li = target.closest(\"[data-item-id]\");\n if (!li?.dataset.itemId) return;\n const item = this.actor.items.get(li.dataset.itemId);\n if (!item) return;\n const confirmed = await TravellerCharacterSheet.#confirmDelete(item.name);\n if (!confirmed) return;\n this.actor.deleteEmbeddedDocuments(\"Item\", [li.dataset.itemId]);\n }\n\n static async #onEquipItem(event, target) {\n event.preventDefault();\n const li = target.closest(\"[data-item-id]\");\n const itemId = li?.dataset.itemId;\n if (!itemId) return;\n const item = this.actor.items.get(itemId);\n if (!item) return;\n await item.update({ \"system.equipped\": !item.system.equipped });\n }\n\n static async #onItemStorageIn(event, target) {\n event.preventDefault();\n const li = target.closest(\"[data-item-id]\");\n const item = this.actor.getEmbeddedDocument(\"Item\", li?.dataset.itemId);\n if (!item) return;\n\n if (item.type === \"container\") {\n await item.update({ \"system.onHand\": false });\n } else {\n const containers = this.actor.getContainers();\n let container;\n const dropInId = this.actor.system.containerDropIn;\n\n if (!dropInId) {\n container = containers.length === 0\n ? await getDocumentClass(\"Item\").create({ name: \"New container\", type: \"container\" }, { parent: this.actor })\n : containers[0];\n } else {\n container = containers.find(x => x._id === dropInId);\n }\n\n if (container?.system.locked && !game.user.isGM) {\n ui.notifications.error(\"Objet verrouillé\");\n return;\n }\n await item.update({ \"system.container.id\": container._id });\n }\n }\n\n static async #onItemStorageOut(event, target) {\n event.preventDefault();\n const li = target.closest(\"[data-item-id]\");\n const item = this.actor.getEmbeddedDocument(\"Item\", li?.dataset.itemId);\n if (!item) return;\n await item.update({ \"system.container.id\": \"\" });\n }\n\n static async #onSoftwareEject(event, target) {\n event.preventDefault();\n const li = target.closest(\"[data-item-id]\");\n const item = this.actor.getEmbeddedDocument(\"Item\", li?.dataset.itemId);\n if (!item) return;\n await item.update({ \"system.software.computerId\": \"\" });\n }\n\n static async #onContainerCreate(event) {\n event.preventDefault();\n const cls = getDocumentClass(\"Item\");\n return cls.create({ name: \"New container\", type: \"container\" }, { parent: this.actor });\n }\n\n static async #onContainerEdit(event) {\n event.preventDefault();\n const container = this.actor.getEmbeddedDocument(\"Item\", this.actor.system.containerView);\n if (container) container.sheet.render(true);\n }\n\n static async #onContainerDelete(event) {\n event.preventDefault();\n const containers = this.actor.getContainers();\n const container = containers.find(x => x._id === this.actor.system.containerView);\n if (!container) return;\n\n const confirmed = await TravellerCharacterSheet.#confirmDelete(container.name);\n if (!confirmed) return;\n\n const containerItems = this.actor.items.filter(\n x => x.system.hasOwnProperty(\"container\") && x.system.container.id === container._id\n );\n\n if (containerItems.length > 0) {\n const updates = containerItems.map(item => ({ _id: item.id, \"system.container.id\": \"\" }));\n await this.actor.updateEmbeddedDocuments(\"Item\", updates);\n }\n\n const actorUpdate = { \"system.containerView\": \"\" };\n if (this.actor.system.containerDropIn === container._id) {\n actorUpdate[\"system.containerDropIn\"] = \"\";\n const remaining = containers.filter(x => x._id !== container._id);\n if (remaining.length > 0) actorUpdate[\"system.containerDropIn\"] = remaining[0]._id;\n }\n\n await this.actor.deleteEmbeddedDocuments(\"Item\", [container._id]);\n await this.actor.update(actorUpdate);\n }\n\n static async #onRoll(event, target) {\n event.preventDefault();\n\n const rollOptions = {\n rollTypeName: game.i18n.localize(\"MGT2.RollPrompt.Roll\"),\n rollObjectName: \"\",\n characteristics: [{ _id: \"\", name: \"\" }],\n characteristic: \"\",\n skills: [],\n skill: \"\",\n fatigue: this.actor.system.states.fatigue,\n encumbrance: this.actor.system.states.encumbrance,\n difficulty: null,\n damageFormula: null,\n isMelee: false,\n };\n\n const cardButtons = [];\n for (const [key, label] of Object.entries(MGT2.Characteristics)) {\n const c = this.actor.system.characteristics[key];\n if (c.show) {\n rollOptions.characteristics.push({\n _id: key,\n name: game.i18n.localize(label) + MGT2Helper.getDisplayDM(c.dm),\n });\n }\n }\n\n for (let item of this.actor.items) {\n if (item.type === \"talent\" && item.system.subType === \"skill\")\n rollOptions.skills.push({ _id: item._id, name: item.getRollDisplay() });\n }\n\n rollOptions.skills.sort(MGT2Helper.compareByName);\n rollOptions.skills = [{ _id: \"NP\", name: game.i18n.localize(\"MGT2.Items.NotProficient\") }].concat(rollOptions.skills);\n\n let itemObj = null;\n let isInitiative = false;\n const rollType = target.dataset.roll;\n\n if (rollType === \"initiative\") {\n rollOptions.rollTypeName = game.i18n.localize(\"MGT2.RollPrompt.InitiativeRoll\");\n rollOptions.characteristic = this.actor.system.config.initiative;\n isInitiative = true;\n } else if (rollType === \"characteristic\") {\n rollOptions.characteristic = target.dataset.rollCharacteristic;\n rollOptions.rollTypeName = game.i18n.localize(\"MGT2.RollPrompt.CharacteristicRoll\");\n rollOptions.rollObjectName = game.i18n.localize(`MGT2.Characteristics.${rollOptions.characteristic}.name`);\n } else {\n if (rollType === \"skill\") {\n rollOptions.skill = target.dataset.rollSkill;\n itemObj = this.actor.getEmbeddedDocument(\"Item\", rollOptions.skill);\n rollOptions.rollTypeName = game.i18n.localize(\"MGT2.RollPrompt.SkillRoll\");\n rollOptions.rollObjectName = itemObj.name;\n } else if (rollType === \"psionic\") {\n rollOptions.rollTypeName = game.i18n.localize(\"MGT2.RollPrompt.PsionicRoll\");\n }\n\n if (itemObj === null && target.dataset.itemId) {\n itemObj = this.actor.getEmbeddedDocument(\"Item\", target.dataset.itemId);\n rollOptions.rollObjectName = itemObj.name;\n if (itemObj.type === \"weapon\") rollOptions.rollTypeName = game.i18n.localize(\"TYPES.Item.weapon\");\n else if (itemObj.type === \"armor\") rollOptions.rollTypeName = game.i18n.localize(\"TYPES.Item.armor\");\n else if (itemObj.type === \"computer\") rollOptions.rollTypeName = game.i18n.localize(\"TYPES.Item.computer\");\n }\n\n if (rollType === \"psionic\" && itemObj) {\n rollOptions.rollObjectName = itemObj.name;\n if (MGT2Helper.hasValue(itemObj.system.psionic, \"duration\")) {\n cardButtons.push({\n label: game.i18n.localize(\"MGT2.Items.Duration\"),\n formula: itemObj.system.psionic.duration,\n message: {\n objectName: itemObj.name,\n flavor: \"{0} \".concat(game.i18n.localize(`MGT2.Durations.${itemObj.system.psionic.durationUnit}`)),\n },\n });\n }\n }\n\n if (itemObj?.system.hasOwnProperty(\"damage\")) {\n rollOptions.damageFormula = itemObj.system.damage;\n if (itemObj.type === \"weapon\") {\n rollOptions.isMelee = itemObj.system.range?.isMelee === true;\n }\n if (itemObj.type === \"disease\") {\n if (itemObj.system.subType === \"disease\")\n rollOptions.rollTypeName = game.i18n.localize(\"MGT2.DiseaseSubType.disease\");\n else if (itemObj.system.subType === \"poison\")\n rollOptions.rollTypeName = game.i18n.localize(\"MGT2.DiseaseSubType.poison\");\n }\n }\n\n if (itemObj?.system.hasOwnProperty(\"roll\")) {\n if (MGT2Helper.hasValue(itemObj.system.roll, \"characteristic\")) rollOptions.characteristic = itemObj.system.roll.characteristic;\n if (MGT2Helper.hasValue(itemObj.system.roll, \"skill\")) rollOptions.skill = itemObj.system.roll.skill;\n if (MGT2Helper.hasValue(itemObj.system.roll, \"difficulty\")) rollOptions.difficulty = itemObj.system.roll.difficulty;\n }\n }\n\n const userRollData = await RollPromptHelper.roll(rollOptions);\n\n const rollModifiers = [];\n const rollFormulaParts = [];\n\n if (userRollData.diceModifier) {\n rollFormulaParts.push(\"3d6\", userRollData.diceModifier);\n } else {\n rollFormulaParts.push(\"2d6\");\n }\n\n if (userRollData.characteristic) {\n const c = this.actor.system.characteristics[userRollData.characteristic];\n rollFormulaParts.push(MGT2Helper.getFormulaDM(c.dm));\n rollModifiers.push(game.i18n.localize(`MGT2.Characteristics.${userRollData.characteristic}.name`) + MGT2Helper.getDisplayDM(c.dm));\n }\n\n if (userRollData.skill) {\n if (userRollData.skill === \"NP\") {\n rollFormulaParts.push(\"-3\");\n rollModifiers.push(game.i18n.localize(\"MGT2.Items.NotProficient\"));\n } else {\n const skillObj = this.actor.getEmbeddedDocument(\"Item\", userRollData.skill);\n rollFormulaParts.push(MGT2Helper.getFormulaDM(skillObj.system.level));\n rollModifiers.push(skillObj.getRollDisplay());\n }\n }\n\n if (userRollData.psionic) {\n const psionicObj = this.actor.getEmbeddedDocument(\"Item\", userRollData.psionic);\n rollFormulaParts.push(MGT2Helper.getFormulaDM(psionicObj.system.level));\n rollModifiers.push(psionicObj.getRollDisplay());\n }\n\n if (userRollData.timeframes && userRollData.timeframes !== \"\" && userRollData.timeframes !== \"Normal\") {\n rollModifiers.push(game.i18n.localize(`MGT2.Timeframes.${userRollData.timeframes}`));\n rollFormulaParts.push(userRollData.timeframes === \"Slower\" ? \"+2\" : \"-2\");\n }\n\n if (userRollData.encumbrance === true) {\n rollFormulaParts.push(\"-2\");\n rollModifiers.push(game.i18n.localize(\"MGT2.Actor.Encumbrance\") + \" -2\");\n }\n\n if (userRollData.fatigue === true) {\n rollFormulaParts.push(\"-2\");\n rollModifiers.push(game.i18n.localize(\"MGT2.Actor.Fatigue\") + \" -2\");\n }\n\n const customDMVal = parseInt(userRollData.customDM ?? \"0\", 10);\n if (!isNaN(customDMVal) && customDMVal !== 0) {\n rollFormulaParts.push(customDMVal > 0 ? `+${customDMVal}` : `${customDMVal}`);\n rollModifiers.push(game.i18n.localize(\"MGT2.RollPrompt.CustomDM\") + \" \" + (customDMVal > 0 ? `+${customDMVal}` : `${customDMVal}`));\n }\n\n if (MGT2Helper.hasValue(userRollData, \"difficulty\") && userRollData.difficulty !== \"\") rollOptions.difficulty = userRollData.difficulty;\n\n const rollFormula = rollFormulaParts.join(\"\");\n if (!Roll.validate(rollFormula)) {\n ui.notifications.error(game.i18n.localize(\"MGT2.Errors.InvalidRollFormula\"));\n return;\n }\n\n let roll = await new Roll(rollFormula, this.actor.getRollData()).roll({ rollMode: userRollData.rollMode });\n\n if (isInitiative && this.token?.combatant) {\n await this.token.combatant.update({ initiative: roll.total });\n }\n\n // ── Compute effect and effective damage formula ──────────────────────\n let rollSuccess = false;\n let rollFailure = false;\n let rollEffect = undefined;\n let rollEffectStr = undefined;\n let difficultyValue = null;\n\n if (MGT2Helper.hasValue(rollOptions, \"difficulty\")) {\n difficultyValue = MGT2Helper.getDifficultyValue(rollOptions.difficulty);\n rollEffect = roll.total - difficultyValue;\n rollEffectStr = (rollEffect >= 0 ? \"+\" : \"\") + rollEffect;\n rollSuccess = rollEffect >= 0;\n rollFailure = !rollSuccess;\n }\n\n // Build effective damage formula: base + effect + STR DM (melee)\n let effectiveDamageFormula = rollOptions.damageFormula || null;\n if (effectiveDamageFormula) {\n if (rollEffect !== undefined && rollEffect !== 0) {\n effectiveDamageFormula += (rollEffect >= 0 ? \"+\" : \"\") + rollEffect;\n }\n if (rollOptions.isMelee) {\n const strDm = this.actor.system.characteristics.strength?.dm ?? 0;\n if (strDm !== 0) effectiveDamageFormula += (strDm >= 0 ? \"+\" : \"\") + strDm;\n }\n }\n\n // ── Build roll breakdown tooltip ─────────────────────────────────────\n const diceRawTotal = roll.dice.reduce((s, d) => s + d.total, 0);\n const breakdownParts = [game.i18n.localize(\"MGT2.Chat.Roll.Dice\") + \" \" + diceRawTotal];\n for (const mod of rollModifiers) breakdownParts.push(mod);\n if (rollEffectStr !== undefined)\n breakdownParts.push(game.i18n.localize(\"MGT2.Chat.Roll.Effect\") + \" \" + rollEffectStr);\n const rollBreakdown = breakdownParts.join(\" | \");\n\n const chatData = {\n user: game.user.id,\n speaker: this.actor ? ChatMessage.getSpeaker({ actor: this.actor }) : null,\n formula: roll._formula,\n tooltip: await roll.getTooltip(),\n total: Math.round(roll.total * 100) / 100,\n rollBreakdown,\n showButtons: true,\n showLifeButtons: false,\n showRollRequest: false,\n rollTypeName: rollOptions.rollTypeName,\n rollObjectName: rollOptions.rollObjectName,\n rollModifiers: rollModifiers,\n // Show damage button only if there's a formula AND (no difficulty check OR roll succeeded)\n showRollDamage: !!effectiveDamageFormula && (!difficultyValue || rollSuccess),\n cardButtons: cardButtons,\n };\n\n if (MGT2Helper.hasValue(rollOptions, \"difficulty\")) {\n chatData.rollDifficulty = rollOptions.difficulty;\n chatData.rollDifficultyLabel = MGT2Helper.getDifficultyDisplay(rollOptions.difficulty);\n chatData.rollEffect = rollEffect;\n chatData.rollEffectStr = rollEffectStr;\n chatData.rollSuccess = rollSuccess || undefined;\n chatData.rollFailure = rollFailure || undefined;\n }\n\n const html = await foundry.applications.handlebars.renderTemplate(\"systems/mgt2/templates/chat/roll.html\", chatData);\n chatData.content = html;\n\n let flags = null;\n if (effectiveDamageFormula) {\n flags = { mgt2: { damage: { formula: effectiveDamageFormula, rollObjectName: rollOptions.rollObjectName, rollTypeName: rollOptions.rollTypeName } } };\n }\n if (cardButtons.length > 0) {\n if (!flags) flags = { mgt2: {} };\n flags.mgt2.buttons = cardButtons;\n }\n if (flags) chatData.flags = flags;\n\n return roll.toMessage(chatData);\n }\n\n static async #onOpenConfig(event) {\n event.preventDefault();\n const userConfig = await CharacterPrompts.openConfig(this.actor.system);\n if (userConfig) this.actor.update({ \"system.config\": userConfig });\n }\n\n static async #onOpenCharacteristic(event, target) {\n event.preventDefault();\n const name = target.dataset.cfgCharacteristic;\n const c = this.actor.system.characteristics[name];\n\n let showAll = false;\n for (const value of Object.values(this.actor.system.characteristics)) {\n if (!value.show) { showAll = true; break; }\n }\n\n const userConfig = await CharacterPrompts.openCharacteristic(\n game.i18n.localize(`MGT2.Characteristics.${name}.name`),\n c.show, c.showMax, showAll\n );\n\n if (userConfig) {\n const data = { system: { characteristics: {} } };\n data.system.characteristics[name] = { show: userConfig.show, showMax: userConfig.showMax };\n\n if (userConfig.showAll === true) {\n for (const [key, value] of Object.entries(this.actor.system.characteristics)) {\n if (key !== name && !value.show)\n data.system.characteristics[key] = { show: true };\n }\n }\n this.actor.update(data);\n }\n }\n\n static async #onTraitCreate(event) {\n event.preventDefault();\n let traits = this.actor.system.personal.traits;\n let newTraits;\n if (traits.length === 0) {\n newTraits = [{ name: \"\", description: \"\" }];\n } else {\n newTraits = [...traits, { name: \"\", description: \"\" }];\n }\n return this.actor.update({ system: { personal: { traits: newTraits } } });\n }\n\n static async #onTraitEdit(event, target) {\n event.preventDefault();\n const element = target.closest(\"[data-traits-part]\");\n const index = Number(element.dataset.traitsPart);\n const trait = this.actor.system.personal.traits[index];\n const result = await CharacterPrompts.openTraitEdit(trait);\n const traits = [...this.actor.system.personal.traits];\n traits[index] = { ...traits[index], name: result.name, description: result.description };\n return this.actor.update({ system: { personal: { traits: traits } } });\n }\n\n static async #onTraitDelete(event, target) {\n event.preventDefault();\n const confirmed = await TravellerCharacterSheet.#confirmDelete(game.i18n.localize(\"MGT2.Actor.ThisTrait\"));\n if (!confirmed) return;\n const element = target.closest(\"[data-traits-part]\");\n const index = Number(element.dataset.traitsPart);\n const traits = foundry.utils.deepClone(this.actor.system.personal.traits);\n const newTraits = Object.entries(traits)\n .filter(([key]) => Number(key) !== index)\n .map(([, value]) => value);\n return this.actor.update({ system: { personal: { traits: newTraits } } });\n }\n\n static async #onOpenEditor(event) {\n event.preventDefault();\n await CharacterPrompts.openEditorFullView(\n this.actor.system.personal.species,\n this.actor.system.personal.speciesText.descriptionLong\n );\n }\n\n static async #onHeal(event, target) {\n event.preventDefault();\n const healType = target.dataset.healType;\n\n if (canvas.tokens.controlled.length === 0) {\n ui.notifications.warn(game.i18n.localize(\"MGT2.Errors.NoTokenSelected\"));\n return;\n }\n\n if (healType === \"firstaid\") {\n // Find Medicine skill to pre-select\n // Use normalized string matching to handle accents\n const medSkill = this.actor.items.find(i => {\n if (i.type !== \"talent\" || i.system.subType !== \"skill\") return false;\n const normalized = i.name.toLowerCase().normalize(\"NFD\").replace(/[\\u0300-\\u036f]/g, \"\");\n return normalized.includes(\"medecin\") || normalized.includes(\"medicine\");\n });\n \n // Only EDU characteristic available for First Aid\n const characteristics = [\n { _id: \"education\", name: game.i18n.localize(\"MGT2.Characteristics.education.name\") }\n ];\n \n const rollOptions = {\n rollTypeName: game.i18n.localize(\"MGT2.Healing.FirstAid\"),\n rollObjectName: this.actor.name,\n characteristics: characteristics, // Only EDU\n characteristic: \"education\", // Pre-selected\n skill: medSkill?.id ?? \"\", // Medicine skill ID for pre-selection (must match _id in array)\n skillName: medSkill?.name ?? game.i18n.localize(\"MGT2.Healing.NoMedicineSkill\"), // Display name\n skillLevel: medSkill?.system.level ?? -3, // -3 if not found\n skills: medSkill ? [{ _id: medSkill.id, name: medSkill.name, level: medSkill.system.level }] : [],\n difficulty: \"Average\", // First Aid difficulty is 8 (Average)\n showHeal: true,\n healType: MGT2.HealingType.FIRST_AID,\n };\n const userRollData = await RollPromptHelper.roll(rollOptions);\n if (userRollData) {\n // Build formula with all DMs — same pattern as standard skill roll\n const rollFormulaParts = [];\n const rollModifiers = [];\n\n if (userRollData.diceModifier) {\n rollFormulaParts.push(\"3d6\");\n rollFormulaParts.push(userRollData.diceModifier);\n } else {\n rollFormulaParts.push(\"2d6\");\n }\n\n if (userRollData.characteristic) {\n const c = this.actor.system.characteristics[userRollData.characteristic];\n rollFormulaParts.push(MGT2Helper.getFormulaDM(c.dm));\n rollModifiers.push(game.i18n.localize(`MGT2.Characteristics.${userRollData.characteristic}.name`) + MGT2Helper.getDisplayDM(c.dm));\n }\n\n if (userRollData.skill && userRollData.skill !== \"\") {\n if (userRollData.skill === \"NP\") {\n rollFormulaParts.push(\"-3\");\n rollModifiers.push(game.i18n.localize(\"MGT2.Items.NotProficient\"));\n } else {\n const skillObj = this.actor.getEmbeddedDocument(\"Item\", userRollData.skill);\n rollFormulaParts.push(MGT2Helper.getFormulaDM(skillObj.system.level));\n rollModifiers.push(skillObj.getRollDisplay());\n }\n }\n\n if (userRollData.customDM && userRollData.customDM !== \"\") {\n let s = userRollData.customDM.trim();\n if (/^[0-9]/.test(s)) rollFormulaParts.push(\"+\");\n rollFormulaParts.push(s);\n rollModifiers.push(\"DM \" + s);\n }\n\n const rollFormula = rollFormulaParts.join(\"\");\n const roll = await new Roll(rollFormula, this.actor.getRollData()).roll();\n\n // Difficulty for First Aid is Average (8)\n const difficulty = 8;\n const effect = roll.total - difficulty;\n const isSuccess = effect >= 0;\n const healing = isSuccess ? Math.max(1, effect) : 0;\n\n const cardButtons = isSuccess\n ? [{ label: game.i18n.localize(\"MGT2.Healing.ApplyHealing\"), action: \"healing\" }]\n : [];\n\n const chatData = {\n user: game.user.id,\n speaker: ChatMessage.getSpeaker({ actor: this.actor }),\n formula: roll._formula,\n tooltip: await roll.getTooltip(),\n total: Math.round(roll.total * 100) / 100,\n rollTypeName: game.i18n.localize(\"MGT2.Healing.FirstAid\"),\n rollObjectName: this.actor.name,\n rollModifiers: rollModifiers,\n rollDifficulty: difficulty,\n rollDifficultyLabel: MGT2Helper.getDifficultyDisplay(\"Average\"),\n rollEffectStr: isSuccess ? effect.toString() : undefined,\n healingAmount: isSuccess ? healing : undefined,\n rollSuccess: isSuccess || undefined,\n rollFailure: !isSuccess || undefined,\n showButtons: isSuccess,\n hasDamage: false,\n showRollDamage: false,\n cardButtons: cardButtons,\n };\n\n const html = await foundry.applications.handlebars.renderTemplate(\"systems/mgt2/templates/chat/roll.html\", chatData);\n chatData.content = html;\n chatData.flags = { mgt2: { healing: { amount: healing } } };\n\n return roll.toMessage(chatData);\n }\n } else if (healType === \"surgery\") {\n // Find Medicine skill to pre-select (same as first aid)\n const medSkill = this.actor.items.find(i => {\n if (i.type !== \"talent\" || i.system.subType !== \"skill\") return false;\n const normalized = i.name.toLowerCase().normalize(\"NFD\").replace(/[\\u0300-\\u036f]/g, \"\");\n return normalized.includes(\"medecin\") || normalized.includes(\"medicine\");\n });\n\n const characteristics = [\n { _id: \"education\", name: game.i18n.localize(\"MGT2.Characteristics.education.name\") }\n ];\n\n const rollOptions = {\n rollTypeName: game.i18n.localize(\"MGT2.Healing.Surgery\"),\n rollObjectName: this.actor.name,\n characteristics: characteristics,\n characteristic: \"education\",\n skill: medSkill?.id ?? \"\",\n skillName: medSkill?.name ?? game.i18n.localize(\"MGT2.Healing.NoMedicineSkill\"),\n skillLevel: medSkill?.system.level ?? -3,\n skills: medSkill ? [{ _id: medSkill.id, name: medSkill.name, level: medSkill.system.level }] : [],\n difficulty: \"Average\",\n showHeal: true,\n healType: MGT2.HealingType.SURGERY,\n };\n const userRollData = await RollPromptHelper.roll(rollOptions);\n if (userRollData) {\n // Build formula with all DMs — same pattern as standard skill roll\n const rollFormulaParts = [];\n const rollModifiers = [];\n\n if (userRollData.diceModifier) {\n rollFormulaParts.push(\"3d6\");\n rollFormulaParts.push(userRollData.diceModifier);\n } else {\n rollFormulaParts.push(\"2d6\");\n }\n\n if (userRollData.characteristic) {\n const c = this.actor.system.characteristics[userRollData.characteristic];\n rollFormulaParts.push(MGT2Helper.getFormulaDM(c.dm));\n rollModifiers.push(game.i18n.localize(`MGT2.Characteristics.${userRollData.characteristic}.name`) + MGT2Helper.getDisplayDM(c.dm));\n }\n\n if (userRollData.skill && userRollData.skill !== \"\") {\n if (userRollData.skill === \"NP\") {\n rollFormulaParts.push(\"-3\");\n rollModifiers.push(game.i18n.localize(\"MGT2.Items.NotProficient\"));\n } else {\n const skillObj = this.actor.getEmbeddedDocument(\"Item\", userRollData.skill);\n rollFormulaParts.push(MGT2Helper.getFormulaDM(skillObj.system.level));\n rollModifiers.push(skillObj.getRollDisplay());\n }\n }\n\n if (userRollData.customDM && userRollData.customDM !== \"\") {\n let s = userRollData.customDM.trim();\n if (/^[0-9]/.test(s)) rollFormulaParts.push(\"+\");\n rollFormulaParts.push(s);\n rollModifiers.push(\"DM \" + s);\n }\n\n const rollFormula = rollFormulaParts.join(\"\");\n const roll = await new Roll(rollFormula, this.actor.getRollData()).roll();\n\n // Difficulty for Surgery is Average (8)\n const difficulty = 8;\n const effect = roll.total - difficulty;\n const isSuccess = effect >= 0;\n\n // Success: heal Math.max(1, effect); Failure: patient takes 3 + |effect| damage\n const healing = isSuccess ? Math.max(1, effect) : 0;\n const surgeryDamage = isSuccess ? 0 : 3 + Math.abs(effect);\n\n const cardButtons = [];\n if (isSuccess) {\n cardButtons.push({ label: game.i18n.localize(\"MGT2.Healing.ApplyHealing\"), action: \"healing\" });\n } else {\n cardButtons.push({ label: game.i18n.localize(\"MGT2.Healing.ApplySurgeryDamage\"), action: \"surgeryDamage\" });\n }\n\n const chatData = {\n user: game.user.id,\n speaker: ChatMessage.getSpeaker({ actor: this.actor }),\n formula: roll._formula,\n tooltip: await roll.getTooltip(),\n total: Math.round(roll.total * 100) / 100,\n rollTypeName: game.i18n.localize(\"MGT2.Healing.Surgery\"),\n rollObjectName: this.actor.name,\n rollModifiers: rollModifiers,\n rollDifficulty: difficulty,\n rollDifficultyLabel: MGT2Helper.getDifficultyDisplay(\"Average\"),\n rollEffectStr: effect.toString(),\n healingAmount: isSuccess ? healing : undefined,\n surgeryDamageAmount: isSuccess ? undefined : surgeryDamage,\n rollSuccess: isSuccess || undefined,\n rollFailure: !isSuccess || undefined,\n showButtons: true,\n hasDamage: false,\n showRollDamage: false,\n cardButtons: cardButtons,\n };\n\n const html = await foundry.applications.handlebars.renderTemplate(\"systems/mgt2/templates/chat/roll.html\", chatData);\n chatData.content = html;\n chatData.flags = { mgt2: { surgery: { healing, surgeryDamage } } };\n\n return roll.toMessage(chatData);\n }\n } else if (healType === \"medical\") {\n const result = await CharacterPrompts.openHealingDays();\n if (result) {\n const endMD = this.actor.system.characteristics.endurance.dm;\n const medSkill = this.actor.items.find(i =>\n i.type === \"talent\" &&\n i.system.subType === \"skill\" &&\n (i.name.toLowerCase().includes(\"medecin\") || i.name.toLowerCase().includes(\"medicine\"))\n );\n const skillValue = medSkill ? medSkill.system.level : 0;\n const days = result.days;\n const healingPerDay = Math.max(1, 3 + endMD + skillValue);\n const totalHealing = healingPerDay * days;\n\n const rollModifiers = [\n `3 (base)`,\n `${endMD >= 0 ? \"+\" : \"\"}${endMD} END`,\n `+${skillValue} ${medSkill?.name ?? \"Médecine\"}`,\n `× ${days} ${game.i18n.localize(\"MGT2.RollPrompt.Days\").toLowerCase()}`\n ];\n\n const templateData = {\n rollObjectName: this.actor.name,\n rollTypeName: game.i18n.localize(\"MGT2.Healing.MedicalCare\"),\n rollModifiers,\n formula: `${healingPerDay} ${game.i18n.localize(\"MGT2.Items.PerDay\")}`,\n tooltip: \"\",\n total: totalHealing,\n rollSuccess: true,\n showButtons: true,\n cardButtons: [\n { action: \"healing\", label: game.i18n.localize(\"MGT2.Healing.ApplyHealing\") }\n ]\n };\n\n const content = await renderTemplate(\n \"systems/mgt2/templates/chat/roll.html\",\n templateData\n );\n await ChatMessage.create({\n user: game.user.id,\n speaker: ChatMessage.getSpeaker({ actor: this.actor }),\n content,\n flags: { mgt2: { healing: { amount: totalHealing } } }\n });\n }\n } else if (healType === \"natural\") {\n const result = await CharacterPrompts.openHealingDays();\n if (result) {\n const endMD = this.actor.system.characteristics.endurance.dm;\n let totalAmount = 0;\n const rolls = [];\n \n for (let i = 0; i < result.days; i++) {\n const roll = await new Roll(\"1d6\").evaluate();\n const dayHealing = Math.max(1, roll.total + endMD);\n rolls.push({ roll, dayHealing });\n totalAmount += dayHealing;\n }\n \n // Build roll details\n const rollDisplay = rolls.map((r, idx) => \n `${game.i18n.format("MGT2.Dialog.ConfirmDeleteContent", { name })}
`, + yes: { label: game.i18n.localize("MGT2.Dialog.Yes"), icon: "fas fa-trash" }, + no: { label: game.i18n.localize("MGT2.Dialog.No"), icon: "fas fa-times" }, + rejectClose: false, + modal: true + }); + } + static async #onDeleteItem(event, target) { event.preventDefault(); const li = target.closest("[data-item-id]"); if (!li?.dataset.itemId) return; + const item = this.actor.items.get(li.dataset.itemId); + if (!item) return; + const confirmed = await TravellerCharacterSheet.#confirmDelete(item.name); + if (!confirmed) return; this.actor.deleteEmbeddedDocuments("Item", [li.dataset.itemId]); } static async #onEquipItem(event, target) { event.preventDefault(); const li = target.closest("[data-item-id]"); - const item = this.actor.getEmbeddedDocument("Item", li?.dataset.itemId); + const itemId = li?.dataset.itemId; + if (!itemId) return; + const item = this.actor.items.get(itemId); if (!item) return; await item.update({ "system.equipped": !item.system.equipped }); } @@ -530,6 +552,9 @@ export default class TravellerCharacterSheet extends MGT2ActorSheet { const container = containers.find(x => x._id === this.actor.system.containerView); if (!container) return; + const confirmed = await TravellerCharacterSheet.#confirmDelete(container.name); + if (!confirmed) return; + const containerItems = this.actor.items.filter( x => x.system.hasOwnProperty("container") && x.system.container.id === container._id ); @@ -564,6 +589,7 @@ export default class TravellerCharacterSheet extends MGT2ActorSheet { encumbrance: this.actor.system.states.encumbrance, difficulty: null, damageFormula: null, + isMelee: false, }; const cardButtons = []; @@ -631,6 +657,9 @@ export default class TravellerCharacterSheet extends MGT2ActorSheet { if (itemObj?.system.hasOwnProperty("damage")) { rollOptions.damageFormula = itemObj.system.damage; + if (itemObj.type === "weapon") { + rollOptions.isMelee = itemObj.system.range?.isMelee === true; + } if (itemObj.type === "disease") { if (itemObj.system.subType === "disease") rollOptions.rollTypeName = game.i18n.localize("MGT2.DiseaseSubType.disease"); @@ -695,13 +724,13 @@ export default class TravellerCharacterSheet extends MGT2ActorSheet { rollModifiers.push(game.i18n.localize("MGT2.Actor.Fatigue") + " -2"); } - if (userRollData.customDM) { - const s = userRollData.customDM.trim(); - if (/^[0-9]/.test(s)) rollFormulaParts.push("+"); - rollFormulaParts.push(s); + const customDMVal = parseInt(userRollData.customDM ?? "0", 10); + if (!isNaN(customDMVal) && customDMVal !== 0) { + rollFormulaParts.push(customDMVal > 0 ? `+${customDMVal}` : `${customDMVal}`); + rollModifiers.push(game.i18n.localize("MGT2.RollPrompt.CustomDM") + " " + (customDMVal > 0 ? `+${customDMVal}` : `${customDMVal}`)); } - if (MGT2Helper.hasValue(userRollData, "difficulty")) rollOptions.difficulty = userRollData.difficulty; + if (MGT2Helper.hasValue(userRollData, "difficulty") && userRollData.difficulty !== "") rollOptions.difficulty = userRollData.difficulty; const rollFormula = rollFormulaParts.join(""); if (!Roll.validate(rollFormula)) { @@ -715,37 +744,74 @@ export default class TravellerCharacterSheet extends MGT2ActorSheet { await this.token.combatant.update({ initiative: roll.total }); } + // ── Compute effect and effective damage formula ────────────────────── + let rollSuccess = false; + let rollFailure = false; + let rollEffect = undefined; + let rollEffectStr = undefined; + let difficultyValue = null; + + if (MGT2Helper.hasValue(rollOptions, "difficulty")) { + difficultyValue = MGT2Helper.getDifficultyValue(rollOptions.difficulty); + rollEffect = roll.total - difficultyValue; + rollEffectStr = (rollEffect >= 0 ? "+" : "") + rollEffect; + rollSuccess = rollEffect >= 0; + rollFailure = !rollSuccess; + } + + // Build effective damage formula: base + effect + STR DM (melee) + let effectiveDamageFormula = rollOptions.damageFormula || null; + if (effectiveDamageFormula) { + if (rollEffect !== undefined && rollEffect !== 0) { + effectiveDamageFormula += (rollEffect >= 0 ? "+" : "") + rollEffect; + } + if (rollOptions.isMelee) { + const strDm = this.actor.system.characteristics.strength?.dm ?? 0; + if (strDm !== 0) effectiveDamageFormula += (strDm >= 0 ? "+" : "") + strDm; + } + } + + // ── Build roll breakdown tooltip ───────────────────────────────────── + const diceRawTotal = roll.dice.reduce((s, d) => s + d.total, 0); + const breakdownParts = [game.i18n.localize("MGT2.Chat.Roll.Dice") + " " + diceRawTotal]; + for (const mod of rollModifiers) breakdownParts.push(mod); + if (rollEffectStr !== undefined) + breakdownParts.push(game.i18n.localize("MGT2.Chat.Roll.Effect") + " " + rollEffectStr); + const rollBreakdown = breakdownParts.join(" | "); + const chatData = { user: game.user.id, speaker: this.actor ? ChatMessage.getSpeaker({ actor: this.actor }) : null, formula: roll._formula, tooltip: await roll.getTooltip(), total: Math.round(roll.total * 100) / 100, + rollBreakdown, showButtons: true, showLifeButtons: false, showRollRequest: false, rollTypeName: rollOptions.rollTypeName, rollObjectName: rollOptions.rollObjectName, rollModifiers: rollModifiers, - showRollDamage: rollOptions.damageFormula !== null && rollOptions.damageFormula !== "", + // Show damage button only if there's a formula AND (no difficulty check OR roll succeeded) + showRollDamage: !!effectiveDamageFormula && (!difficultyValue || rollSuccess), cardButtons: cardButtons, }; if (MGT2Helper.hasValue(rollOptions, "difficulty")) { chatData.rollDifficulty = rollOptions.difficulty; chatData.rollDifficultyLabel = MGT2Helper.getDifficultyDisplay(rollOptions.difficulty); - if (roll.total >= MGT2Helper.getDifficultyValue(rollOptions.difficulty)) - chatData.rollSuccess = true; - else - chatData.rollFailure = true; + chatData.rollEffect = rollEffect; + chatData.rollEffectStr = rollEffectStr; + chatData.rollSuccess = rollSuccess || undefined; + chatData.rollFailure = rollFailure || undefined; } const html = await foundry.applications.handlebars.renderTemplate("systems/mgt2/templates/chat/roll.html", chatData); chatData.content = html; let flags = null; - if (rollOptions.damageFormula) { - flags = { mgt2: { damage: { formula: rollOptions.damageFormula, rollObjectName: rollOptions.rollObjectName, rollTypeName: rollOptions.rollTypeName } } }; + if (effectiveDamageFormula) { + flags = { mgt2: { damage: { formula: effectiveDamageFormula, rollObjectName: rollOptions.rollObjectName, rollTypeName: rollOptions.rollTypeName } } }; } if (cardButtons.length > 0) { if (!flags) flags = { mgt2: {} }; @@ -816,6 +882,8 @@ export default class TravellerCharacterSheet extends MGT2ActorSheet { static async #onTraitDelete(event, target) { event.preventDefault(); + const confirmed = await TravellerCharacterSheet.#confirmDelete(game.i18n.localize("MGT2.Actor.ThisTrait")); + if (!confirmed) return; const element = target.closest("[data-traits-part]"); const index = Number(element.dataset.traitsPart); const traits = foundry.utils.deepClone(this.actor.system.personal.traits); @@ -832,4 +900,323 @@ export default class TravellerCharacterSheet extends MGT2ActorSheet { this.actor.system.personal.speciesText.descriptionLong ); } + + static async #onHeal(event, target) { + event.preventDefault(); + const healType = target.dataset.healType; + + if (canvas.tokens.controlled.length === 0) { + ui.notifications.warn(game.i18n.localize("MGT2.Errors.NoTokenSelected")); + return; + } + + if (healType === "firstaid") { + // Find Medicine skill to pre-select + // Use normalized string matching to handle accents + const medSkill = this.actor.items.find(i => { + if (i.type !== "talent" || i.system.subType !== "skill") return false; + const normalized = i.name.toLowerCase().normalize("NFD").replace(/[\u0300-\u036f]/g, ""); + return normalized.includes("medecin") || normalized.includes("medicine"); + }); + + // Only EDU characteristic available for First Aid + const characteristics = [ + { _id: "education", name: game.i18n.localize("MGT2.Characteristics.education.name") } + ]; + + const rollOptions = { + rollTypeName: game.i18n.localize("MGT2.Healing.FirstAid"), + rollObjectName: this.actor.name, + characteristics: characteristics, // Only EDU + characteristic: "education", // Pre-selected + skill: medSkill?.id ?? "", // Medicine skill ID for pre-selection (must match _id in array) + skillName: medSkill?.name ?? game.i18n.localize("MGT2.Healing.NoMedicineSkill"), // Display name + skillLevel: medSkill?.system.level ?? -3, // -3 if not found + skills: medSkill ? [{ _id: medSkill.id, name: medSkill.name, level: medSkill.system.level }] : [], + difficulty: "Average", // First Aid difficulty is 8 (Average) + showHeal: true, + healType: MGT2.HealingType.FIRST_AID, + }; + const userRollData = await RollPromptHelper.roll(rollOptions); + if (userRollData) { + // Build formula with all DMs — same pattern as standard skill roll + const rollFormulaParts = []; + const rollModifiers = []; + + if (userRollData.diceModifier) { + rollFormulaParts.push("3d6"); + rollFormulaParts.push(userRollData.diceModifier); + } else { + rollFormulaParts.push("2d6"); + } + + if (userRollData.characteristic) { + const c = this.actor.system.characteristics[userRollData.characteristic]; + rollFormulaParts.push(MGT2Helper.getFormulaDM(c.dm)); + rollModifiers.push(game.i18n.localize(`MGT2.Characteristics.${userRollData.characteristic}.name`) + MGT2Helper.getDisplayDM(c.dm)); + } + + if (userRollData.skill && userRollData.skill !== "") { + if (userRollData.skill === "NP") { + rollFormulaParts.push("-3"); + rollModifiers.push(game.i18n.localize("MGT2.Items.NotProficient")); + } else { + const skillObj = this.actor.getEmbeddedDocument("Item", userRollData.skill); + rollFormulaParts.push(MGT2Helper.getFormulaDM(skillObj.system.level)); + rollModifiers.push(skillObj.getRollDisplay()); + } + } + + if (userRollData.customDM && userRollData.customDM !== "") { + let s = userRollData.customDM.trim(); + if (/^[0-9]/.test(s)) rollFormulaParts.push("+"); + rollFormulaParts.push(s); + rollModifiers.push("DM " + s); + } + + const rollFormula = rollFormulaParts.join(""); + const roll = await new Roll(rollFormula, this.actor.getRollData()).roll(); + + // Difficulty for First Aid is Average (8) + const difficulty = 8; + const effect = roll.total - difficulty; + const isSuccess = effect >= 0; + const healing = isSuccess ? Math.max(1, effect) : 0; + + const cardButtons = isSuccess + ? [{ label: game.i18n.localize("MGT2.Healing.ApplyHealing"), action: "healing" }] + : []; + + const chatData = { + user: game.user.id, + speaker: ChatMessage.getSpeaker({ actor: this.actor }), + formula: roll._formula, + tooltip: await roll.getTooltip(), + total: Math.round(roll.total * 100) / 100, + rollTypeName: game.i18n.localize("MGT2.Healing.FirstAid"), + rollObjectName: this.actor.name, + rollModifiers: rollModifiers, + rollDifficulty: difficulty, + rollDifficultyLabel: MGT2Helper.getDifficultyDisplay("Average"), + rollEffectStr: isSuccess ? effect.toString() : undefined, + healingAmount: isSuccess ? healing : undefined, + rollSuccess: isSuccess || undefined, + rollFailure: !isSuccess || undefined, + showButtons: isSuccess, + hasDamage: false, + showRollDamage: false, + cardButtons: cardButtons, + }; + + const html = await foundry.applications.handlebars.renderTemplate("systems/mgt2/templates/chat/roll.html", chatData); + chatData.content = html; + chatData.flags = { mgt2: { healing: { amount: healing } } }; + + return roll.toMessage(chatData); + } + } else if (healType === "surgery") { + // Find Medicine skill to pre-select (same as first aid) + const medSkill = this.actor.items.find(i => { + if (i.type !== "talent" || i.system.subType !== "skill") return false; + const normalized = i.name.toLowerCase().normalize("NFD").replace(/[\u0300-\u036f]/g, ""); + return normalized.includes("medecin") || normalized.includes("medicine"); + }); + + const characteristics = [ + { _id: "education", name: game.i18n.localize("MGT2.Characteristics.education.name") } + ]; + + const rollOptions = { + rollTypeName: game.i18n.localize("MGT2.Healing.Surgery"), + rollObjectName: this.actor.name, + characteristics: characteristics, + characteristic: "education", + skill: medSkill?.id ?? "", + skillName: medSkill?.name ?? game.i18n.localize("MGT2.Healing.NoMedicineSkill"), + skillLevel: medSkill?.system.level ?? -3, + skills: medSkill ? [{ _id: medSkill.id, name: medSkill.name, level: medSkill.system.level }] : [], + difficulty: "Average", + showHeal: true, + healType: MGT2.HealingType.SURGERY, + }; + const userRollData = await RollPromptHelper.roll(rollOptions); + if (userRollData) { + // Build formula with all DMs — same pattern as standard skill roll + const rollFormulaParts = []; + const rollModifiers = []; + + if (userRollData.diceModifier) { + rollFormulaParts.push("3d6"); + rollFormulaParts.push(userRollData.diceModifier); + } else { + rollFormulaParts.push("2d6"); + } + + if (userRollData.characteristic) { + const c = this.actor.system.characteristics[userRollData.characteristic]; + rollFormulaParts.push(MGT2Helper.getFormulaDM(c.dm)); + rollModifiers.push(game.i18n.localize(`MGT2.Characteristics.${userRollData.characteristic}.name`) + MGT2Helper.getDisplayDM(c.dm)); + } + + if (userRollData.skill && userRollData.skill !== "") { + if (userRollData.skill === "NP") { + rollFormulaParts.push("-3"); + rollModifiers.push(game.i18n.localize("MGT2.Items.NotProficient")); + } else { + const skillObj = this.actor.getEmbeddedDocument("Item", userRollData.skill); + rollFormulaParts.push(MGT2Helper.getFormulaDM(skillObj.system.level)); + rollModifiers.push(skillObj.getRollDisplay()); + } + } + + if (userRollData.customDM && userRollData.customDM !== "") { + let s = userRollData.customDM.trim(); + if (/^[0-9]/.test(s)) rollFormulaParts.push("+"); + rollFormulaParts.push(s); + rollModifiers.push("DM " + s); + } + + const rollFormula = rollFormulaParts.join(""); + const roll = await new Roll(rollFormula, this.actor.getRollData()).roll(); + + // Difficulty for Surgery is Average (8) + const difficulty = 8; + const effect = roll.total - difficulty; + const isSuccess = effect >= 0; + + // Success: heal Math.max(1, effect); Failure: patient takes 3 + |effect| damage + const healing = isSuccess ? Math.max(1, effect) : 0; + const surgeryDamage = isSuccess ? 0 : 3 + Math.abs(effect); + + const cardButtons = []; + if (isSuccess) { + cardButtons.push({ label: game.i18n.localize("MGT2.Healing.ApplyHealing"), action: "healing" }); + } else { + cardButtons.push({ label: game.i18n.localize("MGT2.Healing.ApplySurgeryDamage"), action: "surgeryDamage" }); + } + + const chatData = { + user: game.user.id, + speaker: ChatMessage.getSpeaker({ actor: this.actor }), + formula: roll._formula, + tooltip: await roll.getTooltip(), + total: Math.round(roll.total * 100) / 100, + rollTypeName: game.i18n.localize("MGT2.Healing.Surgery"), + rollObjectName: this.actor.name, + rollModifiers: rollModifiers, + rollDifficulty: difficulty, + rollDifficultyLabel: MGT2Helper.getDifficultyDisplay("Average"), + rollEffectStr: effect.toString(), + healingAmount: isSuccess ? healing : undefined, + surgeryDamageAmount: isSuccess ? undefined : surgeryDamage, + rollSuccess: isSuccess || undefined, + rollFailure: !isSuccess || undefined, + showButtons: true, + hasDamage: false, + showRollDamage: false, + cardButtons: cardButtons, + }; + + const html = await foundry.applications.handlebars.renderTemplate("systems/mgt2/templates/chat/roll.html", chatData); + chatData.content = html; + chatData.flags = { mgt2: { surgery: { healing, surgeryDamage } } }; + + return roll.toMessage(chatData); + } + } else if (healType === "medical") { + const result = await CharacterPrompts.openHealingDays(); + if (result) { + const endMD = this.actor.system.characteristics.endurance.dm; + const medSkill = this.actor.items.find(i => + i.type === "talent" && + i.system.subType === "skill" && + (i.name.toLowerCase().includes("medecin") || i.name.toLowerCase().includes("medicine")) + ); + const skillValue = medSkill ? medSkill.system.level : 0; + const days = result.days; + const healingPerDay = Math.max(1, 3 + endMD + skillValue); + const totalHealing = healingPerDay * days; + + const rollModifiers = [ + `3 (base)`, + `${endMD >= 0 ? "+" : ""}${endMD} END`, + `+${skillValue} ${medSkill?.name ?? "Médecine"}`, + `× ${days} ${game.i18n.localize("MGT2.RollPrompt.Days").toLowerCase()}` + ]; + + const templateData = { + rollObjectName: this.actor.name, + rollTypeName: game.i18n.localize("MGT2.Healing.MedicalCare"), + rollModifiers, + formula: `${healingPerDay} ${game.i18n.localize("MGT2.Items.PerDay")}`, + tooltip: "", + total: totalHealing, + rollSuccess: true, + showButtons: true, + cardButtons: [ + { action: "healing", label: game.i18n.localize("MGT2.Healing.ApplyHealing") } + ] + }; + + const content = await renderTemplate( + "systems/mgt2/templates/chat/roll.html", + templateData + ); + await ChatMessage.create({ + user: game.user.id, + speaker: ChatMessage.getSpeaker({ actor: this.actor }), + content, + flags: { mgt2: { healing: { amount: totalHealing } } } + }); + } + } else if (healType === "natural") { + const result = await CharacterPrompts.openHealingDays(); + if (result) { + const endMD = this.actor.system.characteristics.endurance.dm; + let totalAmount = 0; + const rolls = []; + + for (let i = 0; i < result.days; i++) { + const roll = await new Roll("1d6").evaluate(); + const dayHealing = Math.max(1, roll.total + endMD); + rolls.push({ roll, dayHealing }); + totalAmount += dayHealing; + } + + // Build roll details + const rollDisplay = rolls.map((r, idx) => + `