From 57ddea957acd88910790f2f1bb9d5a629b975c56 Mon Sep 17 00:00:00 2001
From: LeRatierBretonnier <sylvain@lahiette.com>
Date: Mon, 17 Aug 2026 22:43:36 +0200
Subject: [PATCH] =?UTF-8?q?fix:=20traits=20dans=20les=20jets=20et=20=C3=A9?=
 =?UTF-8?q?dition=20du=20niveau=20de=20trait?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- partial-common-roll-dialog.hbs, confront-dialog.hbs: utiliser trait.id
  (pas trait._id) pour matcher rollData.traits construit dans ecryme-actor.js
  Fix: jet silencieux quand un trait était sélectionné (value=undefined ->
  getTrait(undefined) -> TypeError avant création du message de chat)
- ecryme-config.js: traitLevel utilise des clés 1/2/3 (pas -3..+3) pour
  matcher le NumberField level (initial:1, min:1) du DataModel trait.js.
  Fix: le niveau revient sur -3 à l'édition car String(2) ne matchait pas '+2'

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
---
 modules/common/ecryme-config.js                  | 9 +++------
 templates/dialogs/confront-dialog.hbs            | 4 ++--
 templates/dialogs/partial-common-roll-dialog.hbs | 4 ++--
 3 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/modules/common/ecryme-config.js b/modules/common/ecryme-config.js
index f8d780c..05966d5 100644
--- a/modules/common/ecryme-config.js
+++ b/modules/common/ecryme-config.js
@@ -11,12 +11,9 @@ export const ECRYME_CONFIG = {
     "ranged": "ECRY.ui.ranged"
   },
   traitLevel: {
-    "-3":{value: "-3", text: "-3"},
-    "-2":{value: "-2", text: "-2"},
-    "-1":{value: "-1", text: "-1"},
-    "+1":{value: "+1", text: "+1"},
-    "+2":{value: "+2", text: "+2"},
-    "+3":{value: "+3", text: "+3"}
+    "1":{value: "1", text: "1"},
+    "2":{value: "2", text: "2"},
+    "3":{value: "3", text: "3"}
   },
   impactTypes: {
     physical: "ECRY.ui.physical",
diff --git a/templates/dialogs/confront-dialog.hbs b/templates/dialogs/confront-dialog.hbs
index ef26bf7..5d80c72 100644
--- a/templates/dialogs/confront-dialog.hbs
+++ b/templates/dialogs/confront-dialog.hbs
@@ -80,7 +80,7 @@
       <span class="roll-dialog-label">{{localize "ECRY.ui.traitbonus"}} : </span>
       <select id="roll-trait-bonus" data-type="String" multiple>
         {{#each traitsBonus as |trait idx|}}
-        <option value="{{trait._id}}" {{#if trait.activated}}selected{{/if}}>{{trait.name}} ({{trait.system.level}})</option>
+        <option value="{{trait.id}}" {{#if trait.activated}}selected{{/if}}>{{trait.name}} ({{trait.system.level}})</option>
         {{/each}}
       </select>
     </div>
@@ -89,7 +89,7 @@
       <span class="roll-dialog-label">{{localize "ECRY.ui.traitmalus"}} : </span>
       <select id="roll-trait-malus" data-type="String" multiple>
         {{#each traitsMalus as |trait idx|}}
-        <option value="{{trait._id}}" {{#if trait.activated}}selected{{/if}}>{{trait.name}} ({{trait.system.level}})</option>
+        <option value="{{trait.id}}" {{#if trait.activated}}selected{{/if}}>{{trait.name}} ({{trait.system.level}})</option>
         {{/each}}
       </select>
     </div>
diff --git a/templates/dialogs/partial-common-roll-dialog.hbs b/templates/dialogs/partial-common-roll-dialog.hbs
index d514bc3..4f6c08c 100644
--- a/templates/dialogs/partial-common-roll-dialog.hbs
+++ b/templates/dialogs/partial-common-roll-dialog.hbs
@@ -52,7 +52,7 @@
       <span class="roll-dialog-label">{{localize "ECRY.ui.traitbonus"}} : </span>
       <select class="" id="roll-trait-bonus" data-type="String" multiple>
         {{#each traits as | trait idx|}}
-          <option value="{{trait._id}}">{{trait.name}} ({{trait.system.level}})</option>
+          <option value="{{trait.id}}">{{trait.name}} ({{trait.system.level}})</option>
         {{/each}}
       </select>
     </div>
@@ -61,7 +61,7 @@
       <span class="roll-dialog-label">{{localize "ECRY.ui.traitmalus"}} : </span>
       <select class="" id="roll-trait-malus" data-type="String" multiple>
         {{#each traits as | trait idx|}}
-          <option value="{{trait._id}}">{{trait.name}} ({{trait.system.level}})</option>
+          <option value="{{trait.id}}">{{trait.name}} ({{trait.system.level}})</option>
         {{/each}}
       </select>
     </div>