Fix #30 - Disable dual skills dop

module/applications/sheets/protagonist-sheet.mjs

@@ -98,22 +98,30 @@ export default class CthulhuEternalProtagonistSheet extends CthulhuEternalActorS
       case "skills":
         context.tab = context.tabs.skills
         context.skills = doc.itemTypes.skill
+        context.skills.sort((a, b) => a.name.localeCompare(b.name))
         break
       case "equipment":
         context.tab = context.tabs.equipment
         context.weapons = doc.itemTypes.weapon
+        context.weapons.sort((a, b) => a.name.localeCompare(b.name))
         context.armors = doc.itemTypes.armor
+        context.armors.sort((a, b) => a.name.localeCompare(b.name))
         context.gears = doc.itemTypes.gear
+        context.gears.sort((a, b) => a.name.localeCompare(b.name))
         break
       case "status":
         context.tab = context.tabs.status
         context.injuries = doc.itemTypes.injury
+        context.injuries.sort((a, b) => a.name.localeCompare(b.name))
         context.mentaldisorders = doc.itemTypes.mentaldisorder
+        context.mentaldisorders.sort((a, b) => a.name.localeCompare(b.name))
         context.bonds = doc.itemTypes.bond
+        context.bonds.sort((a, b) => a.name.localeCompare(b.name))
         break
       case "biography":
         context.tab = context.tabs.biography
         context.motivations = doc.itemTypes.motivation
+        context.motivations.sort((a, b) => a.name.localeCompare(b.name))
         context.enrichedDescription = await TextEditor.enrichHTML(doc.system.description, { async: true })
         context.enrichedNotes = await TextEditor.enrichHTML(doc.system.notes, { async: true })
         break

module/documents/actor.mjs

@@ -1,7 +1,7 @@
 import CthulhuEternalUtils from "../utils.mjs"
 
 export default class CthulhuEternalActor extends Actor {
-  
+
   static async create(data, options) {
 
     // Case of compendium global import
@@ -19,7 +19,7 @@ export default class CthulhuEternalActor extends Actor {
       const skills = await CthulhuEternalUtils.loadCompendium("fvtt-cthulhu-eternal.skills")
       data.items = data.items || []
       for (let skill of skills) {
-        if (skill.system.settings === era ) {
+        if (skill.system.settings === era) {
           data.items.push(skill.toObject())
         }
       }
@@ -30,7 +30,7 @@ export default class CthulhuEternalActor extends Actor {
 
   _onUpdate(changed, options, userId) {
     // DEBUG : console.log("CthulhuEternalActor.update", changed, options, userId)
-    if ( changed?.system?.wp?.exhausted) {
+    if (changed?.system?.wp?.exhausted) {
       ChatMessage.create({
         user: userId,
         speaker: { alias: this.name },
@@ -42,19 +42,36 @@ export default class CthulhuEternalActor extends Actor {
     return super._onUpdate(changed, options, userId)
   }
 
-  async _preCreate(data, options, user) {
-    await super._preCreate(data, options, user)
-
-    // Configure prototype token settings
-    const prototypeToken = {}
-    if (this.type === "protagonist") {
-      Object.assign(prototypeToken, {
-        sight: { enabled: true },
-        actorLink: true,
-        disposition: CONST.TOKEN_DISPOSITIONS.FRIENDLY,
-      })
-      this.updateSource({ prototypeToken })
+  async createEmbeddedDocuments(embeddedName, data, operation) {
+    let newData = []
+    if (embeddedName === "Item") {
+      for (let i of data) {
+        if (i.type === "skill") {
+          if (this.items.find(item => item.name.toLowerCase() === i.name.toLowerCase())) {
+            ui.notifications.warn(game.i18n.localize("CTHULHUETERNAL.Notifications.skillAlreadyExists"))
+            continue
+          }
+        }
+        newData.push(i)
+      }
+      return super.createEmbeddedDocuments(embeddedName, newData, operation)
     }
+    return super.createEmbeddedDocuments(embeddedName, data, operation)
   }
 
+  async _preCreate(data, options, user) {
+  await super._preCreate(data, options, user)
+
+  // Configure prototype token settings
+  const prototypeToken = {}
+  if (this.type === "protagonist") {
+    Object.assign(prototypeToken, {
+      sight: { enabled: true },
+      actorLink: true,
+      disposition: CONST.TOKEN_DISPOSITIONS.FRIENDLY,
+    })
+    this.updateSource({ prototypeToken })
+  }
+}
+
 }